mirror of
https://github.com/postgres/postgres.git
synced 2026-02-24 18:37:22 -05:00
a3c7a993d5
Previously, if an INSERT with multiple rows of VALUES had indirection (array subscripting or field selection) in its target-columns list, the parser handled that by applying transformAssignedExpr() to each element of each VALUES row independently. This led to having ArrayRef assignment nodes or FieldStore nodes in each row of the VALUES RTE. That works for simple cases, but in bug #14265 Nuri Boardman points out that it fails if there are multiple assignments to elements/fields of the same target column. For such cases to work, rewriteTargetListIU() has to nest the ArrayRefs or FieldStores together to produce a single expression to be assigned to the column. But it failed to find them in the top-level targetlist and issued an error about "multiple assignments to same column". We could possibly fix this by teaching the rewriter to apply rewriteTargetListIU to each VALUES row separately, but that would be messy (it would change the output rowtype of the VALUES RTE, for example) and inefficient. Instead, let's fix the parser so that the VALUES RTE outputs are just the user-specified values, cast to the right type if necessary, and then the ArrayRefs or FieldStores are applied in the top-level targetlist to Vars representing the RTE's outputs. This is the same parsetree representation already used for similar cases with INSERT/SELECT syntax, so it allows simplifications in ruleutils.c, which no longer needs to treat INSERT-from-multiple-VALUES as its own special case. This implementation works by applying transformAssignedExpr to the VALUES entries as before, and then stripping off any ArrayRefs or FieldStores it adds. With lots of VALUES rows it would be noticeably more efficient to not add those nodes in the first place. But that's just an optimization not a bug fix, and there doesn't seem to be any good way to do it without significant refactoring. (A non-invasive answer would be to apply transformAssignedExpr + stripping to just the first VALUES row, and then just forcibly cast remaining rows to the same data types exposed in the first row. But this way would lead to different, not-INSERT-specific errors being reported in casting failure cases, so it doesn't seem very nice.) So leave that for later; this patch at least isn't making the per-row parsing work worse, and it does make the finished parsetree smaller, saving rewriter and planner work. Catversion bump because stored rules containing such INSERTs would need to change. Because of that, no back-patch, even though this is a very long-standing bug. Report: <20160727005725.7438.26021@wrigleys.postgresql.org> Discussion: <9578.1469645245@sss.pgh.pa.us> |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| binary_upgrade.h | ||
| catalog.h | ||
| catversion.h | ||
| dependency.h | ||
| duplicate_oids | ||
| genbki.h | ||
| heap.h | ||
| index.h | ||
| indexing.h | ||
| namespace.h | ||
| objectaccess.h | ||
| objectaddress.h | ||
| opfam_internal.h | ||
| pg_aggregate.h | ||
| pg_am.h | ||
| pg_amop.h | ||
| pg_amproc.h | ||
| pg_attrdef.h | ||
| pg_attribute.h | ||
| pg_auth_members.h | ||
| pg_authid.h | ||
| pg_cast.h | ||
| pg_class.h | ||
| pg_collation.h | ||
| pg_collation_fn.h | ||
| pg_constraint.h | ||
| pg_constraint_fn.h | ||
| pg_control.h | ||
| pg_conversion.h | ||
| pg_conversion_fn.h | ||
| pg_database.h | ||
| pg_db_role_setting.h | ||
| pg_default_acl.h | ||
| pg_depend.h | ||
| pg_description.h | ||
| pg_enum.h | ||
| pg_event_trigger.h | ||
| pg_extension.h | ||
| pg_foreign_data_wrapper.h | ||
| pg_foreign_server.h | ||
| pg_foreign_table.h | ||
| pg_index.h | ||
| pg_inherits.h | ||
| pg_inherits_fn.h | ||
| pg_init_privs.h | ||
| pg_language.h | ||
| pg_largeobject.h | ||
| pg_largeobject_metadata.h | ||
| pg_namespace.h | ||
| pg_opclass.h | ||
| pg_operator.h | ||
| pg_operator_fn.h | ||
| pg_opfamily.h | ||
| pg_pltemplate.h | ||
| pg_policy.h | ||
| pg_proc.h | ||
| pg_proc_fn.h | ||
| pg_range.h | ||
| pg_replication_origin.h | ||
| pg_rewrite.h | ||
| pg_seclabel.h | ||
| pg_shdepend.h | ||
| pg_shdescription.h | ||
| pg_shseclabel.h | ||
| pg_statistic.h | ||
| pg_tablespace.h | ||
| pg_transform.h | ||
| pg_trigger.h | ||
| pg_ts_config.h | ||
| pg_ts_config_map.h | ||
| pg_ts_dict.h | ||
| pg_ts_parser.h | ||
| pg_ts_template.h | ||
| pg_type.h | ||
| pg_type_fn.h | ||
| pg_user_mapping.h | ||
| storage.h | ||
| storage_xlog.h | ||
| toasting.h | ||
| unused_oids | ||