mirror of
https://github.com/postgres/postgres.git
synced 2026-03-19 09:05:11 -04:00
5ac340602e
We are capable of optimizing MIN() and MAX() aggregates on indexed columns into subqueries that exploit the index, rather than the normal thing of scanning the whole table. When we do this, we replace the Aggref node(s) with Params referencing subquery outputs. Such Params really ought to be included in the per-plan-node extParam/allParam sets computed by SS_finalize_plan. However, we've never done so up to now because of an ancient implementation choice to perform that substitution during set_plan_references, which runs after SS_finalize_plan, so that SS_finalize_plan never sees these Params. The cleanest fix would be to perform a separate tree walk to do these substitutions before SS_finalize_plan runs. That seems unattractive, first because a whole-tree mutation pass is expensive, and second because we lack infrastructure for visiting expression subtrees in a Plan tree, so that we'd need a new function knowing as much as SS_finalize_plan knows about that. I also considered swapping the order of SS_finalize_plan and set_plan_references, but that fell foul of various assumptions that seem tricky to fix. So the approach adopted here is to teach SS_finalize_plan itself to check for such Aggrefs. I refactored things a bit in setrefs.c to avoid having three copies of the code that does that. Back-patch of v17 commits |
||
|---|---|---|
| .. | ||
| appendinfo.h | ||
| clauses.h | ||
| cost.h | ||
| geqo.h | ||
| geqo_copy.h | ||
| geqo_gene.h | ||
| geqo_misc.h | ||
| geqo_mutation.h | ||
| geqo_pool.h | ||
| geqo_random.h | ||
| geqo_recombination.h | ||
| geqo_selection.h | ||
| inherit.h | ||
| joininfo.h | ||
| optimizer.h | ||
| orclauses.h | ||
| paramassign.h | ||
| pathnode.h | ||
| paths.h | ||
| placeholder.h | ||
| plancat.h | ||
| planmain.h | ||
| planner.h | ||
| prep.h | ||
| restrictinfo.h | ||
| subselect.h | ||
| tlist.h | ||