mirror of
https://github.com/postgres/postgres.git
synced 2026-04-15 22:10:45 -04:00
f7819baa61
Windows apparently will not detect socket write-ready events unless a
preceding send attempt returned WSAEWOULDBLOCK. In many usage patterns
that's satisfied by the caller of WaitEvenSetWait(), but not always.
Apply the same solution that we already had in pgwin32_select(), namely to
perform a dummy WSASend() call with len=0. This will return WSAEWOULDBLOCK
if there's no buffer space (even though it could legitimately do nothing
and report success, which makes me a bit nervous about this solution;
but since it's been working fine in libpq, let's roll with it).
In passing, improve the comments about this in pgwin32_select(), and remove
duplicated code there.
Back-patch to 9.6 where WaitEventSetWait() was introduced. We might need
to back-patch something similar into predecessor code. But given the lack
of complaints so far, it's not clear that the case ever gets exercised
in the back branches, so I'm not going to expend effort on it right now.
This should resolve recurring failures on buildfarm member bowerbird,
which has been failing since
|
||
|---|---|---|
| .. | ||
| aix | ||
| dynloader | ||
| hpux | ||
| tas | ||
| win32 | ||
| .gitignore | ||
| atomics.c | ||
| Makefile | ||
| posix_sema.c | ||
| sysv_sema.c | ||
| sysv_shmem.c | ||
| win32_sema.c | ||
| win32_shmem.c | ||