upstream/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2026-02-03 20:39:32 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 15

Merge pull request #17969 from 1seal/relabel-steps-linear

Browse source 
web/api: compute relabel_steps in a single pass
This commit is contained in:
Julius Volz 2026-01-29 20:55:25 +01:00 committed by GitHub
commit 0c543d5a41
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 64 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
web/api/v1/api.go
View file

@ -1352,13 +1352,19 @@ func (api *API) targetRelabelSteps(r *http.Request) apiFuncResult {
rules := scrapeConfig.RelabelConfigs
steps := make([]RelabelStep, len(rules))
lb := labels.NewBuilder(lbls)
keep := true
for i, rule := range rules {
outLabels, keep := relabel.Process(lbls, rules[:i+1]...)
steps[i] = RelabelStep{
Rule: rule,
Output: outLabels,
Keep: keep,
if keep {
keep = relabel.ProcessBuilder(lb, rule)
}
outLabels := labels.EmptyLabels()
if keep {
outLabels = lb.Labels()
}
steps[i] = RelabelStep{Rule: rule, Output: outLabels, Keep: keep}
}
return apiFuncResult{&RelabelStepsResponse{Steps: steps}, nil, nil, nil}

56
web/api/v1/api_test.go
View file

@ -166,8 +166,8 @@ func (t testTargetRetriever) TargetsDroppedCounts() map[string]int {
return r
}
func (testTargetRetriever) ScrapePoolConfig(_ string) (*config.ScrapeConfig, error) {
return &config.ScrapeConfig{
func (testTargetRetriever) ScrapePoolConfig(pool string) (*config.ScrapeConfig, error) {
cfg := &config.ScrapeConfig{
RelabelConfigs: []*relabel.Config{
{
Action: relabel.Replace,
@ -182,7 +182,16 @@ func (testTargetRetriever) ScrapePoolConfig(_ string) (*config.ScrapeConfig, err
Regex: relabel.MustNewRegexp(`example\.com:.*`),
},
},
}, nil
}
if pool == "testpool3" {
cfg.RelabelConfigs = append(cfg.RelabelConfigs, &relabel.Config{
Action: relabel.Replace,
TargetLabel: "job",
Regex: relabel.MustNewRegexp(".*"),
Replacement: "should_not_apply",
})
}
return cfg, nil
}
func (t *testTargetRetriever) SetMetadataStoreForTargets(identifier string, metadata scrape.MetricMetadataStore) error {
@ -1937,6 +1946,47 @@ func testEndpoints(t *testing.T, api *API, tr *testTargetRetriever, testLabelAPI
},
},
},
{
endpoint: api.targetRelabelSteps,
query: url.Values{"scrapePool": []string{"testpool3"}, "labels": []string{`{"job":"test","__address__":"localhost:9090"}`}},
response: &RelabelStepsResponse{
Steps: []RelabelStep{
{
Rule: &relabel.Config{
Action: relabel.Replace,
Replacement: "example.com:443",
TargetLabel: "__address__",
Regex: relabel.MustNewRegexp(""),
NameValidationScheme: model.LegacyValidation,
},
Output: labels.FromMap(map[string]string{
"job": "test",
"__address__": "example.com:443",
}),
Keep: true,
},
{
Rule: &relabel.Config{
Action: relabel.Drop,
SourceLabels: []model.LabelName{"__address__"},
Regex: relabel.MustNewRegexp(`example\.com:.*`),
},
Output: labels.EmptyLabels(),
Keep: false,
},
{
Rule: &relabel.Config{
Action: relabel.Replace,
TargetLabel: "job",
Regex: relabel.MustNewRegexp(".*"),
Replacement: "should_not_apply",
},
Output: labels.EmptyLabels(),
Keep: false,
},
},
},
},
// With a matching metric.
{
endpoint: api.targetMetadata,