From 2cf747962216af0c8b515db8a6df9eae8bef7ba5 Mon Sep 17 00:00:00 2001 From: Mateusz Gozdek Date: Mon, 25 Oct 2021 09:18:26 +0200 Subject: [PATCH] web: prepare TestFederation_NotReady test for parallel execution Later on in the test we override fields of handler, so we need a handler per sub-test, rather than a global one. Signed-off-by: Mateusz Gozdek --- web/federate_test.go | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/web/federate_test.go b/web/federate_test.go index 201109e887..8bdef3fa8e 100644 --- a/web/federate_test.go +++ b/web/federate_test.go @@ -253,18 +253,19 @@ func (notReadyReadStorage) Stats(string) (*tsdb.Stats, error) { // Regression test for https://github.com/prometheus/prometheus/issues/7181. func TestFederation_NotReady(t *testing.T) { - h := &Handler{ - localStorage: notReadyReadStorage{}, - lookbackDelta: 5 * time.Minute, - now: func() model.Time { return 101 * 60 * 1000 }, // 101min after epoch. - config: &config.Config{ - GlobalConfig: config.GlobalConfig{}, - }, - } - for name, scenario := range scenarios { t.Run(name, func(t *testing.T) { - h.config.GlobalConfig.ExternalLabels = scenario.externalLabels + h := &Handler{ + localStorage: notReadyReadStorage{}, + lookbackDelta: 5 * time.Minute, + now: func() model.Time { return 101 * 60 * 1000 }, // 101min after epoch. + config: &config.Config{ + GlobalConfig: config.GlobalConfig{ + ExternalLabels: scenario.externalLabels, + }, + }, + } + req := httptest.NewRequest("GET", "http://example.org/federate?"+scenario.params, nil) res := httptest.NewRecorder()