From 2dec6da3d18aff112309aae4f2dc87f440bb8155 Mon Sep 17 00:00:00 2001 From: Bryan Boreham Date: Sat, 17 Jan 2026 16:37:18 +0000 Subject: [PATCH] [TESTS] Scraping: Reset appender in BenchmarkScrapeLoopAppend Otherwise performance is dominated by adding to a slice that gets longer and longer as the benchmark progresses. I chose to Rollback rather than Commit because that should do less work. Signed-off-by: Bryan Boreham --- scrape/scrape_test.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scrape/scrape_test.go b/scrape/scrape_test.go index c2b2ae132c..07d9f66266 100644 --- a/scrape/scrape_test.go +++ b/scrape/scrape_test.go @@ -1384,6 +1384,8 @@ func BenchmarkScrapeLoopAppend(b *testing.B) { if err != nil { b.Fatal(err) } + app.Rollback() // Reset the appender so it doesn't grow indefinitely. + app = sl.appender() } }) }