upstream/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2026-02-03 20:39:32 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

PromQL: Add a size-1 pool of FPoint slices

Browse source 
This should work better when the PromQL engine is executing instant
queries and range queries in rapid succession.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
This commit is contained in:
Bryan Boreham 2025-12-19 18:54:07 +00:00
parent a72a2a4a9f
commit cbb83e1647
1 changed files with 13 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
promql/engine.go
View file

@ -2480,8 +2480,9 @@ func (ev *evaluator) vectorSelectorSingle(it *storage.MemoizedSeriesIterator, of
}
var (
fPointPool zeropool.Pool[[]FPoint]
hPointPool zeropool.Pool[[]HPoint]
fPointPool zeropool.Pool[[]FPoint]
fPoint1Pool zeropool.Pool[[]FPoint]
hPointPool zeropool.Pool[[]HPoint]
// matrixSelectorHPool holds reusable histogram slices used by the matrix
// selector. The key difference between this pool and the hPointPool is that
@ -2492,7 +2493,11 @@ var (
)
func getFPointSlice(sz int) []FPoint {
if p := fPointPool.Get(); p != nil {
if sz == 1 {
if p := fPoint1Pool.Get(); p != nil {
return p
}
} else if p := fPointPool.Get(); p != nil {
return p
}
@ -2507,7 +2512,11 @@ func getFPointSlice(sz int) []FPoint {
// This function is called with an estimated size which often can be over-estimated.
func putFPointSlice(p []FPoint) {
if p != nil {
fPointPool.Put(p[:0])
if cap(p) == 1 {
fPoint1Pool.Put(p[:0])
} else {
fPointPool.Put(p[:0])
}
}
}