upstream/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2026-02-03 20:39:32 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 15

util: enhance test coverage for strutil package

Browse source 
- Added comprehensive edge case tests for SanitizeLabelName (10 cases)
- Added comprehensive edge case tests for SanitizeFullLabelName (15 cases)
- Added more test cases for link generation functions (4 additional cases)
- Fixed unicode test case: corrected expected underscores from 7 to 5
- Fixed digits test case: corrected expected output from '_____' to '_2345'
- Converted tests to table-driven format with named subtests
- Achieved 100% code coverage for the package

Signed-off-by: Ritik Shukla <ritikshukla@Ritiks-MacBook-Air.local>
This commit is contained in:
Ritik Shukla 2026-01-10 16:05:21 +05:30
parent 9cb3641ccd
commit f9242d4707
1 changed files with 169 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

189
util/strutil/strconv_test.go
View file

@ -36,6 +36,26 @@ var linkTests = []linkTest{
"/graph?g0.expr=sum%28incoming_http_requests_total%7Bsystem%3D%22trackmetadata%22%7D%29&g0.tab=0",
"/graph?g0.expr=sum%28incoming_http_requests_total%7Bsystem%3D%22trackmetadata%22%7D%29&g0.tab=1",
},
{
"up",
"/graph?g0.expr=up&g0.tab=0",
"/graph?g0.expr=up&g0.tab=1",
},
{
"rate(http_requests_total[5m])",
"/graph?g0.expr=rate%28http_requests_total%5B5m%5D%29&g0.tab=0",
"/graph?g0.expr=rate%28http_requests_total%5B5m%5D%29&g0.tab=1",
},
{
"",
"/graph?g0.expr=&g0.tab=0",
"/graph?g0.expr=&g0.tab=1",
},
{
"metric_name{label=\"value with spaces\"}",
"/graph?g0.expr=metric_name%7Blabel%3D%22value+with+spaces%22%7D&g0.tab=0",
"/graph?g0.expr=metric_name%7Blabel%3D%22value+with+spaces%22%7D&g0.tab=1",
},
}
func TestLink(t *testing.T) {
@ -51,29 +71,158 @@ func TestLink(t *testing.T) {
}
func TestSanitizeLabelName(t *testing.T) {
actual := SanitizeLabelName("fooClientLABEL")
expected := "fooClientLABEL"
require.Equal(t, expected, actual, "SanitizeLabelName failed for label (%s)", expected)
tests := []struct {
name string
input string
expected string
}{
{
name: "valid label name",
input: "fooClientLABEL",
expected: "fooClientLABEL",
},
{
name: "label with special characters",
input: "barClient.LABEL$$##",
expected: "barClient_LABEL____",
},
{
name: "label starting with digit",
input: "123label",
expected: "123label",
},
{
name: "label with dashes",
input: "my-label-name",
expected: "my_label_name",
},
{
name: "label with spaces",
input: "my label name",
expected: "my_label_name",
},
{
name: "label with mixed case and numbers",
input: "Test123Label456",
expected: "Test123Label456",
},
{
name: "label with unicode characters",
input: "test-ñ-ü-label",
expected: "test_____label",
},
{
name: "empty string",
input: "",
expected: "",
},
{
name: "only underscores",
input: "___",
expected: "___",
},
{
name: "label with colons",
input: "namespace:metric_name",
expected: "namespace_metric_name",
},
}
actual = SanitizeLabelName("barClient.LABEL$$##")
expected = "barClient_LABEL____"
require.Equal(t, expected, actual, "SanitizeLabelName failed for label (%s)", expected)
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
actual := SanitizeLabelName(tt.input)
require.Equal(t, tt.expected, actual, "SanitizeLabelName(%q) = %q, want %q", tt.input, actual, tt.expected)
})
}
}
func TestSanitizeFullLabelName(t *testing.T) {
actual := SanitizeFullLabelName("fooClientLABEL")
expected := "fooClientLABEL"
require.Equal(t, expected, actual, "SanitizeFullLabelName failed for label (%s)", expected)
tests := []struct {
name string
input string
expected string
}{
{
name: "valid label name",
input: "fooClientLABEL",
expected: "fooClientLABEL",
},
{
name: "label with special characters",
input: "barClient.LABEL$$##",
expected: "barClient_LABEL____",
},
{
name: "label starting with digit",
input: "0zerothClient1LABEL",
expected: "_zerothClient1LABEL",
},
{
name: "empty string",
input: "",
expected: "_",
},
{
name: "label starting with multiple digits",
input: "123abc",
expected: "_23abc",
},
{
name: "label with dashes",
input: "my-label-name",
expected: "my_label_name",
},
{
name: "label with spaces",
input: "my label name",
expected: "my_label_name",
},
{
name: "label with numbers in middle",
input: "Test123Label456",
expected: "Test123Label456",
},
{
name: "single underscore",
input: "_",
expected: "_",
},
{
name: "label starting with underscore",
input: "_validLabel",
expected: "_validLabel",
},
{
name: "label with colons",
input: "namespace:metric_name",
expected: "namespace_metric_name",
},
{
name: "label with unicode characters",
input: "test-ñ-ü-label",
expected: "test_____label",
},
{
name: "only digits",
input: "12345",
expected: "_2345",
},
{
name: "label with mixed invalid characters at start",
input: "!@#test",
expected: "___test",
},
{
name: "label with consecutive digits at start",
input: "0123test",
expected: "_123test",
},
}
actual = SanitizeFullLabelName("barClient.LABEL$$##")
expected = "barClient_LABEL____"
require.Equal(t, expected, actual, "SanitizeFullLabelName failed for label (%s)", expected)
actual = SanitizeFullLabelName("0zerothClient1LABEL")
expected = "_zerothClient1LABEL"
require.Equal(t, expected, actual, "SanitizeFullLabelName failed for label (%s)", expected)
actual = SanitizeFullLabelName("")
expected = "_"
require.Equal(t, expected, actual, "SanitizeFullLabelName failed for the empty label")
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
actual := SanitizeFullLabelName(tt.input)
require.Equal(t, tt.expected, actual, "SanitizeFullLabelName(%q) = %q, want %q", tt.input, actual, tt.expected)
})
}
}