Commit graph

6 commits

Author SHA1 Message Date
George Krajcsovits
8047b05b3c
chore(codeowners): promote matt-gp external github user to owner of AWS SD (#17946)
Branch protection means they cannot merge PRs to main/release branches.
Branch protection means they cannot approve things outside their area for
PRs to main/release branches.

Also add sysadmind (Joe) as ower of aws, to make sure he gets notified.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2026-01-28 08:20:06 +01:00
George Krajcsovits
d25c8476e7
chore(sd-ownership): add default-maintainers as default code owner (#17940)
* chore(sd-ownership): add default-maintainers as default code owner

In accordance with dev summit decision.
At the same time I've set up auto assignment for code review, meaning
that not everybody will get notified for all PRs. If there's already
a maintainer assigned, you don't get notified. Otherwise the
assignment is round-robin, 1 at a time. Also you can opt out.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>

* Remove code owner without write access

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>

---------

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2026-01-27 11:06:11 +01:00
George Krajcsovits
962341f621
Add more potential code owners for SD (#17709)
Some checks failed
buf.build / lint and publish (push) Has been cancelled
CI / Go tests (push) Has been cancelled
CI / More Go tests (push) Has been cancelled
CI / Go tests with previous Go version (push) Has been cancelled
CI / UI tests (push) Has been cancelled
CI / Go tests on Windows (push) Has been cancelled
CI / Mixins tests (push) Has been cancelled
CI / Build Prometheus for common architectures (push) Has been cancelled
CI / Build Prometheus for all architectures (push) Has been cancelled
CI / Check generated parser (push) Has been cancelled
CI / golangci-lint (push) Has been cancelled
CI / fuzzing (push) Has been cancelled
CI / codeql (push) Has been cancelled
Scorecards supply-chain security / Scorecards analysis (push) Has been cancelled
CI / Report status of build Prometheus for all architectures (push) Has been cancelled
CI / Publish main branch artifacts (push) Has been cancelled
CI / Publish release artefacts (push) Has been cancelled
CI / Publish UI on npm Registry (push) Has been cancelled
To enable when we work out how to give approval right to their paths
only.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2025-12-17 10:13:49 -05:00
George Krajcsovits
9ab52f9211
Do not notify the prometheus/default-maintainers team for code reviews (#17705)
Remove default-maintainers as the backup for all code.
Everybody in that team is a prometheus team member, but not everybody
wants to get notified for all review requests.

Downside is that if we enable require codeowners approval, the team
member cannot approve any PR anymore.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2025-12-16 18:01:14 +00:00
George Krajcsovits
39c7fca0e9
Move CODEOWNERS from .github to root (#17664)
* Move CODEOWNERS from .github to root

The default maintainers are added to each line to make sure that
prometheus team members can still approve if:
- specific code owner is not responding
- we require code owner review (not currently)

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>

* Apply suggestions from code review

Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>

* Update CODEOWNERS

Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>

* add notice about keeping the files in sync

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>

---------

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
2025-12-16 12:40:45 +01:00
György Krajcsovits
9b99af7cf3
chore(github): add CODEOWNERS file
In order to allow for non team members to be maintainers of components
like service discovery.

Design doc:
https://docs.google.com/document/d/19m5ti00ZzzOspn60xyiK961J6M7g-rC1THNMkYWQbBc/edit?tab=t.0#heading=h.5sybau7waq2q

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
2025-10-28 14:13:37 +01:00