prometheus/web/api/testhelpers/assertions.go
Julien 75f94903b3
Add OpenAPI 3.2 specification generation for Prometheus HTTP API (#17825)
* Add OpenAPI 3.2 specification generation for Prometheus HTTP API

This commit introduces an OpenAPI specification for the Prometheus API.
After testing multiple code-generation servers with built-in APIs, this
implementation uses an independent spec file outside of the critical path.
This spec file is tested with a framework present in this pull request.

The specification helps clients know which parameters they can use and is
served at /api/v1/openapi.yaml. The spec file will evolve with the
Prometheus API and has the same version number.

Downstream projects can tune the APIs presented in the spec file with
configuration options using the IncludePaths setting for path filtering.

In the future, there is room to generate a server from this spec file
(e.g. with interfaces), but this is out of scope for this pull request.

Architecture:
- Core OpenAPI infrastructure (openapi.go): Dynamic spec building,
  caching, and thread-safe spec generation
- Schema definitions (openapi_schemas.go): Complete type definitions
  for all API request and response types
- Path specifications (openapi_paths.go): Endpoint definitions with
  parameters, request bodies, and response schemas
- Examples (openapi_examples.go): Realistic request/response examples
- Helper functions (openapi_helpers.go): Reusable builders for common
  OpenAPI structures

Testing:
- Comprehensive test suite with golden file validation
- Test helpers package for API testing infrastructure
- OpenAPI compliance validation utilities

The golden file captures the complete specification for snapshot testing.
Update with: go test -run TestOpenAPIGolden -update-openapi-spec

REVIEWERS: The most important thing to check would be the OpenAPI golden
file (web/api/v1/testdata/openapi_golden.yaml). Test scenarios are important
as they test the actual OpenAPI spec validity.

Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>

* Add OpenAPI 3.1 support with version selection

Add support for both OpenAPI 3.1 and 3.2 specifications with version
selection via openapi_version query parameter. Defaults to 3.1 for
broader compatibility

Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>

* Enhance OpenAPI examples and add helper functions

- Add timestampExamples helper for consistent time formatting
- Add exampleMap helper to simplify example creation
- Improve example summaries with query details
- Add matrix result example for range vector queries

Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>

* web/api: Add AtST method to test helper iterators

Implement the AtST() method required by chunkenc.Iterator interface
for FakeSeriesIterator and FakeHistogramSeriesIterator test helpers.
The method returns 0 as these test helpers don't use start timestamps

Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>

* OpenAPI: Add minimum coverage test

Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>

* OpenAPI: Improve examples handling

Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>

---------

Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
2026-01-29 13:36:13 +01:00

252 lines
8.5 KiB
Go

// Copyright The Prometheus Authors
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
// This file provides assertion helpers for validating API responses in tests.
package testhelpers
import (
"fmt"
"slices"
"strings"
"github.com/stretchr/testify/require"
)
// RequireSuccess asserts that the response has status "success" and returns the response for chaining.
func (r *Response) RequireSuccess() *Response {
r.t.Helper()
require.NotNil(r.t, r.JSON, "response body is not JSON")
require.Equal(r.t, "success", r.JSON["status"], "expected status to be 'success'")
return r
}
// RequireError asserts that the response has status "error" and returns the response for chaining.
func (r *Response) RequireError() *Response {
r.t.Helper()
require.NotNil(r.t, r.JSON, "response body is not JSON")
require.Equal(r.t, "error", r.JSON["status"], "expected status to be 'error'")
return r
}
// RequireStatusCode asserts that the response has the given HTTP status code and returns the response for chaining.
func (r *Response) RequireStatusCode(expectedCode int) *Response {
r.t.Helper()
require.Equal(r.t, expectedCode, r.StatusCode, "unexpected HTTP status code")
return r
}
// RequireJSONPathExists asserts that a JSON path exists and returns the response for chaining.
func (r *Response) RequireJSONPathExists(path string) *Response {
r.t.Helper()
require.NotNil(r.t, r.JSON, "response body is not JSON")
value := getJSONPath(r.JSON, path)
require.NotNil(r.t, value, "JSON path %q does not exist", path)
return r
}
// RequireEquals asserts that a JSON path equals the expected value and returns the response for chaining.
func (r *Response) RequireEquals(path string, expected any) *Response {
r.t.Helper()
require.NotNil(r.t, r.JSON, "response body is not JSON")
value := getJSONPath(r.JSON, path)
require.NotNil(r.t, value, "JSON path %q does not exist", path)
require.Equal(r.t, expected, value, "JSON path %q has unexpected value", path)
return r
}
// RequireJSONArray asserts that a JSON path contains an array and returns the response for chaining.
func (r *Response) RequireJSONArray(path string) *Response {
r.t.Helper()
require.NotNil(r.t, r.JSON, "response body is not JSON")
value := getJSONPath(r.JSON, path)
require.NotNil(r.t, value, "JSON path %q does not exist", path)
_, ok := value.([]any)
require.True(r.t, ok, "JSON path %q is not an array", path)
return r
}
// RequireLenAtLeast asserts that a JSON path contains an array with at least minLen elements and returns the response for chaining.
func (r *Response) RequireLenAtLeast(path string, minLen int) *Response {
r.t.Helper()
require.NotNil(r.t, r.JSON, "response body is not JSON")
value := getJSONPath(r.JSON, path)
require.NotNil(r.t, value, "JSON path %q does not exist", path)
arr, ok := value.([]any)
require.True(r.t, ok, "JSON path %q is not an array", path)
require.GreaterOrEqual(r.t, len(arr), minLen, "JSON path %q has fewer than %d elements", path, minLen)
return r
}
// RequireArrayContains asserts that a JSON path contains an array with the expected element and returns the response for chaining.
func (r *Response) RequireArrayContains(path string, expected any) *Response {
r.t.Helper()
require.NotNil(r.t, r.JSON, "response body is not JSON")
value := getJSONPath(r.JSON, path)
require.NotNil(r.t, value, "JSON path %q does not exist", path)
arr, ok := value.([]any)
require.True(r.t, ok, "JSON path %q is not an array", path)
found := slices.Contains(arr, expected)
require.True(r.t, found, "JSON path %q does not contain expected value %v", path, expected)
return r
}
// RequireSome asserts that at least one element in an array satisfies the predicate and returns the response for chaining.
func (r *Response) RequireSome(path string, predicate func(any) bool) *Response {
r.t.Helper()
require.NotNil(r.t, r.JSON, "response body is not JSON")
value := getJSONPath(r.JSON, path)
require.NotNil(r.t, value, "JSON path %q does not exist", path)
arr, ok := value.([]any)
require.True(r.t, ok, "JSON path %q is not an array", path)
found := slices.ContainsFunc(arr, predicate)
require.True(r.t, found, "no element in JSON path %q satisfies the predicate", path)
return r
}
// getJSONPath extracts a value from a JSON object using a simple path notation.
// Supports paths like "$.data", "$.data.groups", "$.data.groups[0]".
func getJSONPath(data map[string]any, path string) any {
// Remove leading "$." if present.
path = strings.TrimPrefix(path, "$.")
if path == "" {
return data
}
parts := strings.Split(path, ".")
current := any(data)
for _, part := range parts {
// Handle array indexing (e.g., "groups[0]").
if strings.Contains(part, "[") {
// Not implementing array indexing for simplicity.
// Tests should use direct field access or RequireSome.
return nil
}
// Navigate to the next level.
m, ok := current.(map[string]any)
if !ok {
return nil
}
current = m[part]
}
return current
}
// RequireVectorResult is a convenience helper for checking vector query results.
func (r *Response) RequireVectorResult() *Response {
r.t.Helper()
return r.RequireSuccess().RequireEquals("$.data.resultType", "vector")
}
// RequireMatrixResult is a convenience helper for checking matrix query results.
func (r *Response) RequireMatrixResult() *Response {
r.t.Helper()
return r.RequireSuccess().RequireEquals("$.data.resultType", "matrix")
}
// RequireScalarResult is a convenience helper for checking scalar query results.
func (r *Response) RequireScalarResult() *Response {
r.t.Helper()
return r.RequireSuccess().RequireEquals("$.data.resultType", "scalar")
}
// RequireRulesGroupNamed asserts that a rules response contains a group with the given name.
func (r *Response) RequireRulesGroupNamed(name string) *Response {
r.t.Helper()
return r.RequireSuccess().RequireSome("$.data.groups", func(group any) bool {
if g, ok := group.(map[string]any); ok {
return g["name"] == name
}
return false
})
}
// RequireTargetCount asserts that a targets response contains at least n targets.
func (r *Response) RequireTargetCount(minCount int) *Response {
r.t.Helper()
r.RequireSuccess()
// The targets endpoint returns activeTargets as an array of targets.
value := getJSONPath(r.JSON, "$.data.activeTargets")
require.NotNil(r.t, value, "JSON path $.data.activeTargets does not exist")
arr, ok := value.([]any)
require.True(r.t, ok, "$.data.activeTargets is not an array")
require.GreaterOrEqual(r.t, len(arr), minCount, "expected at least %d targets, got %d", minCount, len(arr))
return r
}
// DebugJSON is a helper for debugging JSON responses in tests.
func (r *Response) DebugJSON() *Response {
r.t.Helper()
r.t.Logf("Response status code: %d", r.StatusCode)
r.t.Logf("Response body: %s", r.Body)
if r.JSON != nil {
r.t.Logf("Response JSON: %+v", r.JSON)
}
return r
}
// RequireContainsSubstring asserts that the response body contains the given substring.
func (r *Response) RequireContainsSubstring(substring string) *Response {
r.t.Helper()
require.Contains(r.t, r.Body, substring, "response body does not contain expected substring")
return r
}
// RequireField asserts that a field exists at the given path and returns its value.
// Note: This method cannot be chained further since it returns the field value, not the Response.
func (r *Response) RequireField(path string) any {
r.t.Helper()
require.NotNil(r.t, r.JSON, "response body is not JSON")
value := getJSONPath(r.JSON, path)
require.NotNil(r.t, value, "JSON path %q does not exist", path)
return value
}
// RequireFieldType asserts that a field exists and has the expected type.
func (r *Response) RequireFieldType(path, expectedType string) *Response {
r.t.Helper()
value := r.RequireField(path)
var actualType string
switch value.(type) {
case string:
actualType = "string"
case float64:
actualType = "number"
case bool:
actualType = "bool"
case []any:
actualType = "array"
case map[string]any:
actualType = "object"
default:
actualType = fmt.Sprintf("%T", value)
}
require.Equal(r.t, expectedType, actualType, "JSON path %q has unexpected type", path)
return r
}