prometheus/notifier/manager_test.go
Arve Knudsen 020a0b30a0
notifier: fix flaky TestStop_DrainingEnabled and TestStop_DrainingDisabled race conditions (#17938)
Fix flaky TestStop_DrainingEnabled and TestStop_DrainingDisabled tests.
The tests used real HTTP servers and real time, making them susceptible to
race conditions and timing-dependent failures.
The solution is to convert both tests to use synctest for deterministic fake time.

---------

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2026-01-29 08:07:32 +01:00

1560 lines
46 KiB
Go

// Copyright The Prometheus Authors
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package notifier
import (
"bytes"
"context"
"encoding/json"
"fmt"
"io"
"log/slog"
"net/http"
"net/http/httptest"
"net/url"
"strconv"
"strings"
"testing"
"time"
"github.com/prometheus/client_golang/prometheus"
prom_testutil "github.com/prometheus/client_golang/prometheus/testutil"
config_util "github.com/prometheus/common/config"
"github.com/prometheus/common/model"
"github.com/prometheus/common/promslog"
"github.com/stretchr/testify/require"
"go.uber.org/atomic"
"go.yaml.in/yaml/v2"
"github.com/prometheus/prometheus/config"
"github.com/prometheus/prometheus/discovery"
_ "github.com/prometheus/prometheus/discovery/file"
"github.com/prometheus/prometheus/discovery/targetgroup"
"github.com/prometheus/prometheus/model/labels"
"github.com/prometheus/prometheus/model/relabel"
"github.com/prometheus/prometheus/util/testutil/synctest"
)
func alertsEqual(a, b []*Alert) error {
if len(a) != len(b) {
return fmt.Errorf("length mismatch: %v != %v", a, b)
}
for i, alert := range a {
if !labels.Equal(alert.Labels, b[i].Labels) {
return fmt.Errorf("label mismatch at index %d: %s != %s", i, alert.Labels, b[i].Labels)
}
}
return nil
}
func newTestHTTPServerBuilder(expected *[]*Alert, errc chan<- error, u, p string, status *atomic.Int32) *httptest.Server {
return httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
var err error
defer func() {
if err == nil {
return
}
select {
case errc <- err:
default:
}
}()
user, pass, _ := r.BasicAuth()
if user != u || pass != p {
err = fmt.Errorf("unexpected user/password: %s/%s != %s/%s", user, pass, u, p)
w.WriteHeader(http.StatusInternalServerError)
return
}
b, err := io.ReadAll(r.Body)
if err != nil {
err = fmt.Errorf("error reading body: %w", err)
w.WriteHeader(http.StatusInternalServerError)
return
}
var alerts []*Alert
err = json.Unmarshal(b, &alerts)
if err == nil {
err = alertsEqual(*expected, alerts)
}
w.WriteHeader(int(status.Load()))
}))
}
func newTestAlertmanagerSet(
cfg *config.AlertmanagerConfig,
client *http.Client,
opts *Options,
metrics *alertMetrics,
alertmanagerURLs ...string,
) *alertmanagerSet {
ams := make([]alertmanager, len(alertmanagerURLs))
for i, am := range alertmanagerURLs {
ams[i] = alertmanagerMock{urlf: func() string { return am }}
}
logger := slog.New(slog.DiscardHandler)
sendLoops := make(map[string]*sendLoop)
for _, am := range alertmanagerURLs {
sendLoops[am] = newSendLoop(am, client, cfg, opts, logger, metrics)
}
return &alertmanagerSet{
ams: ams,
cfg: cfg,
client: client,
logger: logger,
metrics: metrics,
opts: opts,
sendLoops: sendLoops,
}
}
func TestHandlerSendAll(t *testing.T) {
var (
errc = make(chan error, 1)
expected = make([]*Alert, 0)
status1, status2, status3 atomic.Int32
)
status1.Store(int32(http.StatusOK))
status2.Store(int32(http.StatusOK))
status3.Store(int32(http.StatusOK))
server1 := newTestHTTPServerBuilder(&expected, errc, "prometheus", "testing_password", &status1)
server2 := newTestHTTPServerBuilder(&expected, errc, "", "", &status2)
server3 := newTestHTTPServerBuilder(&expected, errc, "", "", &status3)
defer server1.Close()
defer server2.Close()
defer server3.Close()
reg := prometheus.NewRegistry()
h := NewManager(&Options{Registerer: reg}, model.UTF8Validation, nil)
authClient, _ := config_util.NewClientFromConfig(
config_util.HTTPClientConfig{
BasicAuth: &config_util.BasicAuth{
Username: "prometheus",
Password: "testing_password",
},
}, "auth_alertmanager")
h.alertmanagers = make(map[string]*alertmanagerSet)
am1Cfg := config.DefaultAlertmanagerConfig
am1Cfg.Timeout = model.Duration(time.Second)
am2Cfg := config.DefaultAlertmanagerConfig
am2Cfg.Timeout = model.Duration(time.Second)
am3Cfg := config.DefaultAlertmanagerConfig
am3Cfg.Timeout = model.Duration(time.Second)
opts := &Options{Do: do, QueueCapacity: 10_000, MaxBatchSize: DefaultMaxBatchSize}
h.alertmanagers["1"] = newTestAlertmanagerSet(&am1Cfg, authClient, opts, h.metrics, server1.URL)
h.alertmanagers["2"] = newTestAlertmanagerSet(&am2Cfg, nil, opts, h.metrics, server2.URL, server3.URL)
h.alertmanagers["3"] = newTestAlertmanagerSet(&am3Cfg, nil, opts, h.metrics)
var alerts []*Alert
for i := range DefaultMaxBatchSize {
alerts = append(alerts, &Alert{
Labels: labels.FromStrings("alertname", strconv.Itoa(i)),
})
expected = append(expected, &Alert{
Labels: labels.FromStrings("alertname", strconv.Itoa(i)),
})
}
checkNoErr := func() {
t.Helper()
select {
case err := <-errc:
require.NoError(t, err)
default:
}
}
// Start send loops.
for _, ams := range h.alertmanagers {
ams.startSendLoops(ams.ams)
}
defer func() {
for _, ams := range h.alertmanagers {
ams.cleanSendLoops(ams.ams...)
}
}()
h.Send(alerts...)
require.Eventually(t, func() bool {
return prom_testutil.ToFloat64(h.metrics.sent.WithLabelValues(server1.URL)) == DefaultMaxBatchSize
}, time.Second*2, time.Millisecond*10)
checkNoErr()
// The only am in set 1 is down.
status1.Store(int32(http.StatusNotFound))
h.Send(alerts...)
// Wait for all send loops to process before changing any status.
require.Eventually(t, func() bool {
return prom_testutil.ToFloat64(h.metrics.errors.WithLabelValues(server1.URL)) == DefaultMaxBatchSize &&
prom_testutil.ToFloat64(h.metrics.sent.WithLabelValues(server2.URL)) == DefaultMaxBatchSize*2 &&
prom_testutil.ToFloat64(h.metrics.sent.WithLabelValues(server3.URL)) == DefaultMaxBatchSize*2
}, time.Second*2, time.Millisecond*10)
checkNoErr()
// Fix the am.
status1.Store(int32(http.StatusOK))
// Only one of the ams in set 2 is down.
status2.Store(int32(http.StatusInternalServerError))
h.Send(alerts...)
// Wait for all send loops to either send or fail with errors depending on their status.
require.Eventually(t, func() bool {
return prom_testutil.ToFloat64(h.metrics.errors.WithLabelValues(server2.URL)) == DefaultMaxBatchSize &&
prom_testutil.ToFloat64(h.metrics.sent.WithLabelValues(server1.URL)) == DefaultMaxBatchSize*2 &&
prom_testutil.ToFloat64(h.metrics.sent.WithLabelValues(server3.URL)) == DefaultMaxBatchSize*3
}, time.Second*2, time.Millisecond*10)
checkNoErr()
// Both ams in set 2 are down.
status3.Store(int32(http.StatusInternalServerError))
h.Send(alerts...)
require.Eventually(t, func() bool {
return prom_testutil.ToFloat64(h.metrics.errors.WithLabelValues(server2.URL)) == DefaultMaxBatchSize*2 &&
prom_testutil.ToFloat64(h.metrics.errors.WithLabelValues(server3.URL)) == DefaultMaxBatchSize
}, time.Second*2, time.Millisecond*10)
checkNoErr()
}
func TestHandlerSendAllRemapPerAm(t *testing.T) {
var (
errc = make(chan error, 1)
expected1 = make([]*Alert, 0)
expected2 = make([]*Alert, 0)
expected3 = make([]*Alert, 0)
status1, status2, status3 atomic.Int32
)
status1.Store(int32(http.StatusOK))
status2.Store(int32(http.StatusOK))
status3.Store(int32(http.StatusOK))
server1 := newTestHTTPServerBuilder(&expected1, errc, "", "", &status1)
server2 := newTestHTTPServerBuilder(&expected2, errc, "", "", &status2)
server3 := newTestHTTPServerBuilder(&expected3, errc, "", "", &status3)
defer server1.Close()
defer server2.Close()
defer server3.Close()
reg := prometheus.NewRegistry()
h := NewManager(&Options{QueueCapacity: 10_000, Registerer: reg}, model.UTF8Validation, nil)
h.alertmanagers = make(map[string]*alertmanagerSet)
am1Cfg := config.DefaultAlertmanagerConfig
am1Cfg.Timeout = model.Duration(time.Second)
am2Cfg := config.DefaultAlertmanagerConfig
am2Cfg.Timeout = model.Duration(time.Second)
am2Cfg.AlertRelabelConfigs = []*relabel.Config{
{
SourceLabels: model.LabelNames{"alertnamedrop"},
Action: "drop",
Regex: relabel.MustNewRegexp(".+"),
NameValidationScheme: model.UTF8Validation,
},
}
am3Cfg := config.DefaultAlertmanagerConfig
am3Cfg.Timeout = model.Duration(time.Second)
am3Cfg.AlertRelabelConfigs = []*relabel.Config{
{
SourceLabels: model.LabelNames{"alertname"},
Action: "drop",
Regex: relabel.MustNewRegexp(".+"),
NameValidationScheme: model.UTF8Validation,
},
}
// Drop no alerts.
h.alertmanagers["1"] = newTestAlertmanagerSet(&am1Cfg, nil, h.opts, h.metrics, server1.URL)
// Drop only alerts with the "alertnamedrop" label.
h.alertmanagers["2"] = newTestAlertmanagerSet(&am2Cfg, nil, h.opts, h.metrics, server2.URL)
// Drop all alerts.
h.alertmanagers["3"] = newTestAlertmanagerSet(&am3Cfg, nil, h.opts, h.metrics, server3.URL)
// Empty list of Alertmanager endpoints.
h.alertmanagers["4"] = newTestAlertmanagerSet(&config.DefaultAlertmanagerConfig, nil, h.opts, h.metrics)
var alerts []*Alert
for i := range make([]struct{}, DefaultMaxBatchSize/2) {
alerts = append(alerts,
&Alert{
Labels: labels.FromStrings("alertname", strconv.Itoa(i)),
},
&Alert{
Labels: labels.FromStrings("alertname", "test", "alertnamedrop", strconv.Itoa(i)),
},
)
expected1 = append(expected1,
&Alert{
Labels: labels.FromStrings("alertname", strconv.Itoa(i)),
}, &Alert{
Labels: labels.FromStrings("alertname", "test", "alertnamedrop", strconv.Itoa(i)),
},
)
expected2 = append(expected2, &Alert{
Labels: labels.FromStrings("alertname", strconv.Itoa(i)),
})
}
checkNoErr := func() {
t.Helper()
select {
case err := <-errc:
require.NoError(t, err)
default:
}
}
// Start send loops.
for _, ams := range h.alertmanagers {
ams.startSendLoops(ams.ams)
}
defer func() {
// Stop send loops.
for _, ams := range h.alertmanagers {
ams.cleanSendLoops(ams.ams...)
}
}()
// All ams are up.
h.Send(alerts...)
require.Eventually(t, func() bool {
return prom_testutil.ToFloat64(h.metrics.sent.WithLabelValues(server1.URL)) == DefaultMaxBatchSize
}, time.Second*2, time.Millisecond*10)
checkNoErr()
// The only am in set 1 goes down.
status1.Store(int32(http.StatusInternalServerError))
h.Send(alerts...)
// Wait for metrics to update.
require.Eventually(t, func() bool {
return prom_testutil.ToFloat64(h.metrics.errors.WithLabelValues(server1.URL)) == DefaultMaxBatchSize
}, time.Second*2, time.Millisecond*10)
checkNoErr()
// Reset set 1.
status1.Store(int32(http.StatusOK))
// Set 3 loses its only am, but all alerts were dropped
// so there was nothing to send, keeping sendAll true.
status3.Store(int32(http.StatusInternalServerError))
h.Send(alerts...)
checkNoErr()
}
func TestExternalLabels(t *testing.T) {
reg := prometheus.NewRegistry()
h := NewManager(&Options{
QueueCapacity: 3 * DefaultMaxBatchSize,
MaxBatchSize: DefaultMaxBatchSize,
ExternalLabels: labels.FromStrings("a", "b"),
RelabelConfigs: []*relabel.Config{
{
SourceLabels: model.LabelNames{"alertname"},
TargetLabel: "a",
Action: "replace",
Regex: relabel.MustNewRegexp("externalrelabelthis"),
Replacement: "c",
NameValidationScheme: model.UTF8Validation,
},
},
Registerer: reg,
}, model.UTF8Validation, nil)
cfg := config.DefaultAlertmanagerConfig
h.alertmanagers = map[string]*alertmanagerSet{
"test": newTestAlertmanagerSet(&cfg, nil, h.opts, h.metrics, "test"),
}
// This alert should get the external label attached.
h.Send(&Alert{
Labels: labels.FromStrings("alertname", "test"),
})
// This alert should get the external label attached, but then set to "c"
// through relabelling.
h.Send(&Alert{
Labels: labels.FromStrings("alertname", "externalrelabelthis"),
})
expected := []*Alert{
{Labels: labels.FromStrings("alertname", "test", "a", "b")},
{Labels: labels.FromStrings("alertname", "externalrelabelthis", "a", "c")},
}
require.NoError(t, alertsEqual(expected, h.alertmanagers["test"].sendLoops["test"].queue))
}
func TestHandlerRelabel(t *testing.T) {
reg := prometheus.NewRegistry()
h := NewManager(&Options{
QueueCapacity: 3 * DefaultMaxBatchSize,
MaxBatchSize: DefaultMaxBatchSize,
RelabelConfigs: []*relabel.Config{
{
SourceLabels: model.LabelNames{"alertname"},
Action: "drop",
Regex: relabel.MustNewRegexp("drop"),
NameValidationScheme: model.UTF8Validation,
},
{
SourceLabels: model.LabelNames{"alertname"},
TargetLabel: "alertname",
Action: "replace",
Regex: relabel.MustNewRegexp("rename"),
Replacement: "renamed",
NameValidationScheme: model.UTF8Validation,
},
},
Registerer: reg,
}, model.UTF8Validation, nil)
cfg := config.DefaultAlertmanagerConfig
h.alertmanagers = map[string]*alertmanagerSet{
"test": newTestAlertmanagerSet(&cfg, nil, h.opts, h.metrics, "test"),
}
// This alert should be dropped due to the configuration
h.Send(&Alert{
Labels: labels.FromStrings("alertname", "drop"),
})
// This alert should be replaced due to the configuration
h.Send(&Alert{
Labels: labels.FromStrings("alertname", "rename"),
})
expected := []*Alert{
{Labels: labels.FromStrings("alertname", "renamed")},
}
require.NoError(t, alertsEqual(expected, h.alertmanagers["test"].sendLoops["test"].queue))
}
func TestHandlerQueuing(t *testing.T) {
var (
expectedc = make(chan []*Alert)
called = make(chan struct{})
done = make(chan struct{})
errc = make(chan error, 1)
)
server := httptest.NewServer(http.HandlerFunc(func(_ http.ResponseWriter, r *http.Request) {
// Notify the test function that we have received something.
select {
case called <- struct{}{}:
case <-done:
return
}
// Wait for the test function to unblock us.
select {
case expected := <-expectedc:
var alerts []*Alert
b, err := io.ReadAll(r.Body)
if err != nil {
panic(err)
}
err = json.Unmarshal(b, &alerts)
if err == nil {
err = alertsEqual(expected, alerts)
}
select {
case errc <- err:
default:
}
case <-done:
}
}))
defer func() {
close(done)
server.Close()
}()
reg := prometheus.NewRegistry()
h := NewManager(
&Options{
QueueCapacity: 3 * DefaultMaxBatchSize,
MaxBatchSize: DefaultMaxBatchSize,
Registerer: reg,
},
model.UTF8Validation,
nil,
)
h.alertmanagers = make(map[string]*alertmanagerSet)
am1Cfg := config.DefaultAlertmanagerConfig
am1Cfg.Timeout = model.Duration(time.Second)
h.alertmanagers["1"] = newTestAlertmanagerSet(&am1Cfg, nil, h.opts, h.metrics, server.URL)
go h.Run(nil)
defer h.Stop()
// Start send loops.
for _, ams := range h.alertmanagers {
ams.startSendLoops(ams.ams)
}
var alerts []*Alert
for i := range make([]struct{}, 20*DefaultMaxBatchSize) {
alerts = append(alerts, &Alert{
Labels: labels.FromStrings("alertname", strconv.Itoa(i)),
})
}
assertAlerts := func(expected []*Alert) {
t.Helper()
for {
select {
case <-called:
expectedc <- expected
case err := <-errc:
require.NoError(t, err)
return
case <-time.After(5 * time.Second):
require.FailNow(t, "Alerts were not pushed.")
}
}
}
// Send one batch, wait for it to arrive and block the server so the queue fills up.
h.Send(alerts[:DefaultMaxBatchSize]...)
<-called
// Send several batches while the server is still blocked so the queue
// fills up to its maximum capacity (3*DefaultMaxBatchSize). Then check that the
// queue is truncated in the front.
h.Send(alerts[1*DefaultMaxBatchSize : 2*DefaultMaxBatchSize]...) // This batch should be dropped.
h.Send(alerts[2*DefaultMaxBatchSize : 3*DefaultMaxBatchSize]...)
h.Send(alerts[3*DefaultMaxBatchSize : 4*DefaultMaxBatchSize]...)
// Send the batch that drops the first one.
h.Send(alerts[4*DefaultMaxBatchSize : 5*DefaultMaxBatchSize]...)
// Unblock the server.
expectedc <- alerts[:DefaultMaxBatchSize]
select {
case err := <-errc:
require.NoError(t, err)
case <-time.After(5 * time.Second):
require.FailNow(t, "Alerts were not pushed.")
}
// Verify that we receive the last 3 batches.
for i := 2; i < 5; i++ {
assertAlerts(alerts[i*DefaultMaxBatchSize : (i+1)*DefaultMaxBatchSize])
}
}
type alertmanagerMock struct {
urlf func() string
}
func (a alertmanagerMock) url() *url.URL {
u, err := url.Parse(a.urlf())
if err != nil {
panic(err)
}
return u
}
func TestReload(t *testing.T) {
tests := []struct {
in *targetgroup.Group
out string
}{
{
in: &targetgroup.Group{
Targets: []model.LabelSet{
{
"__address__": "alertmanager:9093",
},
},
},
out: "http://alertmanager:9093/api/v2/alerts",
},
}
n := NewManager(&Options{}, model.UTF8Validation, nil)
cfg := &config.Config{}
s := `
alerting:
alertmanagers:
- static_configs:
`
err := yaml.UnmarshalStrict([]byte(s), cfg)
require.NoError(t, err, "Unable to load YAML config.")
require.Len(t, cfg.AlertingConfig.AlertmanagerConfigs, 1)
err = n.ApplyConfig(cfg)
require.NoError(t, err, "Error applying the config.")
tgs := make(map[string][]*targetgroup.Group)
for _, tt := range tests {
for k := range cfg.AlertingConfig.AlertmanagerConfigs.ToMap() {
tgs[k] = []*targetgroup.Group{
tt.in,
}
break
}
n.reload(tgs)
res := n.Alertmanagers()[0].String()
require.Equal(t, tt.out, res)
}
}
func TestDroppedAlertmanagers(t *testing.T) {
tests := []struct {
in *targetgroup.Group
out string
}{
{
in: &targetgroup.Group{
Targets: []model.LabelSet{
{
"__address__": "alertmanager:9093",
},
},
},
out: "http://alertmanager:9093/api/v2/alerts",
},
}
n := NewManager(&Options{}, model.UTF8Validation, nil)
cfg := &config.Config{}
s := `
alerting:
alertmanagers:
- static_configs:
relabel_configs:
- source_labels: ['__address__']
regex: 'alertmanager:9093'
action: drop
`
err := yaml.UnmarshalStrict([]byte(s), cfg)
require.NoError(t, err, "Unable to load YAML config.")
require.Len(t, cfg.AlertingConfig.AlertmanagerConfigs, 1)
err = n.ApplyConfig(cfg)
require.NoError(t, err, "Error applying the config.")
tgs := make(map[string][]*targetgroup.Group)
for _, tt := range tests {
for k := range cfg.AlertingConfig.AlertmanagerConfigs.ToMap() {
tgs[k] = []*targetgroup.Group{
tt.in,
}
break
}
n.reload(tgs)
res := n.DroppedAlertmanagers()[0].String()
require.Equal(t, res, tt.out)
}
}
func makeInputTargetGroup() *targetgroup.Group {
return &targetgroup.Group{
Targets: []model.LabelSet{
{
model.AddressLabel: model.LabelValue("1.1.1.1:9090"),
model.LabelName("notcommon1"): model.LabelValue("label"),
},
},
Labels: model.LabelSet{
model.LabelName("common"): model.LabelValue("label"),
},
Source: "testsource",
}
}
// TestHangingNotifier ensures that the notifier takes into account SD changes even when there are
// queued alerts. This test reproduces the issue described in https://github.com/prometheus/prometheus/issues/13676.
// and https://github.com/prometheus/prometheus/issues/8768.
func TestHangingNotifier(t *testing.T) {
synctest.Test(t, func(t *testing.T) {
const (
batches = 100
alertsCount = DefaultMaxBatchSize * batches
faultyURL = "http://faulty:9093/api/v2/alerts"
functionalURL = "http://functional:9093/api/v2/alerts"
)
var (
sendTimeout = 100 * time.Millisecond
sdUpdatert = sendTimeout / 2
)
// Track which alertmanagers have been called.
var faultyCalled, functionalCalled atomic.Bool
// Fake Do function that simulates alertmanager behavior in-process.
// This runs within the synctest bubble, so time.Sleep uses fake time.
fakeDo := func(ctx context.Context, _ *http.Client, req *http.Request) (*http.Response, error) {
url := req.URL.String()
if strings.Contains(url, "faulty") {
faultyCalled.Store(true)
// Faulty alertmanager hangs until context is canceled (by timeout).
<-ctx.Done()
return nil, ctx.Err()
}
// Functional alertmanager responds successfully.
// Sleep simulates network latency that real HTTP would have—without it,
// the queue drains instantly and the final queueLen() assertion fails.
functionalCalled.Store(true)
time.Sleep(sendTimeout / 2)
return &http.Response{
StatusCode: http.StatusOK,
Body: io.NopCloser(bytes.NewBuffer(nil)),
}, nil
}
// Initialize the discovery manager
// This is relevant as the updates aren't sent continually in real life, but only each updatert.
// The old implementation of TestHangingNotifier didn't take that into account.
ctx, cancelSdManager := context.WithCancel(t.Context())
defer cancelSdManager()
reg := prometheus.NewRegistry()
sdMetrics, err := discovery.RegisterSDMetrics(reg, discovery.NewRefreshMetrics(reg))
require.NoError(t, err)
sdManager := discovery.NewManager(
ctx,
promslog.NewNopLogger(),
reg,
sdMetrics,
discovery.Name("sd-manager"),
discovery.Updatert(sdUpdatert),
)
go sdManager.Run()
// Set up the notifier with both faulty and functional Alertmanagers.
notifier := NewManager(
&Options{
QueueCapacity: alertsCount,
Registerer: reg,
Do: fakeDo,
},
model.UTF8Validation,
nil,
)
notifier.alertmanagers = make(map[string]*alertmanagerSet)
amCfg := config.DefaultAlertmanagerConfig
amCfg.Timeout = model.Duration(sendTimeout)
notifier.alertmanagers["config-0"] = newTestAlertmanagerSet(&amCfg, nil, notifier.opts, notifier.metrics, faultyURL, functionalURL)
for _, ams := range notifier.alertmanagers {
ams.startSendLoops(ams.ams)
}
go notifier.Run(sdManager.SyncCh())
t.Cleanup(func() {
notifier.Stop()
// Advance time so in-flight request timeouts fire.
time.Sleep(sendTimeout * 2)
})
require.Len(t, notifier.Alertmanagers(), 2)
// Enqueue the alerts.
var alerts []*Alert
for i := range make([]struct{}, alertsCount) {
alerts = append(alerts, &Alert{
Labels: labels.FromStrings("alertname", strconv.Itoa(i)),
})
}
notifier.Send(alerts...)
// Wait for the Alertmanagers to start receiving alerts.
// Use a polling loop since we need to wait for goroutines to process.
for !faultyCalled.Load() || !functionalCalled.Load() {
time.Sleep(sdUpdatert)
synctest.Wait()
}
// Request to remove the faulty Alertmanager.
c := map[string]discovery.Configs{
"config-0": {
discovery.StaticConfig{
&targetgroup.Group{
Targets: []model.LabelSet{
{
model.AddressLabel: "functional:9093",
},
},
},
},
},
}
require.NoError(t, sdManager.ApplyConfig(c))
// Wait for the discovery update to be processed.
// Advance time to trigger the discovery manager's update interval.
// The faulty alertmanager should be dropped without waiting for its queue to drain.
for len(notifier.Alertmanagers()) != 1 {
time.Sleep(sdUpdatert)
synctest.Wait()
}
// The notifier should not wait until the alerts queue of the functional am is empty to apply the discovery changes.
require.NotZero(t, notifier.alertmanagers["config-0"].sendLoops[functionalURL].queueLen())
})
}
func TestStop_DrainingDisabled(t *testing.T) {
synctest.Test(t, func(t *testing.T) {
const alertmanagerURL = "http://alertmanager:9093/api/v2/alerts"
handlerStarted := make(chan struct{})
alertsReceived := atomic.NewInt64(0)
// Fake Do function that simulates a hanging alertmanager that times out.
fakeDo := func(ctx context.Context, _ *http.Client, req *http.Request) (*http.Response, error) {
var alerts []*Alert
b, err := io.ReadAll(req.Body)
if err != nil {
return nil, fmt.Errorf("read request body: %w", err)
}
if err := json.Unmarshal(b, &alerts); err != nil {
return nil, fmt.Errorf("unmarshal request body: %w", err)
}
alertsReceived.Add(int64(len(alerts)))
// Signal arrival, then block until context times out.
handlerStarted <- struct{}{}
<-ctx.Done()
return nil, ctx.Err()
}
reg := prometheus.NewRegistry()
m := NewManager(
&Options{
QueueCapacity: 10,
DrainOnShutdown: false,
Registerer: reg,
Do: fakeDo,
},
model.UTF8Validation,
nil,
)
m.alertmanagers = make(map[string]*alertmanagerSet)
am1Cfg := config.DefaultAlertmanagerConfig
am1Cfg.Timeout = model.Duration(time.Second)
m.alertmanagers["1"] = newTestAlertmanagerSet(&am1Cfg, nil, m.opts, m.metrics, alertmanagerURL)
for _, ams := range m.alertmanagers {
ams.startSendLoops(ams.ams)
}
// This will be waited on automatically when synctest.Test exits.
go m.Run(nil)
// Queue two alerts. The first should be immediately sent to the receiver, which should block until we release it later.
m.Send(&Alert{Labels: labels.FromStrings(labels.AlertName, "alert-1")})
// Wait for receiver to get the request.
<-handlerStarted
m.Send(&Alert{Labels: labels.FromStrings(labels.AlertName, "alert-2")})
// Stop the notification manager, then advance time to trigger the request timeout.
m.Stop()
time.Sleep(time.Second)
// Allow goroutines to finish.
synctest.Wait()
// Confirm only the first notification was sent. The second notification should be dropped.
require.Equal(t, int64(1), alertsReceived.Load())
})
}
func TestStop_DrainingEnabled(t *testing.T) {
synctest.Test(t, func(t *testing.T) {
const alertmanagerURL = "http://alertmanager:9093/api/v2/alerts"
handlerStarted := make(chan struct{}, 1)
alertsReceived := atomic.NewInt64(0)
// Fake Do function that simulates alertmanager responding slowly but successfully.
fakeDo := func(_ context.Context, _ *http.Client, req *http.Request) (*http.Response, error) {
var alerts []*Alert
b, err := io.ReadAll(req.Body)
if err != nil {
return nil, fmt.Errorf("read request body: %w", err)
}
if err := json.Unmarshal(b, &alerts); err != nil {
return nil, fmt.Errorf("unmarshal request body: %w", err)
}
alertsReceived.Add(int64(len(alerts)))
// Signal arrival.
handlerStarted <- struct{}{}
// Block to allow for alert-2 to be queued while this request is in-flight.
time.Sleep(100 * time.Millisecond)
return &http.Response{
StatusCode: http.StatusOK,
Body: io.NopCloser(bytes.NewBuffer(nil)),
}, nil
}
reg := prometheus.NewRegistry()
m := NewManager(
&Options{
QueueCapacity: 10,
DrainOnShutdown: true,
Registerer: reg,
Do: fakeDo,
},
model.UTF8Validation,
nil,
)
m.alertmanagers = make(map[string]*alertmanagerSet)
am1Cfg := config.DefaultAlertmanagerConfig
am1Cfg.Timeout = model.Duration(time.Second)
m.alertmanagers["1"] = newTestAlertmanagerSet(&am1Cfg, nil, m.opts, m.metrics, alertmanagerURL)
for _, ams := range m.alertmanagers {
ams.startSendLoops(ams.ams)
}
go m.Run(nil)
// Queue two alerts. The first should be immediately sent to the receiver.
m.Send(&Alert{Labels: labels.FromStrings(labels.AlertName, "alert-1")})
// Wait for receiver to get the first request.
<-handlerStarted
// Send second alert while first is still being processed (fakeDo has 100ms delay).
m.Send(&Alert{Labels: labels.FromStrings(labels.AlertName, "alert-2")})
// Stop the notification manager. With DrainOnShutdown=true, this should wait
// for the queue to drain, ensuring both alerts are sent.
m.Stop()
// Advance time so in-flight requests complete.
time.Sleep(time.Second)
// Allow goroutines to finish.
synctest.Wait()
// Confirm both notifications were sent.
require.Equal(t, int64(2), alertsReceived.Load())
})
}
// TestQueuesDrainingOnApplyConfig ensures that when an alertmanagerSet disappears after an ApplyConfig(), its
// sendLoops queues are drained only when DrainOnShutdown is set.
func TestQueuesDrainingOnApplyConfig(t *testing.T) {
for _, drainOnShutDown := range []bool{false, true} {
t.Run(strconv.FormatBool(drainOnShutDown), func(t *testing.T) {
t.Parallel()
alertSent := make(chan struct{})
server := newImmediateAlertManager(alertSent)
defer server.Close()
h := NewManager(&Options{QueueCapacity: 10, DrainOnShutdown: drainOnShutDown}, model.UTF8Validation, nil)
h.alertmanagers = make(map[string]*alertmanagerSet)
amCfg := config.DefaultAlertmanagerConfig
amCfg.Timeout = model.Duration(time.Second)
h.alertmanagers["1"] = newTestAlertmanagerSet(&amCfg, nil, h.opts, h.metrics, server.URL)
// The send loops were not started, nothing will be sent.
h.Send([]*Alert{{Labels: labels.FromStrings("alertname", "foo")}}...)
// Remove the alertmanagerSet.
h.ApplyConfig(&config.Config{})
select {
case <-alertSent:
if !drainOnShutDown {
require.FailNow(t, "no alert should be sent")
}
case <-time.After(100 * time.Millisecond):
if drainOnShutDown {
require.FailNow(t, "alert wasn't received")
}
}
})
}
}
func TestApplyConfig(t *testing.T) {
targetURL := "alertmanager:9093"
targetGroup := &targetgroup.Group{
Targets: []model.LabelSet{
{
"__address__": model.LabelValue(targetURL),
},
},
}
alertmanagerURL := fmt.Sprintf("http://%s/api/v2/alerts", targetURL)
n := NewManager(&Options{}, model.UTF8Validation, nil)
cfg := &config.Config{}
s := `
alerting:
alertmanagers:
- file_sd_configs:
- files:
- foo.json
`
// 1. Ensure known alertmanagers are not dropped during ApplyConfig.
require.NoError(t, yaml.UnmarshalStrict([]byte(s), cfg))
require.Len(t, cfg.AlertingConfig.AlertmanagerConfigs, 1)
// First, apply the config and reload.
require.NoError(t, n.ApplyConfig(cfg))
tgs := map[string][]*targetgroup.Group{"config-0": {targetGroup}}
n.reload(tgs)
require.Len(t, n.Alertmanagers(), 1)
require.Equal(t, alertmanagerURL, n.Alertmanagers()[0].String())
// Reapply the config.
require.NoError(t, n.ApplyConfig(cfg))
// Ensure the known alertmanagers are not dropped.
require.Len(t, n.Alertmanagers(), 1)
require.Equal(t, alertmanagerURL, n.Alertmanagers()[0].String())
// 2. Ensure known alertmanagers are not dropped during ApplyConfig even when
// the config order changes.
s = `
alerting:
alertmanagers:
- static_configs:
- file_sd_configs:
- files:
- foo.json
`
require.NoError(t, yaml.UnmarshalStrict([]byte(s), cfg))
require.Len(t, cfg.AlertingConfig.AlertmanagerConfigs, 2)
require.NoError(t, n.ApplyConfig(cfg))
require.Len(t, n.Alertmanagers(), 1)
// Ensure no unnecessary alertmanagers are injected.
require.Empty(t, n.alertmanagers["config-0"].ams)
// Ensure the config order is taken into account.
ams := n.alertmanagers["config-1"].ams
require.Len(t, ams, 1)
require.Equal(t, alertmanagerURL, ams[0].url().String())
// 3. Ensure known alertmanagers are reused for new config with identical AlertmanagerConfig.
s = `
alerting:
alertmanagers:
- file_sd_configs:
- files:
- foo.json
- file_sd_configs:
- files:
- foo.json
`
require.NoError(t, yaml.UnmarshalStrict([]byte(s), cfg))
require.Len(t, cfg.AlertingConfig.AlertmanagerConfigs, 2)
require.NoError(t, n.ApplyConfig(cfg))
require.Len(t, n.Alertmanagers(), 2)
for cfgIdx := range 2 {
ams := n.alertmanagers[fmt.Sprintf("config-%d", cfgIdx)].ams
require.Len(t, ams, 1)
require.Equal(t, alertmanagerURL, ams[0].url().String())
}
// 4. Ensure known alertmanagers are reused only for identical AlertmanagerConfig.
s = `
alerting:
alertmanagers:
- file_sd_configs:
- files:
- foo.json
path_prefix: /bar
- file_sd_configs:
- files:
- foo.json
relabel_configs:
- source_labels: ['__address__']
regex: 'doesntmatter:1234'
action: drop
`
require.NoError(t, yaml.UnmarshalStrict([]byte(s), cfg))
require.Len(t, cfg.AlertingConfig.AlertmanagerConfigs, 2)
require.NoError(t, n.ApplyConfig(cfg))
require.Empty(t, n.Alertmanagers())
}
// TestAlerstRelabelingIsIsolated ensures that a mutation alerts relabeling in an
// alertmanagerSet doesn't affect others.
// See https://github.com/prometheus/prometheus/pull/17063.
func TestAlerstRelabelingIsIsolated(t *testing.T) {
var (
errc = make(chan error, 1)
expected1 = make([]*Alert, 0)
expected2 = make([]*Alert, 0)
status1, status2 atomic.Int32
)
status1.Store(int32(http.StatusOK))
status2.Store(int32(http.StatusOK))
server1 := newTestHTTPServerBuilder(&expected1, errc, "", "", &status1)
server2 := newTestHTTPServerBuilder(&expected2, errc, "", "", &status2)
defer server1.Close()
defer server2.Close()
h := NewManager(&Options{QueueCapacity: 10}, model.UTF8Validation, nil)
h.alertmanagers = make(map[string]*alertmanagerSet)
am1Cfg := config.DefaultAlertmanagerConfig
am1Cfg.Timeout = model.Duration(time.Second)
am1Cfg.AlertRelabelConfigs = []*relabel.Config{
{
SourceLabels: model.LabelNames{"alertname"},
Regex: relabel.MustNewRegexp("(.*)"),
TargetLabel: "parasite",
Action: relabel.Replace,
Replacement: "yes",
NameValidationScheme: model.UTF8Validation,
},
}
am2Cfg := config.DefaultAlertmanagerConfig
am2Cfg.Timeout = model.Duration(time.Second)
h.alertmanagers = map[string]*alertmanagerSet{
"am1": newTestAlertmanagerSet(&am1Cfg, nil, h.opts, h.metrics, server1.URL),
"am2": newTestAlertmanagerSet(&am2Cfg, nil, h.opts, h.metrics, server2.URL),
}
// Start send loops.
for _, ams := range h.alertmanagers {
ams.startSendLoops(ams.ams)
}
defer func() {
for _, ams := range h.alertmanagers {
ams.cleanSendLoops(ams.ams...)
}
}()
testAlert := &Alert{
Labels: labels.FromStrings("alertname", "test"),
}
expected1 = append(expected1, &Alert{
Labels: labels.FromStrings("alertname", "test", "parasite", "yes"),
})
// Am2 shouldn't get the parasite label.
expected2 = append(expected2, &Alert{
Labels: labels.FromStrings("alertname", "test"),
})
checkNoErr := func() {
t.Helper()
select {
case err := <-errc:
require.NoError(t, err)
default:
}
}
h.Send(testAlert)
checkNoErr()
}
// Regression test for https://github.com/prometheus/prometheus/issues/7676
// The test creates a black hole alertmanager that never responds to any requests.
// The alertmanager_config.timeout is set to infinite (1 year).
// We check that the notifier does not hang and throughput is not affected.
func TestNotifierQueueIndependentOfFailedAlertmanager(t *testing.T) {
stopBlackHole := make(chan struct{})
blackHoleAM := newBlackHoleAlertmanager(stopBlackHole)
defer func() {
close(stopBlackHole)
blackHoleAM.Close()
}()
doneAlertReceive := make(chan struct{})
immediateAM := newImmediateAlertManager(doneAlertReceive)
defer immediateAM.Close()
do := func(ctx context.Context, client *http.Client, req *http.Request) (*http.Response, error) {
return client.Do(req.WithContext(ctx))
}
reg := prometheus.NewRegistry()
h := NewManager(&Options{
Do: do,
QueueCapacity: 10,
MaxBatchSize: DefaultMaxBatchSize,
Registerer: reg,
}, model.UTF8Validation, nil)
h.alertmanagers = make(map[string]*alertmanagerSet)
amCfg := config.DefaultAlertmanagerConfig
amCfg.Timeout = model.Duration(time.Hour * 24 * 365)
h.alertmanagers["1"] = newTestAlertmanagerSet(&amCfg, http.DefaultClient, h.opts, h.metrics, blackHoleAM.URL)
h.alertmanagers["2"] = newTestAlertmanagerSet(&amCfg, http.DefaultClient, h.opts, h.metrics, immediateAM.URL)
doneSendAll := make(chan struct{})
for _, ams := range h.alertmanagers {
ams.startSendLoops(ams.ams)
}
defer func() {
for _, ams := range h.alertmanagers {
ams.cleanSendLoops(ams.ams...)
}
}()
go func() {
h.Send(&Alert{
Labels: labels.FromStrings("alertname", "test"),
})
close(doneSendAll)
}()
select {
case <-doneAlertReceive:
// This is the happy case, the alert was received by the immediate alertmanager.
case <-time.After(2 * time.Second):
t.Fatal("Timeout waiting for alert to be received by immediate alertmanager")
}
select {
case <-doneSendAll:
// This is the happy case, the sendAll function returned.
case <-time.After(2 * time.Second):
t.Fatal("Timeout waiting for sendAll to return")
}
}
// TestApplyConfigSendLoopsNotStoppedOnKeyChange reproduces a bug where sendLoops
// are incorrectly stopped when the alertmanager config key changes but the config
// content (and thus its hash) remains the same.
//
// The bug scenario:
// 1. Old config has alertmanager set with key "config-0" and config hash X
// 2. New config has TWO alertmanager sets where the SECOND one ("config-1") has hash X
// 3. sendLoops are transferred from old "config-0" to new "config-1" (hash match)
// 4. Cleanup checks if key "config-0" exists in new config — it does (different config)
// 5. No cleanup happens for old "config-0", sendLoops work correctly
//
// However, there's a variant where the key disappears completely:
// 1. Old config: "config-0" with hash X, "config-1" with hash Y
// 2. New config: "config-0" with hash Y (was "config-1"), no "config-1"
// 3. sendLoops from old "config-0" (hash X) have nowhere to go
// 4. Cleanup sees "config-1" doesn't exist, tries to clean up old "config-1"
//
// This test verifies that when config keys change, sendLoops are correctly preserved.
func TestApplyConfigSendLoopsNotStoppedOnKeyChange(t *testing.T) {
alertReceived := make(chan struct{}, 10)
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
w.WriteHeader(http.StatusOK)
select {
case alertReceived <- struct{}{}:
default:
}
}))
defer server.Close()
targetURL := server.Listener.Addr().String()
targetGroup := &targetgroup.Group{
Targets: []model.LabelSet{
{
"__address__": model.LabelValue(targetURL),
},
},
}
n := NewManager(&Options{QueueCapacity: 10}, model.UTF8Validation, nil)
cfg := &config.Config{}
// Initial config with TWO alertmanager configs.
// "config-0" uses file_sd_configs with foo.json (hash X)
// "config-1" uses file_sd_configs with bar.json (hash Y)
s := `
alerting:
alertmanagers:
- file_sd_configs:
- files:
- foo.json
- file_sd_configs:
- files:
- bar.json
`
require.NoError(t, yaml.UnmarshalStrict([]byte(s), cfg))
require.NoError(t, n.ApplyConfig(cfg))
// Reload with target groups to discover alertmanagers.
tgs := map[string][]*targetgroup.Group{
"config-0": {targetGroup},
"config-1": {targetGroup},
}
n.reload(tgs)
require.Len(t, n.Alertmanagers(), 2)
// Verify sendLoops exist for both configs.
require.Len(t, n.alertmanagers["config-0"].sendLoops, 1)
require.Len(t, n.alertmanagers["config-1"].sendLoops, 1)
// Start the send loops.
for _, ams := range n.alertmanagers {
ams.startSendLoops(ams.ams)
}
defer func() {
for _, ams := range n.alertmanagers {
ams.mtx.Lock()
ams.cleanSendLoops(ams.ams...)
ams.mtx.Unlock()
}
}()
// Send an alert and verify it's received (twice, once per alertmanager set).
n.Send(&Alert{Labels: labels.FromStrings("alertname", "test1")})
for range 2 {
select {
case <-alertReceived:
// Good, alert was sent.
case <-time.After(2 * time.Second):
require.FailNow(t, "timeout waiting for first alert")
}
}
// Apply a new config that REVERSES the order of alertmanager configs.
// Now "config-0" has hash Y (was bar.json) and "config-1" has hash X (was foo.json).
// The sendLoops should be transferred based on hash matching.
s = `
alerting:
alertmanagers:
- file_sd_configs:
- files:
- bar.json
- file_sd_configs:
- files:
- foo.json
`
require.NoError(t, yaml.UnmarshalStrict([]byte(s), cfg))
require.NoError(t, n.ApplyConfig(cfg))
// CRITICAL CHECK: After ApplyConfig but BEFORE reload, the sendLoops should
// have been transferred based on hash matching and NOT stopped.
// - Old "config-0" (foo.json, hash X) -> New "config-1" (foo.json, hash X)
// - Old "config-1" (bar.json, hash Y) -> New "config-0" (bar.json, hash Y)
// Both old keys exist in new config, so no cleanup should happen.
require.Len(t, n.alertmanagers["config-0"].sendLoops, 1, "sendLoops should be transferred to config-0")
require.Len(t, n.alertmanagers["config-1"].sendLoops, 1, "sendLoops should be transferred to config-1")
// Reload with target groups for the new config.
tgs = map[string][]*targetgroup.Group{
"config-0": {targetGroup},
"config-1": {targetGroup},
}
n.reload(tgs)
// The alertmanagers should still be discoverable.
require.Len(t, n.Alertmanagers(), 2)
// The critical test: send another alert and verify it's received by both.
n.Send(&Alert{Labels: labels.FromStrings("alertname", "test2")})
for range 2 {
select {
case <-alertReceived:
// Good, alert was sent - sendLoops are still working.
case <-time.After(2 * time.Second):
require.FailNow(t, "timeout waiting for second alert - sendLoops may have been incorrectly stopped")
}
}
}
// TestApplyConfigDuplicateHashSharesSendLoops tests a bug where multiple new
// alertmanager configs with identical content (same hash) all receive the same
// sendLoops map reference, causing shared mutable state between alertmanagerSets.
//
// Bug scenario:
// 1. Old config: "config-0" with hash X
// 2. New config: "config-0" AND "config-1" both with hash X (identical configs)
// 3. Both new sets get `sendLoops = oldAmSet.sendLoops` (same map reference!)
// 4. Now config-0 and config-1 share the same sendLoops map
// 5. When config-1's alertmanager is removed via sync(), it cleans up the shared
// sendLoops, breaking config-0's ability to send alerts
func TestApplyConfigDuplicateHashSharesSendLoops(t *testing.T) {
n := NewManager(&Options{QueueCapacity: 10}, model.UTF8Validation, nil)
cfg := &config.Config{}
// Initial config with ONE alertmanager.
s := `
alerting:
alertmanagers:
- file_sd_configs:
- files:
- foo.json
`
require.NoError(t, yaml.UnmarshalStrict([]byte(s), cfg))
require.NoError(t, n.ApplyConfig(cfg))
targetGroup := &targetgroup.Group{
Targets: []model.LabelSet{
{"__address__": "alertmanager:9093"},
},
}
tgs := map[string][]*targetgroup.Group{"config-0": {targetGroup}}
n.reload(tgs)
require.Len(t, n.alertmanagers["config-0"].sendLoops, 1)
// Apply a new config with TWO IDENTICAL alertmanager configs.
// Both have the same hash, so both will receive sendLoops from the same old set.
s = `
alerting:
alertmanagers:
- file_sd_configs:
- files:
- foo.json
- file_sd_configs:
- files:
- foo.json
`
require.NoError(t, yaml.UnmarshalStrict([]byte(s), cfg))
require.NoError(t, n.ApplyConfig(cfg))
// Reload with target groups for both configs - same alertmanager URL for both.
tgs = map[string][]*targetgroup.Group{
"config-0": {targetGroup},
"config-1": {targetGroup},
}
n.reload(tgs)
// Both alertmanagerSets should have independent sendLoops.
sendLoops0 := n.alertmanagers["config-0"].sendLoops
sendLoops1 := n.alertmanagers["config-1"].sendLoops
require.Len(t, sendLoops0, 1, "config-0 should have sendLoops")
require.Len(t, sendLoops1, 1, "config-1 should have sendLoops")
// Verify that the two alertmanagerSets have INDEPENDENT sendLoops maps.
// They should NOT share the same sendLoop objects.
for k := range sendLoops0 {
if loop1, ok := sendLoops1[k]; ok {
require.NotSame(t, sendLoops0[k], loop1,
"config-0 and config-1 should have independent sendLoop instances, not shared references")
}
}
}
// TestApplyConfigHashChangeLeaksSendLoops tests a bug where sendLoops goroutines
// are leaked when the config key remains the same but the config hash changes.
//
// Bug scenario:
// 1. Old config has "config-0" with hash H1 and running sendLoops
// 2. New config has "config-0" with hash H2 (modified config)
// 3. Since hash differs, sendLoops are NOT transferred to the new alertmanagerSet
// 4. Cleanup only checks if key exists in amSets - it does, so no cleanup
// 5. Old sendLoops goroutines continue running and are never stopped
func TestApplyConfigHashChangeLeaksSendLoops(t *testing.T) {
n := NewManager(&Options{QueueCapacity: 10}, model.UTF8Validation, nil)
cfg := &config.Config{}
// Initial config with one alertmanager.
s := `
alerting:
alertmanagers:
- file_sd_configs:
- files:
- foo.json
`
require.NoError(t, yaml.UnmarshalStrict([]byte(s), cfg))
require.NoError(t, n.ApplyConfig(cfg))
targetGroup := &targetgroup.Group{
Targets: []model.LabelSet{
{"__address__": "alertmanager:9093"},
},
}
tgs := map[string][]*targetgroup.Group{"config-0": {targetGroup}}
n.reload(tgs)
// Capture the old sendLoop.
oldSendLoops := n.alertmanagers["config-0"].sendLoops
require.Len(t, oldSendLoops, 1)
var oldSendLoop *sendLoop
for _, sl := range oldSendLoops {
oldSendLoop = sl
}
// Apply a new config with DIFFERENT hash (added path_prefix).
s = `
alerting:
alertmanagers:
- file_sd_configs:
- files:
- foo.json
path_prefix: /changed
`
require.NoError(t, yaml.UnmarshalStrict([]byte(s), cfg))
require.NoError(t, n.ApplyConfig(cfg))
// The old sendLoop should have been stopped since hash changed.
// Check that the stopped channel is closed.
select {
case <-oldSendLoop.stopped:
// Good - sendLoop was properly stopped
default:
t.Fatal("BUG: old sendLoop was not stopped when config hash changed - goroutine leak")
}
}
func newBlackHoleAlertmanager(stop <-chan struct{}) *httptest.Server {
return httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
// Do nothing, wait to be canceled.
<-stop
w.WriteHeader(http.StatusOK)
}))
}
func newImmediateAlertManager(done chan<- struct{}) *httptest.Server {
return httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
w.WriteHeader(http.StatusOK)
close(done)
}))
}