upstream/prometheus
1
0
Fork 0
mirror of https://github.com/prometheus/prometheus.git synced 2026-02-03 20:39:32 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 13
prometheus/rules
History
Bartlomiej Plotka c4eefd1b3a storage: Removed SelectSorted method; Simplified interface; Added requirement for remote read to sort response. 
This is technically BREAKING CHANGE, but it was like this from the beginning: I just notice that we rely in
Prometheus on remote read being sorted. This is because we use selected data from remote reads in MergeSeriesSet
which rely on sorting.

I found during work on https://github.com/prometheus/prometheus/pull/5882 that
we do so many repetitions because of this, for not good reason. I think
I found a good balance between convenience and readability with just one method.
Smaller the interface = better.

Also I don't know what TestSelectSorted was testing, but now it's testing sorting.

Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
2020-03-20 21:14:43 +01:00
..
fixtures rules: Make deleted rule series as stale after a reload (#6745) 2020-02-12 16:22:18 +01:00
alerting.go Fix build errors in rest of prometheus 2020-02-17 16:09:23 +01:00
alerting_test.go Comment fixes 2020-02-17 16:09:23 +01:00
manager.go storage: Removed SelectSorted method; Simplified interface; Added requirement for remote read to sort response. 2020-03-20 21:14:43 +01:00
manager_test.go storage: Removed SelectSorted method; Simplified interface; Added requirement for remote read to sort response. 2020-03-20 21:14:43 +01:00
recording.go Fix build errors in rest of prometheus 2020-02-17 16:09:23 +01:00
recording_test.go Comment fixes 2020-02-17 16:09:23 +01:00