mirror of
https://github.com/hashicorp/terraform.git
synced 2026-04-23 23:27:00 -04:00
* Add `DiagnosticComparer` to standardize how diagnostics are compared for equality. This uses code originally in the s3 backend. Co-authored-by: Graham Davison <gdavison@hashicorp.com> * Refactor `test` related code to use new comparer * Refactor `s3` related code to use new comparer * Replace use of reflect and go-spew with new diagnostics comparison approach * Fix whitespace * Make `tfdiags.DiagnosticComparer` a var * Fix DiagnosticComparer test --------- Co-authored-by: Graham Davison <gdavison@hashicorp.com>
123 lines
2.5 KiB
Go
123 lines
2.5 KiB
Go
// Copyright (c) HashiCorp, Inc.
|
|
// SPDX-License-Identifier: BUSL-1.1
|
|
|
|
package arguments
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/google/go-cmp/cmp"
|
|
"github.com/hashicorp/terraform/internal/tfdiags"
|
|
)
|
|
|
|
func TestParseValidate_valid(t *testing.T) {
|
|
testCases := map[string]struct {
|
|
args []string
|
|
want *Validate
|
|
}{
|
|
"defaults": {
|
|
nil,
|
|
&Validate{
|
|
Path: ".",
|
|
TestDirectory: "tests",
|
|
ViewType: ViewHuman,
|
|
},
|
|
},
|
|
"json": {
|
|
[]string{"-json"},
|
|
&Validate{
|
|
Path: ".",
|
|
TestDirectory: "tests",
|
|
ViewType: ViewJSON,
|
|
},
|
|
},
|
|
"path": {
|
|
[]string{"-json", "foo"},
|
|
&Validate{
|
|
Path: "foo",
|
|
TestDirectory: "tests",
|
|
ViewType: ViewJSON,
|
|
},
|
|
},
|
|
"test-directory": {
|
|
[]string{"-test-directory", "other"},
|
|
&Validate{
|
|
Path: ".",
|
|
TestDirectory: "other",
|
|
ViewType: ViewHuman,
|
|
},
|
|
},
|
|
"no-tests": {
|
|
[]string{"-no-tests"},
|
|
&Validate{
|
|
Path: ".",
|
|
TestDirectory: "tests",
|
|
ViewType: ViewHuman,
|
|
NoTests: true,
|
|
},
|
|
},
|
|
}
|
|
|
|
for name, tc := range testCases {
|
|
t.Run(name, func(t *testing.T) {
|
|
got, diags := ParseValidate(tc.args)
|
|
if len(diags) > 0 {
|
|
t.Fatalf("unexpected diags: %v", diags)
|
|
}
|
|
if *got != *tc.want {
|
|
t.Fatalf("unexpected result\n got: %#v\nwant: %#v", got, tc.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestParseValidate_invalid(t *testing.T) {
|
|
testCases := map[string]struct {
|
|
args []string
|
|
want *Validate
|
|
wantDiags tfdiags.Diagnostics
|
|
}{
|
|
"unknown flag": {
|
|
[]string{"-boop"},
|
|
&Validate{
|
|
Path: ".",
|
|
TestDirectory: "tests",
|
|
ViewType: ViewHuman,
|
|
},
|
|
tfdiags.Diagnostics{
|
|
tfdiags.Sourceless(
|
|
tfdiags.Error,
|
|
"Failed to parse command-line flags",
|
|
"flag provided but not defined: -boop",
|
|
),
|
|
},
|
|
},
|
|
"too many arguments": {
|
|
[]string{"-json", "bar", "baz"},
|
|
&Validate{
|
|
Path: "bar",
|
|
TestDirectory: "tests",
|
|
ViewType: ViewJSON,
|
|
},
|
|
tfdiags.Diagnostics{
|
|
tfdiags.Sourceless(
|
|
tfdiags.Error,
|
|
"Too many command line arguments",
|
|
"Expected at most one positional argument.",
|
|
),
|
|
},
|
|
},
|
|
}
|
|
|
|
for name, tc := range testCases {
|
|
t.Run(name, func(t *testing.T) {
|
|
got, gotDiags := ParseValidate(tc.args)
|
|
if *got != *tc.want {
|
|
t.Fatalf("unexpected result\n got: %#v\nwant: %#v", got, tc.want)
|
|
}
|
|
if diff := cmp.Diff(gotDiags, tc.wantDiags, tfdiags.DiagnosticComparer); diff != "" {
|
|
t.Fatalf("unexpected diff in diags:\n%s", diff)
|
|
}
|
|
})
|
|
}
|
|
}
|