mirror of
https://github.com/hashicorp/vault.git
synced 2026-02-03 20:40:45 -05:00
Have go-test timeout before the GH step timeout to gather information (#28559)
- If we encounter a deadlock/long running test it is better to have go test timeout. As we've noticed if we hit the GitHub step timeout, we lose all information about what was running at the time of the timeout making things harder to diagnose. - Having the timeout through go test itself on a long running test it outputs what test was running along with a full panic output within the logs which is quite useful to diagnose
This commit is contained in:
parent
7efc1af5d0
commit
159e780d74
1 changed files with 6 additions and 1 deletions
7
.github/workflows/test-go.yml
vendored
7
.github/workflows/test-go.yml
vendored
|
|
@ -49,6 +49,11 @@ on:
|
|||
required: false
|
||||
default: 20
|
||||
type: number
|
||||
go-test-timeout:
|
||||
description: The timeout parameter for Go tests
|
||||
required: false
|
||||
default: 50m
|
||||
type: string
|
||||
timeout-minutes:
|
||||
description: The maximum number of minutes that this workflow should run
|
||||
required: false
|
||||
|
|
@ -443,7 +448,7 @@ jobs:
|
|||
-- \
|
||||
$package_parallelism \
|
||||
-tags "${{ inputs.go-tags }}" \
|
||||
-timeout=${{ env.TIMEOUT_IN_MINUTES }}m \
|
||||
-timeout=${{ inputs.go-test-timeout }} \
|
||||
-parallel=${{ inputs.go-test-parallelism }} \
|
||||
${{ inputs.extra-flags }} \
|
||||
- name: Prepare datadog-ci
|
||||
|
|
|
|||
Loading…
Reference in a new issue