upstream/vault
1
0
Fork 0
mirror of https://github.com/hashicorp/vault.git synced 2026-02-03 20:40:45 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

VAULT-28281: Pass in accountName variable into validation function (#27563)

Browse source 
* pass in correct accountName variable into validation function

* modify test fixture to better test validation functionality

* pass in accountName variable into error message

* changelog
This commit is contained in:
davidadeleon 2024-06-21 15:09:07 -04:00 committed by GitHub
parent 7187b6f2c3
commit 45682dc090
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
changelog/27563.txt Normal file
View file

@ -0,0 +1,3 @@
```release-note:bug
storage/azure: Fix invalid account name initialization bug
```

4
physical/azure/azure.go
View file

@ -68,8 +68,8 @@ func NewAzureBackend(conf map[string]string, logger log.Logger) (physical.Backen
return nil, fmt.Errorf("'accountName' must be set")
}
}
if err := validateAccountName(name); err != nil {
return nil, fmt.Errorf("invalid account name %s: %w", name, err)
if err := validateAccountName(accountName); err != nil {
return nil, fmt.Errorf("invalid account name %s: %w", accountName, err)
}
accountKey := os.Getenv("AZURE_ACCOUNT_KEY")

2
physical/azure/azure_test.go
View file

@ -35,7 +35,7 @@ func testFixture(t *testing.T) (*AzureBackend, func()) {
t.Helper()
ts := time.Now().UnixNano()
name := fmt.Sprintf("vlt%d", ts)
name := fmt.Sprintf("vlt-%d", ts)
_ = os.Setenv("AZURE_BLOB_CONTAINER", name)
cleanup := func() {}