Commit graph

37648 commits

Author SHA1 Message Date
Matthijs Mekking
cf8bf1e084 Add log rotation test with absolute file path
Add a test to the logfileconfig system test to test log file rotation
when using absolute file paths.

(cherry picked from commit d9b1df3b5d)
2023-05-03 10:13:02 +02:00
Matthijs Mekking
eb37fd2f13 Add more log/tap rotation tests
Add more tests to the dnstap system test to roll with different values.
Touch some files to make sure the number of existing files exceed the
number that we want to keep.

Add a test to the logfileconfig system test for the increment suffix.

(cherry picked from commit 9fb9670ebc)
2023-05-03 10:12:56 +02:00
Matthijs Mekking
33ad117166 Fix purging old log files with absolute file path
Removing old timestamp or increment versions of log backup files did
not work when the file is an absolute path: only the entry name was
provided to the file remove function.

The dirname was also bogus, since the file separater was put back too
soon.

Fix these issues to make log file rotation work when the file is
configured to be an absolute path.

(cherry picked from commit 70629d73da)
2023-05-03 10:12:51 +02:00
Mark Andrews
021337f3e2 Merge branch '4027-nsec3-of-removed-empty-non-terminal-remains-in-chain-breaking-validation-tools-bind-9.18' into 'bind-9.18'
[9.18] Resolve "NSEC3 of removed empty-non-terminal remains in chain, breaking validation tools"

See merge request isc-projects/bind9!7867
2023-04-25 06:10:31 +00:00
Mark Andrews
a69862e1a6 Add CHANGES note for [GL #4027]
(cherry picked from commit 7dbb2b877b)
2023-04-25 06:46:08 +01:00
Mark Andrews
a3c3012c25 Check removal of ENT when subdomains are removed
Empty-non-terminal NSEC records where not always removed when the
delegations generating them where removed via update. Check that
they now are.

(cherry picked from commit ad91a70d15)
2023-04-25 06:46:08 +01:00
Mark Andrews
0eee434741 Cleanup orphaned empty-non-terminal NSEC3
When OPTOUT was in use we didn't ensure that NSEC3 records
for orphaned empty-non-terminals where removed.  Check if
there are orphaned empty-non-terminal NSEC3 even if there
wasn't an NSEC3 RRset to be removed in dns_nsec3_delnsec3.

(cherry picked from commit 27160c137f)
2023-04-25 06:46:08 +01:00
Ondřej Surý
57171a7047 Merge branch 'jpmens-main-patch-10650-9.18' into 'bind-9.18'
[9.18] Fix typo in the ARM - missed -> missing

See merge request isc-projects/bind9!7866
2023-04-24 15:14:41 +00:00
JP Mens
6862b5724e
Fix typo in the ARM - missed -> missing
(cherry picked from commit 7bfffa1bd8)
2023-04-24 17:12:23 +02:00
Ondřej Surý
83ec46676f Merge branch '4004-reimplemented-max-transfer--in-9.18' into 'bind-9.18'
[9.18] Implement maximum global and idle time for incoming XFR

See merge request isc-projects/bind9!7862
2023-04-21 15:49:28 +00:00
Ondřej Surý
c71efbf45f
Add CHANGES note for [GL #4004]
(cherry picked from commit 713e202110)
2023-04-21 17:21:32 +02:00
Aram Sargsyan
bc0461d4ae
Implement new checks for the xfer system test
Check the max-transfer-time-in and max-transfer-idle-in options.

(cherry picked from commit 5324f047b2)
2023-04-21 17:21:32 +02:00
Aram Sargsyan
305bf677ab
Implement new -T options for xfer system tests
'-T transferinsecs' makes named interpret the max-transfer-time-out,
max-transfer-idle-out, max-transfer-time-in and max-transfer-idle-in
configuration options as seconds instead of minutes.

'-T transferslowly' makes named to sleep for one second for every
xfrout message.

'-T transferstuck' makes named to sleep for one minute for every
xfrout message.

(cherry picked from commit dfaecfd752)
2023-04-21 17:21:32 +02:00
Ondřej Surý
fa2cb06c75
Implement maximum global and idle time for incoming XFR
After the dns_xfrin was changed to use network manager, the maximum
global (max-transfer-time-in) and idle (max-transfer-idle-in) times for
incoming transfers were turned inoperational because of missing
implementation.

Restore this functionality by implementing the timers for the incoming
transfers.

(cherry picked from commit d2377f8e04)
2023-04-21 17:21:32 +02:00
Ondřej Surý
cf6a8987b3 Merge branch '4005-handle-ISC_R_INVALIDPROTO-from-libuv-9.18' into 'bind-9.18'
[9.18] Handle ISC_R_INVALIDPROTO in the dispatch

See merge request isc-projects/bind9!7861
2023-04-21 11:30:30 +00:00
Ondřej Surý
89b1f25c44
Add CHANGES and release note for [GL #4005]
(cherry picked from commit c233cd621b)
2023-04-21 12:49:06 +02:00
Evan Hunt
960e4dadd2
check for invalid protocol when dispatch fails
treat ISC_R_INVALIDPROTO as a networking error when it occurs.

(cherry picked from commit 2269a3e6fb)
2023-04-21 12:47:07 +02:00
Evan Hunt
2a714c25f8
add a result code for ENOPROTOOPT, EPROTONOSUPPORT
there was no isc_result_t value for invalid protocol errors
that could be returned from libuv.

(cherry picked from commit 0393b54afb)
2023-04-21 12:47:07 +02:00
Michał Kępień
cdff6bb8ba BIND 9.18.14
-----BEGIN PGP SIGNATURE-----
 
 iQIzBAABCgAdFiEEEVO2++xeDVoSYmDzq9WHzfBlga4FAmQ1kaQACgkQq9WHzfBl
 ga4hXRAAirVMBI/BaeuxT58phKfcTEZXWMOvNGQaSfVWmNtwNzVvSCWemxOeuto0
 NX9f8HbK3wGe/72tL18OELdeZhtkeUjhFCGF0eTbcW9AypyZCQit+3h8EJGWYjvd
 rFo8JN7Eh1Zk5Arsb9lU993jAy7o9M0iSSluHH2+k8wAoipWhQYvdjsU94qyfvy2
 hdWIUpMV55p+DrVmyk7sZniajJtjHPxf1NFT+DeYQFzgKdFJK1Luwk/g9KSrjk36
 roOWKbDtELqjeIXA1x6krDaurYXyAE/2gJAe4ozBR3ty5CEUrELG6RyY9c+NA3lg
 rJESFCRRXef24CAQHIgSkLubyRJHv4zJd33nnhM4ZBsjTWhDqzUl6tyoy2U0xaZd
 qruAfo24e7it725SCWNk38DSFbDL70lT46ClF7iNgo5HmaCHMuZLM94h3vNwoiAM
 H039IJ60rQhBGRu/+UW4VnheoNSM3ZXMWQKn7zh93kiQNPmGGyNa0e3ZVrX148HE
 LY0K6363L9vrF67qyJ86C53NY3Njv2jMH4J3UVwMF3V040AmwXODaitFB/P49keK
 ckZe8DyChK8KdwuOe4NdhT/5BOMsOX1tCZt02Mrb4yn/aq3POUQuVGVGqunkQOcI
 K7djhXVedQshezRem5gYPhCMth2QLUNt56B46x/3LSCK8URY4/8=
 =Dd5k
 -----END PGP SIGNATURE-----
gpgsig -----BEGIN SSH SIGNATURE-----
 U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAg25GGAuUyFX1gxo7QocNm8V6J/8
 frHSduYX7Aqk4iJLwAAAADZ2l0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5
 AAAAQLjSdQAEA9BtnuRMc+PyXOf1nJ3a7PzJdCxHmt17rklHis408vm9RQx1miTBAh160G
 Ci+PsFDy1x8aOPLkobbwU=
 -----END SSH SIGNATURE-----

Merge tag 'v9.18.14' into bind-9.18

BIND 9.18.14
2023-04-20 12:52:22 +02:00
Arаm Sаrgsyаn
6772a05371 Merge branch 'aram/xfer-test-bugfix-9.18' into 'bind-9.18'
[9.18] Fix variable name error in the xfer system test

See merge request isc-projects/bind9!7850
2023-04-18 10:20:39 +00:00
Aram Sargsyan
50493282a6 Fix variable name error in the xfer system test
There is no 'ret' in this test, and it is obvious that 'ret=1'
should be 'tmp=1' for the check to work correctly, if the string
is not found in the log file.

(cherry picked from commit 613a9fc659)
2023-04-18 09:39:30 +00:00
Matthijs Mekking
d98ec86299 Merge branch '3769-migrate-zsk-ksk-split-tocsk-v9_18' into 'bind-9.18'
[9.18] kasp: Add test case for migrating KSK/ZSK to CSK

See merge request isc-projects/bind9!7844
2023-04-17 13:34:00 +00:00
Matthijs Mekking
bf5eea515d Add key state init debugging
When debugging an issue it can be useful to see what BIND initially
set the key states to.

(cherry picked from commit e752656a38)
2023-04-17 12:14:06 +02:00
Matthijs Mekking
e2167eb1d1 kasp: Add test case for migrating KSK/ZSK to CSK
Add a test case to cover #3679 where a user migrates from a KSK/ZSK
split using auto-dnssec maintain, to the default dnssec-policy (CSK).

The test actually does not use the default dnssec-policy, but it does
use one that has the same keys clause. For testing convenience, we use
the same propagation time values as other test cases that migrate to
dnssec-policy with mismatching existing key set.

(cherry picked from commit c42ec8a56e)
2023-04-17 12:14:00 +02:00
Arаm Sаrgsyаn
deb5a89962 Merge branch '4000-openssl-attr-malloc-vs-cmocka-define-malloc-9.18' into 'bind-9.18'
[9.18] unit tests: include an OpenSSL header before including cmocka.h

See merge request isc-projects/bind9!7842
2023-04-14 13:33:08 +00:00
Aram Sargsyan
2b85e3603e Add a CHANGES note for [GL #4000]
(cherry picked from commit 786b0689c6)
2023-04-14 12:41:27 +00:00
Aram Sargsyan
f25f58438c unit tests: include an OpenSSL header before including cmocka.h
OpenSSL 3.1.0 uses __attribute__(malloc), conflicting with a redefined
malloc in cmocka.h.

As a workaround, include an OpenSSL header file before including
cmocka.h in the unit tests where OpenSSL is used.

(cherry picked from commit 87db9ea84c)
2023-04-14 12:40:14 +00:00
Petr Špaček
c67b7bcc09 Merge branch 'pspacek/set-up-version-and-release-notes-for-bind-9.18.15' into 'bind-9.18'
Set up version and release notes for BIND 9.18.15

See merge request isc-projects/bind9!7838
2023-04-14 08:48:52 +00:00
Petr Špaček
fc30d2523e
Set up release notes for BIND 9.18.15 2023-04-14 10:45:38 +02:00
Petr Špaček
ae77ab4ca5
Update BIND version to 9.18.15-dev 2023-04-14 10:45:38 +02:00
Ondřej Surý
19bf6c846f Merge branch '3980-revert-unit-test-forking-9.18' into 'bind-9.18'
Revert "Kill unit tests that run more than 1200 seconds"

See merge request isc-projects/bind9!7834
2023-04-14 04:22:20 +00:00
Ondřej Surý
f7bdab0591
Revert "Kill unit tests that run more than 1200 seconds"
This reverts commit 6cdeb5b046 which added
wrapper around all the unit tests that would run the unit test in the
forked process.

This makes any debugging of the unit tests too hard. Futures attempts to
fix #3980 (closed) should add a custom automake test harness (log
driver) that would kill the unit test after configured timeout.
2023-04-14 06:21:03 +02:00
Petr Špaček
2c5e22fcbc
Update BIND version for release 2023-04-11 18:55:27 +02:00
Petr Špaček
e42b15c6d1
Add a CHANGES marker 2023-04-11 18:54:57 +02:00
Petr Špaček
f3eac1795e Merge branch 'pspacek/prepare-documentation-for-bind-9.18.14' into 'v9.18.14-release'
Prepare documentation for BIND 9.18.14

See merge request isc-private/bind9!512
2023-04-11 16:53:31 +00:00
Petr Špaček
e413c85edf
Add release notes for GL #3955, #3968, and #3997 2023-04-11 18:46:14 +02:00
Petr Špaček
28fb44e62b
Tweak and reword release note 2023-04-11 18:46:14 +02:00
Petr Špaček
59c5d95290
Prepare release notes for BIND 9.18.14 2023-04-11 17:25:37 +02:00
Michal Nowak
a901bf893f Merge branch '3916-legacy-test-no-retries-in-resolution_fails-9.18' into 'bind-9.18'
[9.18] Do not retry in resolution_fails() on timeout

See merge request isc-projects/bind9!7816
2023-04-06 10:14:21 +00:00
Michal Nowak
fab91f89e6
Do not retry in resolution_fails() on timeout
At the time of test number (19), there were 10 "sending packet to
10.53.0.7" lines in the "legacy/ns1/named.run" file; usually, only seven
are present:

    I:legacy:checking recursive lookup to edns 512 + no tcp server does not cause query loops (19)
    I:legacy:ns1 sent 10 queries to ns7, expected less than 10
    I:legacy:failed

Those three can be attributed to tests "8", "10", and "18", where the
dig of "resolution_fails()" retried after a timeout to succeed with
"status: SERVFAIL" subsequently, as seen in each of
dig.out.test{8,10,18} files.

    ;; communications error to 10.53.0.1#13093: timed out

    ; <<>> DiG 9.19.12-dev <<>> -p 13093 +tcp @10.53.0.1 edns512-notcp. TXT
    ; (1 server found)
    ;; global options: +cmd
    ;; Got answer:
    ;; ->>HEADER<<- opcode: QUERY, status: SERVFAIL, id: 5368
    ;; flags: qr rd ra; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 1

This retry is unnecessary because "resolution_fails()" considers timeout
a positive result.

(cherry picked from commit e05460c813)
2023-04-06 11:39:57 +02:00
Michal Nowak
17b31a95dc Merge branch 'mnowak/looking-for-dig-errors-must-not-fail-9.18' into 'bind-9.18'
[9.18] Looking for errors in dig output files must not fail

See merge request isc-projects/bind9!7815
2023-04-06 09:33:51 +00:00
Michal Nowak
5eb0a4e537
Looking for errors in dig output files must not fail
If no errors in dig output files of failed tests are found, TSAN file
parsing won't occur.

(cherry picked from commit 28a0df3081)
2023-04-06 11:04:14 +02:00
Petr Špaček
7956df54d7 Merge branch 'pspacek/log-roll-doc-nits-9.18' into 'bind-9.18'
[9.18] Log rotation doc improvements

See merge request isc-projects/bind9!7807
2023-04-05 14:08:25 +00:00
Petr Špaček
9659d40148
Remove erroneous cross-references to suffix statement
Logging section referenced to "suffix" statement definition for dns64.

(cherry picked from commit 1dada31187)
2023-04-05 16:03:24 +02:00
Petr Špaček
8f86b48c46
Make rndc dnstap -roll docs easier to read
(cherry picked from commit 2897a45644)
2023-04-05 16:03:24 +02:00
Petr Špaček
d9a745e310 Merge branch 'bug/main/rndc-dnstap-roll-9.18' into 'bind-9.18'
[9.18] Document that rndc dnstap -roll number is optional

See merge request isc-projects/bind9!7801
2023-04-05 12:06:06 +00:00
Petr Menšík
c16cabff04
Make it obvious -roll number is optional
Manual page were updated to indicate it, but rndc -h still displays it
as required parameter. Make it look like optional.

(cherry picked from commit 0627214568)
2023-04-05 14:05:14 +02:00
Petr Špaček
996f635991 Merge branch '3990-remove-dead-code-from-dst_api--9.18' into 'bind-9.18'
[9.18] Eliminate the dead code in dst_api.c

See merge request isc-projects/bind9!7775
2023-04-05 11:45:12 +00:00
Ondřej Surý
07720989a0
Eliminate the dead code in dst_api.c
In write_public_key() and write_key_state(), there were left-over checks
for result, that were effectively dead code after the last refactoring.
Remove those.

(cherry picked from commit 766366e934)
2023-04-05 09:11:24 +02:00
Mark Andrews
052422b1a8 Merge branch '3994-unnecessary-null-check-bind-9.18' into 'bind-9.18'
[9.18] Resolve "Unnecessary NULL check"

See merge request isc-projects/bind9!7798
2023-04-05 00:51:59 +00:00