Commit graph

7501 commits

Author SHA1 Message Date
Brad Warren
ca42e99222 add certbot wrapper to Dockerfile-old 2017-03-06 19:31:42 -08:00
Brad Warren
eb1e3c4cb3 add docker-warning script 2017-03-06 19:31:42 -08:00
Brad Warren
fb9b62a282 add Dockerfile-old 2017-03-06 19:31:38 -08:00
Brad Warren
3d5c0842cb Merge branch 'master' into dockerfile++ 2017-03-06 19:31:13 -08:00
Brad Warren
f94c4eeff1 only copy necessary files in Dockerfile 2017-03-06 19:31:09 -08:00
Brad Warren
6f8bf74c53 sort directives that never change in Dockerfile 2017-03-06 19:31:05 -08:00
Brad Warren
b23a259390 Don't install unnecessary packages in Dockerfile 2017-03-06 19:30:49 -08:00
Shiloh Heurich
2862ade0b1 docs(ciphers): newer keylength.com recommendations (#4266) 2017-03-03 10:44:12 -08:00
Jacob Hoffman-Andrews
ea578870da ipdb can now be run without pip installing. (#4257) 2017-03-03 10:37:31 -08:00
Alex Bowers
80326511bb Improve error reporting for hooks (#4235)
* Improve error reporting for hooks

* My bad

* Whitespace.
2017-03-03 10:28:05 -08:00
yonjah
1507b6b731 Added documentation about renew exit status #Fixes #4090 (#4234)
* Added documentation about renew exit status #Fixes #4090

* recommend using post-hook instead of renew-hook
2017-03-03 08:34:30 -08:00
Blake Griffith
12a6e49cf1 Remove use of sha1 (#4271)
These are not security critical uses of sha1 but they should still be removed.
2017-03-02 21:16:19 -08:00
yomna
93908a33bc [#3451] small changes to the standalone documentation (#4247) 2017-03-02 17:28:45 -08:00
Jacob Hoffman-Andrews
53117b0ce0 Remove UnexpectedUpdate exceptions. (#4197)
* Remove UnexpectedUpdate exceptions.

These exceptions trigger when the server sends the client back an object with a
field that doesn't exactly match what the client previously sent.

This causes unnecessary breakage in various cases, doesn't prevent any problems,
and isn't required by spec.

* Back out all UnexpectedUpdate removals except registration update.
2017-03-02 17:27:29 -08:00
Sagi Kedmi
26a7023b8d Change QSA to NE in HTTPS redirection (#4204)
* Change QSA to NE in HTTPS redirection

* Seamless transition to new HTTPS redirection RewriteRule
2017-03-02 16:49:34 -08:00
Erica Portnoy
d66b25bf5c update changelog (#4287) 2017-03-02 15:46:16 -08:00
Erica Portnoy
5e671682ca Candidate 0.12.0 (#4286)
* Release 0.12.0

* Bump version to 0.13.0
2017-03-02 15:26:24 -08:00
Noah Swartz
b040717e4d Changelog (#4252)
* made a changelog

* fix date for 0.6.0

* fix brad nits

* fix typo
2017-03-02 10:31:55 -08:00
Brad Warren
5e6a6f51d3 Fix test_leauto_upgrades.sh (#4278)
* fix-test-leauto-upgrades

* redirect stderr

* redirect stderr part 2
2017-03-02 10:31:37 -08:00
Brad Warren
11ec1eb911 Revert "Remove Link rel=next for authzs and new-certs." (#4277) 2017-03-02 10:31:15 -08:00
Noah Swartz
33f43512db Merge pull request #4230 from certbot/jsha-patch-1
Remove reference to #certbot on OFTC
2017-02-28 18:33:41 -08:00
Brad Warren
0d8a4b4ebd Make mod-check more flexible (#4268)
* fixes #4166

* Run mod-check from anywhere

* pass TRAVIS_BRANCH through in tox
2017-02-28 15:17:07 -08:00
Damien Tournoud
44a6ec29c5 Fix direct usages of the root logger (#4236)
Some code uses `logging.debug` and `logging.info` instead of
the file-specific logger in `logger.debug` and `logger.info`.
2017-02-27 18:13:06 -08:00
Brad Warren
402ad8b353 bump requests requirement to >=2.10 (#4248) 2017-02-27 17:17:08 -08:00
Brad Warren
80055ec770 Cleanup issue template (#4256) 2017-02-27 15:15:19 -08:00
Erica Portnoy
e5909d379c Don't crash on listen unix: (#4259)
Fixes #4225.

* don't crash on listen unix:

* correctly merge #4221
2017-02-27 13:35:29 -08:00
Yen Chi Hsuan
7d02e129f9 Fix certbot-apache tests on Python 3 (#4172) 2017-02-24 18:21:21 -08:00
Noah Swartz
d066f8b38b created an issue template (#4201)
* created an issue template

* bmw changes
2017-02-24 13:08:25 -08:00
Joona Hoikkala
e02d641490 Docker changes for easier testing (#4249)
These changes allow developers to run tests directly from the host machine using Docker, and to enable ipdb inside the container.

docker-compose.yml is upgraded to version 2 format. This means that you need docker-engine version >= 1.10.0 instead of previous requirement of version >= 1.9.1. The reason for this is to be able to use custom Dockerfile (Dockerfile-dev in this case) in build context.

ipdb has been added to dev dependencies to be able to be able to debug the code without installing it on every docker run. This is also what we recommend for debugging in the developer documentation, so there really is no reason not to install it with the dev dependencies.

setuptools is being upgraded to a newer version to be able to run coverage tests. This was using the older version of setuptools for some reason, and without the upgrade, coverage tests would fail horribly. Upgrading remedies the situation.

Few examples: 

Run unit tests for certbot-apache
`docker-compose run --rm --service-ports development bash -c 'cd src;nosetests -v certbot-apache'`

Run coverage tests
`docker-compose run --rm --service-ports development bash -c 'cd src;./tox.cover.sh'`

Run linter
`docker-compose run --rm --service-ports development bash -c 'cd src;tox -e lint'`
2017-02-24 11:40:03 -08:00
Joona Hoikkala
28cbd6e7d3 Fix for case sensitivity when looking for vhosts (#4193) 2017-02-23 20:28:36 -08:00
Erica Portnoy
52ce335ff0 lineage_for_certname should return None if there is no existing renewal file (#4243)
* lineage_for_certname should return None if there is no existing renewal file

* add unit test

* add regression test to integration test

* revent boulder-start to boulder-fetch
2017-02-23 18:31:23 -08:00
silverwind
b1a4280519 Show error details for the nginx config parser (#4221)
Nginx parser errors now include helpful details on where parsing has
actually failed.

Related: https://github.com/certbot/certbot/issues/3798
2017-02-22 18:50:56 -08:00
Jacob Hoffman-Andrews
a92ca8e97c Add default timeout to ClientNetwork. (#4217)
In https://community.letsencrypt.org/t/letsencrypt-cli-hangs-on-certificate-request/27211,
a community member pointed out that Certbot seems to hang when there are
routing problems.
2017-02-22 18:48:01 -08:00
Erica Portnoy
5bab6b512f Refactor main (#4127)
* Refactor main to simplify logic

* Update tests and comments

* Correct main test

* increase timeout limit

* reset timeout limit

* call renew_cert in appropriate main test

* Update docstrings and revert signatures of _report_new_cert and _suggest_donation_of_appropriate

* replace renew_cert logic

* update tests

* rename _csr_obtain_cert and add a check to _report_new_cert
2017-02-22 13:08:56 -08:00
Jacob Hoffman-Andrews
ebf5170d12 Update testing docs. (#4211)
Recommend faster-running commands with clearer output first, building up to
slow, noisy, `tox` last.

Remove outdated Boulder testing advice, and outdated Boulder testing scripts
(Vagrantfile, mac-bootstrap.sh, boulder-start.sh). Update Boulder testing
section.

Fill out "directory structure" section of contributing guide a little better.
2017-02-16 12:39:17 -08:00
Jacob Hoffman-Andrews
6a8113fa87 Remove reference to #certbot on OFTC
The #letsencrypt channel on Freenode is much more active, and is the defacto place for questions about Certbot. Users posting questions on #certbot on OFTC are not getting prompt answers.
2017-02-16 10:24:48 -08:00
Jacob Hoffman-Andrews
94aa562cf2 Use latest Boulder for Travis tests. (#4180) 2017-02-14 21:19:18 -08:00
Jacob Hoffman-Andrews
1380e59f56 Remove Link rel=next for authzs and new-certs. (#4194)
An early version of the spec indicated that clients should process issuance
sequentially, following Link rel=next from an account URL to an authz URL, to a
new-cert URL. However, the spec has long since moved to putting these URLs in
the directory.

Certbot nominally supports either; This change consolidates on always using the
directory, simplifying things and making the transition to the latest ACME spec
easier.
2017-02-13 19:50:33 -08:00
Jacob Hoffman-Andrews
d9a467f401 Remove erroneous advice (#4212)
Per @patf at https://community.letsencrypt.org/t/-/21318/2:

> [The message about account recovery] is not really true anymore - account recovery via email was planned to be added at some point, but has been removed from the spec since.
2017-02-13 09:54:33 -08:00
Chad Whitacre
b0ee98a5c3 Satisfy linter 2017-02-13 09:04:15 -05:00
Chad Whitacre
90bbd93b05 Fix test 2017-02-13 08:49:35 -05:00
Erica Portnoy
3b9db79fd3 Merge pull request #4092 from certbot/managing-docs
Add information about cert management to the docs
2017-02-10 17:41:13 -08:00
Chad Whitacre
14ce872b6b Remove erroneous advice
Per @pfg at https://community.letsencrypt.org/t/-/21318/2:

> This is not really true anymore - account recovery via email was planned to be added at some point, but has been removed from the spec since.
2017-02-10 17:44:11 -05:00
Erica Portnoy
b316a13f22 oxford comma 2017-02-09 14:40:02 -08:00
Erica Portnoy
08a546fa8d remove trailing whitespace 2017-02-09 14:38:38 -08:00
Erica Portnoy
8b5c87f983 revert factual errors 2017-02-09 13:13:33 -08:00
Erica Portnoy
92816275a6 plaintextify 2017-02-09 12:59:06 -08:00
Peter Eckersley
299512aa2b Merge pull request #4162 from certbot/candidate-0.11.1-2
Release Certbot 0.11.1
2017-02-07 15:09:09 -08:00
Brad Warren
245170ebe5 Bump version to 0.12.0
(cherry picked from commit f4eabe0908456b7ab2aef0ae03b5dc1db73d5805)
2017-02-01 20:56:31 -08:00
Brad Warren
99818bc6b7 Release 0.11.1
(cherry picked from commit 426a804561)
2017-02-01 20:56:23 -08:00