Eng Zer Jun
2ceebffc77
test: replace ensure.TempDir with t.TempDir
...
This commit replaces `ensure.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `ensure.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2023-07-29 16:11:22 +08:00
Matt Farina
343389856b
Merge pull request #12162 from mattfarina/fix-merge-values-ugh
...
Fix multiple bugs in values handling
2023-07-26 09:30:09 -04:00
Matt Farina
e8a748d300
Updated per feedback from gjenkins8
...
Signed-off-by: Matt Farina <matt.farina@suse.com>
2023-07-25 09:52:46 -04:00
Joe Julian
ca61c326c2
Merge pull request #11758 from joejulian/remove_blank_list_item_from_files_lines
...
strip trailing newline from Files.Lines
2023-07-24 19:16:28 -07:00
Matt Farina
39231e26d7
Merge pull request #12222 from helm/dependabot/go_modules/github.com/sirupsen/logrus-1.9.3
...
chore(deps): bump github.com/sirupsen/logrus from 1.9.0 to 1.9.3
2023-07-24 12:09:19 -04:00
dependabot[bot]
48cf02b57f
chore(deps): bump github.com/sirupsen/logrus from 1.9.0 to 1.9.3
...
Bumps [github.com/sirupsen/logrus](https://github.com/sirupsen/logrus ) from 1.9.0 to 1.9.3.
- [Release notes](https://github.com/sirupsen/logrus/releases )
- [Changelog](https://github.com/sirupsen/logrus/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sirupsen/logrus/compare/v1.9.0...v1.9.3 )
---
updated-dependencies:
- dependency-name: github.com/sirupsen/logrus
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-07-21 15:47:39 +00:00
Matt Farina
f099c2e883
Merge pull request #12224 from helm/dependabot/go_modules/github.com/stretchr/testify-1.8.4
...
chore(deps): bump github.com/stretchr/testify from 1.8.2 to 1.8.4
2023-07-21 11:46:13 -04:00
Joe Julian
a50206fed2
Merge pull request #12243 from mattfarina/tweak-dry-run
...
Tweaking new dry-run internal handling
2023-07-20 11:40:09 -07:00
Matt Farina
96e33e2773
Tweaking new dry-run internal handling
...
There are a few changes to the new dry-run handling:
1. Some documentation is added to help clarify what is happening
and what is expected.
2. DryRun is never changed by internal handling. If an API user
sets the property it is not changed by our code.
3. The behavior on contacting the server with false/none is made
consistent between install and upgrade.
Signed-off-by: Matt Farina <matt.farina@suse.com>
2023-07-20 14:26:46 -04:00
Matt Farina
838b12191e
Merge pull request #9426 from tapaskapadia/feat/lookup-dryrun
...
feat(helm): add ability for --dry-run to do lookup functions
2023-07-20 13:30:52 -04:00
Matt Farina
f2a0ceb9a6
Merge pull request #12240 from helm/dependabot/github_actions/github/codeql-action-2.21.0
...
chore(deps): bump github/codeql-action from 2.20.3 to 2.21.0
2023-07-20 12:04:30 -04:00
dependabot[bot]
2e22395667
chore(deps): bump github/codeql-action from 2.20.3 to 2.21.0
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 2.20.3 to 2.21.0.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](46ed16ded9...1813ca74c3
2023-07-19 21:38:33 +00:00
dependabot[bot]
7d0deb35d9
chore(deps): bump github.com/stretchr/testify from 1.8.2 to 1.8.4
...
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify ) from 1.8.2 to 1.8.4.
- [Release notes](https://github.com/stretchr/testify/releases )
- [Commits](https://github.com/stretchr/testify/compare/v1.8.2...v1.8.4 )
---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-07-14 21:48:03 +00:00
Joe Julian
32c7e37e32
Merge pull request #12215 from joejulian/bump_k8s_modules
...
bump kubernetes modules to v0.27.3
2023-07-14 09:51:52 -07:00
Joe Julian
9c4f73332d
bump kubernetes modules to v0.27.3
...
Signed-off-by: Joe Julian <me@joejulian.name>
2023-07-13 10:48:08 -07:00
dependabot[bot]
f9e5db39c9
chore(deps): bump actions/checkout from 3.2.0 to 3.5.3
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3.2.0 to 3.5.3.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](755da8c3cf...c85c95e3d7
2023-07-13 17:28:00 +00:00
Joe Julian
4a9fc851ff
Merge pull request #12198 from helm/dependabot/go_modules/github.com/spf13/cobra-1.7.0
...
chore(deps): bump github.com/spf13/cobra from 1.6.1 to 1.7.0
2023-07-13 10:22:14 -07:00
Joe Julian
a3e5b33963
Merge pull request #12209 from helm/dependabot/github_actions/actions/setup-go-4.0.1
...
chore(deps): bump actions/setup-go from 3.5.0 to 4.0.1
2023-07-13 10:18:25 -07:00
Joe Julian
d6a5ee7d9b
Merge pull request #12208 from helm/dependabot/github_actions/github/codeql-action-2.20.3
...
chore(deps): bump github/codeql-action from 2.1.37 to 2.20.3
2023-07-13 10:15:48 -07:00
dependabot[bot]
6e2bddde6a
chore(deps): bump actions/setup-go from 3.5.0 to 4.0.1
...
Bumps [actions/setup-go](https://github.com/actions/setup-go ) from 3.5.0 to 4.0.1.
- [Release notes](https://github.com/actions/setup-go/releases )
- [Commits](6edd4406fa...fac708d667
2023-07-13 16:38:00 +00:00
dependabot[bot]
31e9e54265
chore(deps): bump github/codeql-action from 2.1.37 to 2.20.3
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 2.1.37 to 2.20.3.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](959cbb7472...46ed16ded9
2023-07-13 16:37:57 +00:00
Joe Julian
a2d6ca748e
Merge pull request #11498 from ashishkurmi/main
...
Update dependabot config to include github actions
2023-07-13 09:37:19 -07:00
Joe Julian
99e1dce8c8
Merge pull request #9950 from jeffrosenberg/error-on-failed-jobs-9285
...
Throw an error from jobReady() if the job exceeds its BackoffLimit
2023-07-13 08:21:58 -07:00
Joe Julian
8554d518d5
Merge pull request #10397 from mtesseract/mc/fix-err-message-on-existing-resource-conflict
...
Adjust error message wrongly claiming that there is a resource conflict
2023-07-13 08:20:16 -07:00
Joe Julian
14d363669f
Merge pull request #11529 from wujunwei/fix-update-dependency-panic
...
bugfix: SIGSEGV with OCI chart reference using helm template
2023-07-12 18:00:41 -07:00
dependabot[bot]
87cbd34280
chore(deps): bump github.com/spf13/cobra from 1.6.1 to 1.7.0
...
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra ) from 1.6.1 to 1.7.0.
- [Release notes](https://github.com/spf13/cobra/releases )
- [Commits](https://github.com/spf13/cobra/compare/v1.6.1...v1.7.0 )
---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-07-13 00:23:26 +00:00
Joe Julian
b15cbd3683
Merge pull request #12185 from helm/dependabot/go_modules/golang.org/x/crypto-0.11.0
...
chore(deps): bump golang.org/x/crypto from 0.5.0 to 0.11.0
2023-07-12 17:22:32 -07:00
Joe Julian
ec1d0d8671
Merge pull request #11456 from greed42/tpl-tests
...
Backfill tests for the `tpl` function
2023-07-12 17:21:07 -07:00
Joe Julian
e4a3350e2b
Merge pull request #12194 from helm/dependabot/go_modules/github.com/docker/docker-23.0.3incompatible
...
chore(deps): bump github.com/docker/docker from 23.0.1+incompatible to 23.0.3+incompatible
2023-07-12 17:20:30 -07:00
dependabot[bot]
91a3f73b0e
chore(deps): bump golang.org/x/crypto from 0.5.0 to 0.11.0
...
Bumps [golang.org/x/crypto](https://github.com/golang/crypto ) from 0.5.0 to 0.11.0.
- [Commits](https://github.com/golang/crypto/compare/v0.5.0...v0.11.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/crypto
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-07-13 00:12:31 +00:00
Joe Julian
b9422736fd
Merge pull request #12200 from helm/dependabot/go_modules/golang.org/x/text-0.11.0
...
chore(deps): bump golang.org/x/text from 0.9.0 to 0.11.0
2023-07-12 17:10:44 -07:00
Joe Julian
1f1a5b2eb8
Merge pull request #12037 from helm/dependabot/go_modules/k8s.io/klog/v2-2.100.1
...
chore(deps): bump k8s.io/klog/v2 from 2.90.1 to 2.100.1
2023-07-12 17:09:13 -07:00
dependabot[bot]
0ff4b746ea
chore(deps): bump golang.org/x/text from 0.9.0 to 0.11.0
...
Bumps [golang.org/x/text](https://github.com/golang/text ) from 0.9.0 to 0.11.0.
- [Release notes](https://github.com/golang/text/releases )
- [Commits](https://github.com/golang/text/compare/v0.9.0...v0.11.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/text
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-07-12 21:14:53 +00:00
dependabot[bot]
b1fe927dc5
chore(deps): bump k8s.io/klog/v2 from 2.90.1 to 2.100.1
...
Bumps [k8s.io/klog/v2](https://github.com/kubernetes/klog ) from 2.90.1 to 2.100.1.
- [Release notes](https://github.com/kubernetes/klog/releases )
- [Changelog](https://github.com/kubernetes/klog/blob/main/RELEASE.md )
- [Commits](https://github.com/kubernetes/klog/compare/v2.90.1...v2.100.1 )
---
updated-dependencies:
- dependency-name: k8s.io/klog/v2
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-07-12 00:03:02 +00:00
Joe Julian
794f3b781c
Merge pull request #12165 from helm/dependabot/go_modules/github.com/rubenv/sql-migrate-1.5.1
...
chore(deps): bump github.com/rubenv/sql-migrate from 1.3.1 to 1.5.1
2023-07-11 17:02:25 -07:00
dependabot[bot]
b262738f9c
chore(deps): bump github.com/docker/docker
...
Bumps [github.com/docker/docker](https://github.com/docker/docker ) from 23.0.1+incompatible to 23.0.3+incompatible.
- [Release notes](https://github.com/docker/docker/releases )
- [Commits](https://github.com/docker/docker/compare/v23.0.1...v23.0.3 )
---
updated-dependencies:
- dependency-name: github.com/docker/docker
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-07-11 23:59:40 +00:00
Joe Julian
7ccb4ede6c
Merge pull request #12149 from helm/dependabot/go_modules/oras.land/oras-go-1.2.3
...
chore(deps): bump oras.land/oras-go from 1.2.2 to 1.2.3
2023-07-11 16:58:32 -07:00
Joe Julian
f31d4fb3aa
Merge pull request #12186 from gjenkins8/gjenkins8_triage
...
Add gjenkins8 as triage maintainer
2023-07-06 09:38:41 -07:00
Andrew Block
49fe297bee
Merge pull request #12177 from sabre1041/oci-annotation-created
...
Add created OCI annotation
2023-07-05 18:02:45 -04:00
George Jenkins
5840269120
Add gjenkins8 as triage maintainer
...
Signed-off-by: George Jenkins <gjenkins8@bloomberg.net>
2023-07-05 14:37:40 -07:00
Andrew Block
d72b42da61
Added tests for created OCI annotation time format
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
2023-07-04 04:51:46 -05:00
Andrew Block
c4870d990c
Add created OCI annotation
...
Signed-off-by: Andrew Block <andy.block@gmail.com>
2023-07-02 07:21:15 -05:00
Matt Farina
03911aeab7
Merge pull request #12036 from mattfarina/bump-version-3.12
2023-06-27 22:27:56 -04:00
Matt Farina
55b58c08df
Merge pull request #12166 from yardenshoham/typo
...
chore: fix a typo in `manager.go`
2023-06-26 11:51:09 -04:00
Matt Farina
0a5148faff
Fix multiple bugs in values handling
...
First, some notes about priority and how some code flow works.
For Helm handling values, the expected order of precidence is:
1. User specified values (e.g CLI)
2. Imported values
3. Parent chart values
4. Subchart values
Helm handles dependency values slightly differently. If there are dependencies
in the charts folder that are not marked as dependencies all of the values,
including nil values, are pulled in. If those charts are listed as a
dependency in the Chart.yaml file than they are processed for import handling.
Prior to the changes here, it caused nil values at the top level to NOT remove
values specified.
The changes:
1. The order of priority was chagned from the list above. Parnet chart values
would override specifically imported values. This is due to a change from
just over a year ago that introduced a bug. That was undone by changing the
precidence when maps were merged.
2. To handle merging while retaining the nil values, which was causing
inconsistent behavior, a new set of Merge functions were introduced. These
functions are just like coalesce except that they DO NOT remove nil/null values.
The new functions are used in a backward compatible manner meaning some new
functions were introduced that called them.
Specific issues fixed (that are known):
Closes #9027
Can now delete subkeys from charts when specified in the parent. This behavior
was previously inconsistent. Sometimes they could be deleted and other times
it did not work. Now it is consistent.
Closes #10899
Imported values (from library or other subcharts) are now used following the
order above.
The previous behavior was inconsistent. import-values using just a string
would import them. When named with a child/parent it did not work if the
parent already had a value. If string and named were mixed the imports
worked if the string happened first but just for the string not the named.
If the named parent/child went first then none of them worked for cases
where the parent already had a value. It was inconsistent and the tests
sometimes mirrored the functionality rather than expected behavior.
Tests for this fall into the sub-packages and are in the template tests
to verify it's happening in the output. Including having values passed
at the CLI as the ultimate highest priority to be used.
This relates to a fix that went in for #9940 . The expected values there don't
fit the precedence above where the parent value would override the imported
value. That fix/change introduced more bugs.
Closes #10052
This is the case where imported values using the parent/child designation
just didn't work right. That has been fixed and there are tests. The underlying
issue had to do with the precedence order handling.
Note, a lot of tests were added. Hope we got it more right this time.
Signed-off-by: Matt Farina <matt.farina@suse.com>
2023-06-26 11:37:21 -04:00
Yarden Shoham
15e6066a45
chore: fix a typo in manager.go
...
actally -> actually
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
2023-06-25 20:07:02 +00:00
dependabot[bot]
d0febd50be
chore(deps): bump github.com/rubenv/sql-migrate from 1.3.1 to 1.5.1
...
Bumps [github.com/rubenv/sql-migrate](https://github.com/rubenv/sql-migrate ) from 1.3.1 to 1.5.1.
- [Commits](https://github.com/rubenv/sql-migrate/compare/v1.3.1...v1.5.1 )
---
updated-dependencies:
- dependency-name: github.com/rubenv/sql-migrate
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-06-23 21:57:14 +00:00
wujunwei
c87f846d88
add GetRegistryClient method
...
Signed-off-by: wujunwei <wjw3323@live.com>
2023-06-15 11:49:23 +08:00
dependabot[bot]
d8caa67a0f
chore(deps): bump oras.land/oras-go from 1.2.2 to 1.2.3
...
Bumps [oras.land/oras-go](https://github.com/oras-project/oras-go ) from 1.2.2 to 1.2.3.
- [Release notes](https://github.com/oras-project/oras-go/releases )
- [Commits](https://github.com/oras-project/oras-go/compare/v1.2.2...v1.2.3 )
---
updated-dependencies:
- dependency-name: oras.land/oras-go
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-06-14 21:57:42 +00:00
Matt Farina
4e447d87cd
Merge pull request #11397 from wujunwei/fix-helm-lint-infinite-loop
...
bugfix: helm lint infinite loop
2023-06-14 10:38:13 -04:00
