Merge pull request #136575 from enj/enj/i/agg_dis_npe

Prevent nil pointer exception in aggregated discovery
This commit is contained in:
Kubernetes Prow Robot 2026-01-29 02:13:52 +05:30 committed by GitHub
commit 0d4d8a0cb2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -559,9 +559,13 @@ func writeDiscoveryResponse(
return
}
var targetGV schema.GroupVersion
if mediaType.Convert == nil ||
(mediaType.Convert.GroupVersion() != apidiscoveryv2.SchemeGroupVersion &&
mediaType.Convert.GroupVersion() != apidiscoveryv2beta1.SchemeGroupVersion) {
if mediaType.Convert == nil {
utilruntime.HandleError(fmt.Errorf("expected aggregated discovery group version, got unknown group and version"))
w.WriteHeader(http.StatusInternalServerError)
return
}
if mediaType.Convert.GroupVersion() != apidiscoveryv2.SchemeGroupVersion &&
mediaType.Convert.GroupVersion() != apidiscoveryv2beta1.SchemeGroupVersion {
utilruntime.HandleError(fmt.Errorf("expected aggregated discovery group version, got group: %s, version %s", mediaType.Convert.Group, mediaType.Convert.Version))
w.WriteHeader(http.StatusInternalServerError)
return