Add missing auditRec.Success calls; fix missing return on error. (#34954)

Co-authored-by: Mattermost Build <build@mattermost.com>

server/channels/api4/remote_cluster.go

@@ -125,6 +125,8 @@ func remoteClusterAcceptMessage(c *Context, w http.ResponseWriter, r *http.Reque
 		return
 	}
 
+	auditRec.Success()
+
 	if _, err := w.Write(b); err != nil {
 		c.Logger.Warn("Error while writing response", mlog.Err(err))
 	}
@@ -575,8 +577,11 @@ func generateRemoteClusterInvite(c *Context, w http.ResponseWriter, r *http.Requ
 	inviteCode, invErr := c.App.CreateRemoteClusterInvite(rc.RemoteId, url, rc.Token, password)
 	if invErr != nil {
 		c.Err = invErr
+		return
 	}
 
+	auditRec.Success()
+
 	w.WriteHeader(http.StatusCreated)
 	if err := json.NewEncoder(w).Encode(inviteCode); err != nil {
 		c.Logger.Warn("Error while writing response", mlog.Err(err))

server/channels/api4/shared_channel.go

@@ -235,6 +235,7 @@ func uninviteRemoteClusterToChannel(c *Context, w http.ResponseWriter, r *http.R
 
 	// if the channel is not shared with the remote, we return early
 	if !hasRemote {
+		auditRec.Success()
 		w.WriteHeader(http.StatusNoContent)
 		return
 	}