Commit graph

2640 commits

Author SHA1 Message Date
Evgeni Golov
1988e49fce check_mailq: add $mailq to check output, so it is easily visible what was autodetected
Closes: #1242
2014-02-27 20:44:58 +01:00
Evgeni Golov
f14ae4b99a check_mailq: document autodetection in the usage output 2014-02-27 20:33:35 +01:00
Evgeni Golov
be9aa5aba2 check_mailq: try to autodetect which mailq implementation we are using
This is done by looking at some common directories and files each
MTA installs on the system. If no known file is found, the old default
sendmail is used. Of course this still can be overridden by -M.
2014-02-27 20:33:14 +01:00
Holger Weiss
19c493e54c configure.ac: Support --disable-maintainer-mode
This

| allows you to choose whether the so called "rebuild rules" should be
| enabled or disabled.  With AM_MAINTAINER_MODE([enable]), they are
| enabled by default, otherwise they are disabled by default.  In the
| latter case, if you have AM_MAINTAINER_MODE in configure.ac, and run
| `./configure && make', then make will *never* attempt to rebuild
| configure, Makefile.ins, Lex or Yacc outputs, etc.  I.e., this
| disables build rules for files that are usually distributed and that
| users should normally not have to update.
|
| The user can override the default setting by passing either
| `--enable-maintainer-mode' or `--disable-maintainer-mode' to
| configure.
|
| People use AM_MAINTAINER_MODE either because they do not want their
| users (or themselves) annoyed by timestamps lossage (see CVS), or
| because they simply can't stand the rebuild rules and prefer running
| maintainer tools explicitly.

[ https://www.gnu.org/software/automake/manual/automake.html ]
2014-02-21 16:19:22 +01:00
Holger Weiss
acca8c0a71 Rename configure.in to configure.ac
The old name has been deprecated years ago.  The Autoconf documentation
says:

| Previous versions of Autoconf promoted the name configure.in, which is
| somewhat ambiguous (the tool needed to process this file is not
| described by its extension), and introduces a slight confusion with
| config.h.in and so on (for which `.in' means "to be processed by
| configure").  Using configure.ac is now preferred.

[ https://www.gnu.org/software/autoconf/manual/autoconf.html ]
2014-02-21 16:12:12 +01:00
Davide Madrisan
ac438ccfe5 check_swap: Fix the plugin name that appears in the comment
Signed-off-by: Davide Madrisan <davide.madrisan@gmail.com>
2014-02-20 15:52:56 +01:00
Holger Weiss
f8be073e9a travis-ci: Don't use Clang
Currently, there doesn't seem to be a way to configure Travis CI to omit
the Clang build on the coverity/* branches.

See: https://github.com/travis-ci/travis-ci/issues/1975
2014-02-20 12:49:29 +01:00
Holger Weiss
ca3f8c3f43 travis-ci: Adjust "branch_pattern"
Modify the "branch_pattern" for the Coverity add-on so that it also
matches "coverity/master" and "coverity/maint".
2014-02-20 12:30:36 +01:00
Sven Nierlein
385340a4ef check_procs test fails if there is no user with uid 501
thats because check_procs verifys there is a user for a
given uid filter. So even we use sample data for this
test, we still need a real user.

Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-02-18 16:20:11 +01:00
Jan Wagner
4f5e20187f check_ssh: Reverting a387120
This seems to result into more problems in the wild then before 'fixing' it

Closes Debian #739254
Reopen Debian #734811
2014-02-17 12:18:17 +01:00
Jan Wagner
ef46dabffa travis-ci: remove heading dash accordingly docs 2014-02-16 21:25:55 +01:00
Holger Weiss
2698b4768d travis-ci: Cosmetic changes
Use two spaces for indentation.
2014-02-16 20:13:15 +01:00
Holger Weiss
79efa279f6 travis-ci: Enable email notifications
Have Travis CI send build failure and recovery notifications to the
team@ list.
2014-02-16 20:12:35 +01:00
Jan Wagner
182430de46 travis-ci: Add configuration for Coverity Scan
Run Coverity Scan builds on Travis CI, but only when pushing into the
"coverity" branch.
2014-02-16 20:00:55 +01:00
Jan Wagner
b120c75713 travis-ci: Make use of before_script target 2014-02-16 15:47:53 +01:00
Jan Wagner
34b0982087 travis-ci: Update package list in before_install
[skip ci]
2014-02-16 12:30:21 +01:00
Jan Wagner
2947e0084f travis-ci: Move all into install target
just keeped 'make' in script target
2014-02-16 11:24:36 +01:00
Jan Wagner
97867c6137 travis-ci: Add clang and gcc as compiler 2014-02-16 11:22:33 +01:00
Jan Wagner
dedc7289da travis-ci: Enable IRC notification 2014-02-15 20:59:09 +01:00
Jan Wagner
0966dcc6f7 Add travis config 2014-02-14 16:52:25 +01:00
Thomas Guyot-Sionnest
d2744118dc Merge pull request #1234 from skottler/plugin_makefile_whitespace
Remove unnecessary whitespace in Makefile.am
2014-02-07 09:18:06 -05:00
Sam Kottler
54bce08d52 Remove unnecessary whitespace in Makefile.am 2014-02-07 13:53:33 +01:00
Thomas Guyot-Sionnest
f3078c33f6 Add perfdata in check_proc output tests 2014-01-31 13:00:53 -05:00
Thomas Guyot-Sionnest
f45adede7d Fix snmpd tests 2014-01-31 12:30:11 -05:00
Thomas Guyot-Sionnest
1dd0e4c963 Enable tests in tests/ subdirs 2014-01-31 08:54:44 -05:00
Stephane Lapie
35811848da Handle negative values properly with check_snmp
check_snmp becomes capable of evaluating negative values properly,
but it might be returning CRITICALs where it used to return OK and was ignored,
if a negative value turns out to actually be a valid value.
If negative values are valid, this can be worked around,
by adding "~:" to the warning/critical threshold : 100 -> ~:100
2014-01-31 00:49:18 -05:00
Thomas Guyot-Sionnest
c4e3cd6efd Add tests for negative thresholds in check_snmp
Next commit will work on fixing these!
2014-01-31 00:48:49 -05:00
Thomas Guyot-Sionnest
bc92b93920 Add tests for negative thresholds in test_utils 2014-01-31 00:04:23 -05:00
Holger Weiss
4a2a725465 check_dig: Declare variable at the top
C89 doesn't allow variable declarations to be intermingled with code.
2014-01-30 19:51:46 +01:00
Jan Wagner
e33ecc84c7 check_dig: stick with integer devision
This change saves us from having to link check_dig against "libm"
2014-01-30 11:28:19 +01:00
Jan Wagner
2aa6ce2844 check_dig: timeout_interval is a global variable
which is already set to 10 seconds
2014-01-30 11:28:09 +01:00
Jan Wagner
df53473d03 check_dig: patch to make dig honor -t option
When a timeout value is specified with the -t option, dig will sometimes
timeout before the timer is actually reached.

The problem occurs because the check_dig plugin does not pass the specified
timeout value to dig, leaving dig to timeout with it's default value which
seems to be around 10-15seconds.

To reproduce:
time ./check_dig -H 127.0.0.2 -l www.google.com -t 30

It will not run for 30secs, which is the expected behaviour.

The following will work, because the timeout is less than the default dig
timeout, so the plugin cancels the dig command:
time ./check_dig -H 127.0.0.2 -l www.google.com -t 2

This fix passes the timeout value to dig, and sets the number of retries which tends to vary from system to system by default.

Closes #1168
2014-01-30 11:07:22 +01:00
Thomas Guyot-Sionnest
7310030ae7 Add tests for mp_translate_state() 2014-01-29 22:03:04 -05:00
Jan Wagner
2dc150da81 check_mailq: adding nullmailer support
Adding nullmailer support to check_mailq submitted by Luca Corti

Closes: #740
Closes: #1189
2014-01-29 13:45:36 +01:00
Jan Wagner
297d0535c2 Just fixing small typo in comment 2014-01-29 10:12:31 +01:00
Thomas Guyot-Sionnest
813c02364f Update check_swap usage 2014-01-29 03:59:48 -05:00
Thomas Guyot-Sionnest
44485ddee2 AUpdate .gitignore for new gnulib module 2014-01-29 03:48:24 -05:00
Thomas Guyot-Sionnest
7afbca0b8c check_swap: add supports for a configurable state when there is no swap
Check_swap used to allow no swap when thresholds were only specified in
percent. This is no longer the case and the state now must be specified
explicitly. The default is to always return CRITICAL when the swap is
absent regardless of thresholds.
2014-01-29 03:40:11 -05:00
Thomas Guyot-Sionnest
8fc9e5ac4b Move negate' translate_state() to utils_base.h mp_translate_state()
Also use strcasecmp imported from gnulib for simplicity
2014-01-29 03:20:23 -05:00
Thomas Guyot-Sionnest
55f97c2021 Add strcase gnulib module 2014-01-29 03:04:05 -05:00
Thomas Guyot-Sionnest
fc9fbe1e89 Typo 2014-01-29 02:16:47 -05:00
Thomas Guyot-Sionnest
6f2d545244 Fix check_swap returning OK on & thresholds and no swap
Return 0% free instead of 100% free when total swap is 0
2014-01-29 01:44:22 -05:00
Jan Wagner
cb99931e43 check_disk: precise the help output
Clarifying in the help output that we need either a device or mount point
listed by the mount(8) command.

(Closes: #1118)
(Closes: #1170)
2014-01-28 12:07:48 +01:00
Thomas Guyot-Sionnest
c30be5877c Clarify check_mysql test prompts
Also default to "-u test -ptest" which are default MySQL accounts only
missing the prescribed privileges.

The database is no longer specified as it is not used.
If wanted is should be its own parameter/tests.
2014-01-28 02:35:09 -05:00
Thomas Guyot-Sionnest
f34f51a005 Merge pull request #1200 from awiddersheim/add_file_options_mysql_query
Add ability to read from options file to check_mysql_query.c
2014-01-27 22:50:27 -08:00
Thomas Guyot-Sionnest
58e57b32bf check_dig: fix wrong IPv6 arguments order 2014-01-27 22:16:35 -05:00
Thomas Guyot-Sionnest
189e2aa344 Rename MP_STATE_DIRECTORY to MP_STATE_PATH 2014-01-27 08:35:23 -05:00
Thomas Guyot-Sionnest
4a10a9493a And release notes for previous change (MP_STATE_DIRECTORY)
The change has also been updated in
https://www.monitoring-plugins.org/doc/state-retention.html
2014-01-27 02:18:06 -05:00
Thomas Guyot-Sionnest
754cd092ae Fix tests with an empty NPTest.cache file
The NPTest.cache cannot be loaded when empty, and this prevents
getting the data and populating the file. This patch skips the file when
empty as if it didn't exist.
2014-01-26 04:49:32 -05:00
Thomas Guyot-Sionnest
68fe713335 Ignore MP_STATE_DIRECTORY in suid plugins
If a plugin still has suid privileges at the time np_enable_state() is
called, the MP_STATE_DIRECTORY environment will be ignored.

There is no need for a NEWS entry as no suid plugins use np_enable_state
yet.
2014-01-25 04:22:09 -05:00