Commit graph

2055 commits

Author SHA1 Message Date
Thomas Guyot-Sionnest
bc3c8c7cfb Fix check_ircd binding to wrong interface (#668778) 2009-09-19 02:08:51 -04:00
Thomas Guyot-Sionnest
e82b611840 Update RELEASING document with proper tag creation and push commands 2009-09-19 02:03:59 -04:00
Ton Voon
bc26fec6d6 Prep for 1.4.14 release 2009-09-16 09:33:05 +01:00
Ton Voon
bbadda8979 Ensure dirhandle is closed (Duncan Ferguson) 2009-09-14 11:22:13 +01:00
Ton Voon
aa6563c75c Fix skip number 2009-09-11 23:58:41 +01:00
Thomas Guyot-Sionnest
181ac1e018 Add a test that succeeds on check_snmp v1.4.13. Newer versions skip additional
lines so this new test fails on the current head.

Note: check_snmp v1.4.13 with multi-line strings return somewhat v3 output;
      it's not exactly what the specs say but it doesn't appears to break them
      either. The fix could eventually supports both v2 and v3 output formats.
2009-09-05 03:16:54 -04:00
Thomas Guyot-Sionnest
b8a64210bd Fix segfault in check_snmp (definitive fix is still in the works - see bug #2832451) 2009-08-05 03:13:08 -04:00
Thomas Guyot-Sionnest
1295c93651 Fix check_snmp passing single-quotes as -m argument when it should be empty 2009-07-31 23:35:50 -04:00
Thomas Guyot-Sionnest
43571dba91 check_snmp: Add some verbose output and tests 2009-07-31 03:52:10 -04:00
Thomas Guyot-Sionnest
8a96ee4741 Add tests using custom snmp agent
Only multi-line string test for now (regression test), counter rollover
tests planed with my snmp_counters_new branch.

NB: 64bit counters are broken in NetSNMP::agent from NetSNMP version 5.4.1
    and lower, but might come in handy one day
2009-07-31 03:07:38 -04:00
Thomas Guyot-Sionnest
e0be2e6094 Fix check_snmp Timetick test with <1 day uptime 2009-07-31 01:41:03 -04:00
Thomas Guyot-Sionnest
4aec8e28c3 Add accidentally removed line plus a note about the web copy 2009-07-23 08:52:08 -04:00
Thomas Guyot-Sionnest
1b7eeac5a0 Merge changes from web 2009-07-23 08:49:07 -04:00
Ton Voon
f17d7c0517 Updated links for exchange.nagios.org 2009-07-17 17:24:28 +01:00
Ton Voon
0dcd5e677e pst3 compile with Sun Studio Compiler 2009-07-14 23:20:21 +01:00
Ton Voon
9ff36ec7e3 Added example for check_cluster to alert if more than X non-OK states 2009-06-22 20:48:57 +01:00
Matthias Eble
013f0a187f Switch back to "use Test" and plain prints instead of diag() 2009-06-16 23:51:19 +02:00
Matthias Eble
3ea954933c Tinderbox output testing commit 2009-06-16 19:31:25 +02:00
Matthias Eble
2e7c3ac75a Make output of "make test" more verbose
This is intended to make error fixing based on tinderbox output
easier.
2009-06-15 21:45:12 +02:00
Matthias Eble
5f67308451 Fixed error in rtt/rta calculation in case of system clock problems
Time differences are now set to 0 in case of backward timejumps so there are no wrap-around problems any more.
The RTA calculation hopefully gets a more accurate value in these cases also.
2009-06-14 23:31:29 +02:00
Matthias Eble
38e20a1a33 Fixed testcases for check_snmp, check_ifstatus and check_ifoperstatus when no snmp community is specified
The checks for invalid/unavailable hosts need a complete command line.
They failed on hosts where no community was specified. Now, an invalid community is used so
the tests can run on hosts w/o snmp host/community in NPTest.cache. Execution will fail anyway.
2009-06-13 18:13:49 +02:00
Matthias Eble
05b801284c Further test parameters and skip blocks for check_ifoperstatus.t. getTestparam changes for check_ifstatus.t and ifoperstatus.t
Added snmp_interface and snmp_ifxtable test parameters to check_ifoperstatus.t.
Also getTestParameter calls for both plugins were converted to use three arguments
instead of undocumented >3 arg behaviour which led to redundant data in NPTest.cache.
2009-06-13 11:10:32 +02:00
Matthias Eble
5a6268f729 Merge branch 'master' of ssh://PsychoTrahe@repo.or.cz/srv/git/nagiosplugins 2009-06-11 17:28:14 +02:00
Matthias Eble
c66d2c6b3b renamed check_ifoperstatus' newly introdced -x to -P so it fits check_ifstatus
check_ifstatus already used -x so both plugins can use same short option, now.
to specify privacy protocol.
2009-06-11 17:24:52 +02:00
Matthias Eble
edda2536e5 Fixed SNMPv3 behaviour of check_ifstatus. Added -P to define privprotocol (#2343438 - Robin Schroeder)
check_ifstatus didn't function correctly with SNMPv3. This is fixed now.
Created argument-hash for SNMP session creation. This removes redundant code.
Session creation was moved out of process_arguments() and now takes place
after setting the timeout handler.

Additionally the -P argument was added to specify the privprotocol.
2009-06-11 17:20:55 +02:00
Matthias Eble
e16b35b2ca Added testcases for check_ifoperstatus
Added testcases for check_ifoperstatus. No SNMPv3 testing
included for now.
2009-06-11 16:27:15 +02:00
Matthias Eble
0f8ef1f780 minor fixes to check_ifoperstatus
Minor output fixes for check_ifoperstatus.
Fixed typo so that -n now implies -I as documented.
2009-06-11 16:22:47 +02:00
Thomas Guyot-Sionnest
6e5d12b5d0 Use a more "natural" way of writing argument lists in extra-opts tests. 2009-06-11 00:14:23 -04:00
Matthias Eble
8b8a30716a check_ifoperstatus is now more user friendly in case of missing arguments
Added proper usage messages in case of missing arguments.
Removed accidently committed Data::Dumper call.
Minor whitespace fixes.
2009-06-11 02:29:13 +02:00
Matthias Eble
08deb74704 Whitespace and indent fixes for check_ifoperstatus 2009-06-11 01:34:39 +02:00
Matthias Eble
5195074095 Fixed SNMPv3 behaviour of check_ifoperstatus. Added -x to define privprotocol (#2343438 - Robin Schroeder)
check_ifoperstatus didn't function correctly with SNMPv3. This is fixed now.
Created argument-hash for SNMP session creation. This removes redundant code.
Session creation was moved out of process_arguments() and now takes place
after setting the timeout handler.

Additionally the -x argument was added to specify the privprotocol.
2009-06-11 01:17:58 +02:00
Holger Weiss
9eabd8d054 Fix the memory allocation for the thresholds data
Allocate the appropriate amount of memory for storing the thresholds
data.  Before, we allocated the amount of memory required for storing a
_pointer_ to the thresholds data.  This crashed (at least) check_mysql
when using its "-S" option on FreeBSD/amd64 (as reported and analyzed by
Nikita Kalabukhov - 2797757).

Signed-off-by: Holger Weiss <holger@zedat.fu-berlin.de>
2009-06-02 01:11:19 +02:00
Holger Weiss
bc827c9083 Don't use the plain char type for data buffers
Buffers which are used for holding arbitrary data should be referenced
using pointers to void and accessed using pointers to unsigned char.

Signed-off-by: Holger Weiss <holger@zedat.fu-berlin.de>
2009-06-02 01:09:18 +02:00
Matthias Eble
aff6140989 Whitespace indent fixes for check_pgsql 2009-06-01 22:47:34 +02:00
Matthias Eble
0a5cd15e75 Fixed check_icmp compiler warnings by including float.h
Self defined DBL_MAX caused compiler warnings. Now float.h
which defines DBL_MAX is included.
2009-06-01 22:41:46 +02:00
Matthias Eble
1c55e7287a Fixed --help output for warn and critical thresholds (sf.net #2796624, debian #530553)
check_icmp wrongly calculated the current thresholds in --help output.
2009-06-01 22:21:59 +02:00
Matthias Eble
28e1b836b1 Added verbose output to check_pgsql (#2799281 - Jun Kuriyama)
check_pgsql displayed the -v flag in help output, but didn't
accept the verbosity argument. Added -v and basic verbose output.
2009-06-01 22:08:07 +02:00
Matthias Eble
843c652768 check_fping now supports passing target timeout and interval to fping (#2347686 - Martin Foster)
Added support for passing timeout and interval length to check_fping.
To protect compatibility, both options use fping's defaults if they
are not specified on the command line.
2009-06-01 16:42:14 +02:00
Thomas Guyot-Sionnest
7cb3ae0933 check_snmp: Make use of standard threshold functions
This patch makes use of standard threshold functions. This allows using
	doubles as thresholds.

	Since SNMP supports only integers, double precision numbers are only
	printed when parsed from a STRING type.

	In addition, support for printing properly Timeticks type has been added,
	and the code has been thoroughly cleaned.
2009-05-28 08:10:49 -04:00
Thomas Guyot-Sionnest
34fe4d62fe Fix whitespaces in check_snmp 2009-05-27 01:38:28 -04:00
Thomas Guyot-Sionnest
fcc4db5aaa Fix check_by_ssh interpretation of quotes in -C parameter (#1985246, #2268675) 2009-05-26 04:28:41 -04:00
Matthias Eble
221cb49206 Fixed wrong perfdata label for output traffic in check_mrtgtraf
check_mrtgtraf used the label "in" for both input and output traffic.
This fixed, now.
2009-05-22 23:57:36 +02:00
Matthias Eble
6f0665719c Removed -n option in check_smtp's help and usage output (#2782784)
Check_smtp's help showed the -n/--nocommand options to not send an
SMTP command. This usage is covered by check_tcp and is thus not needed
in check_smtp.
2009-05-22 20:17:50 +02:00
Thomas Guyot-Sionnest
ecb33e787c Whitespace changes only 2009-05-20 14:06:29 -04:00
Thomas Guyot-Sionnest
0489df95fc check_http: Add SSL/TLS hostname extension support (SNI) - (#1939022 - Joe Presbrey) 2009-05-20 01:05:35 -04:00
Thomas Guyot-Sionnest
56cf66c9b8 Fix awk subst.in/subst script path error (#2722832 - Martin Foster) 2009-05-20 00:43:10 -04:00
Thomas Guyot-Sionnest
917fcc7c30 Fix check_mysql* not using password set in my.cnf (#2531905 - Ben Timby) 2009-05-20 00:20:11 -04:00
Holger Weiss
50b3ff7b91 Sync with the latest Gnulib code (cb75dc5)
Signed-off-by: Holger Weiss <holger@zedat.fu-berlin.de>
2009-05-20 00:32:10 +02:00
Chris Pepper
2701ccd500 Fix a few minor typos
Signed-off-by: Holger Weiss <holger@zedat.fu-berlin.de>
2009-05-19 14:18:42 +02:00
Holger Weiss
b6362e9cf5 Talk about Git instead of CVS
Update the Developer Guidelines to reflect the fact that our development
is done using Git instead of CVS these days (as noted by Chris Pepper on
the "nagiosplug-devel" list).

While at it, apply another few minor cleanups.

Signed-off-by: Holger Weiss <holger@zedat.fu-berlin.de>
2009-05-19 14:18:02 +02:00