Commit graph

140 commits

Author SHA1 Message Date
Thomas Guyot-Sionnest
bc3c8c7cfb Fix check_ircd binding to wrong interface (#668778) 2009-09-19 02:08:51 -04:00
Matthias Eble
38e20a1a33 Fixed testcases for check_snmp, check_ifstatus and check_ifoperstatus when no snmp community is specified
The checks for invalid/unavailable hosts need a complete command line.
They failed on hosts where no community was specified. Now, an invalid community is used so
the tests can run on hosts w/o snmp host/community in NPTest.cache. Execution will fail anyway.
2009-06-13 18:13:49 +02:00
Matthias Eble
05b801284c Further test parameters and skip blocks for check_ifoperstatus.t. getTestparam changes for check_ifstatus.t and ifoperstatus.t
Added snmp_interface and snmp_ifxtable test parameters to check_ifoperstatus.t.
Also getTestParameter calls for both plugins were converted to use three arguments
instead of undocumented >3 arg behaviour which led to redundant data in NPTest.cache.
2009-06-13 11:10:32 +02:00
Matthias Eble
c66d2c6b3b renamed check_ifoperstatus' newly introdced -x to -P so it fits check_ifstatus
check_ifstatus already used -x so both plugins can use same short option, now.
to specify privacy protocol.
2009-06-11 17:24:52 +02:00
Matthias Eble
edda2536e5 Fixed SNMPv3 behaviour of check_ifstatus. Added -P to define privprotocol (#2343438 - Robin Schroeder)
check_ifstatus didn't function correctly with SNMPv3. This is fixed now.
Created argument-hash for SNMP session creation. This removes redundant code.
Session creation was moved out of process_arguments() and now takes place
after setting the timeout handler.

Additionally the -P argument was added to specify the privprotocol.
2009-06-11 17:20:55 +02:00
Matthias Eble
e16b35b2ca Added testcases for check_ifoperstatus
Added testcases for check_ifoperstatus. No SNMPv3 testing
included for now.
2009-06-11 16:27:15 +02:00
Matthias Eble
0f8ef1f780 minor fixes to check_ifoperstatus
Minor output fixes for check_ifoperstatus.
Fixed typo so that -n now implies -I as documented.
2009-06-11 16:22:47 +02:00
Matthias Eble
8b8a30716a check_ifoperstatus is now more user friendly in case of missing arguments
Added proper usage messages in case of missing arguments.
Removed accidently committed Data::Dumper call.
Minor whitespace fixes.
2009-06-11 02:29:13 +02:00
Matthias Eble
08deb74704 Whitespace and indent fixes for check_ifoperstatus 2009-06-11 01:34:39 +02:00
Matthias Eble
5195074095 Fixed SNMPv3 behaviour of check_ifoperstatus. Added -x to define privprotocol (#2343438 - Robin Schroeder)
check_ifoperstatus didn't function correctly with SNMPv3. This is fixed now.
Created argument-hash for SNMP session creation. This removes redundant code.
Session creation was moved out of process_arguments() and now takes place
after setting the timeout handler.

Additionally the -x argument was added to specify the privprotocol.
2009-06-11 01:17:58 +02:00
Thomas Guyot-Sionnest
56cf66c9b8 Fix awk subst.in/subst script path error (#2722832 - Martin Foster) 2009-05-20 00:43:10 -04:00
Ton Voon
5324544855 Typo fixes (Jan Wagner - SF 1878971) 2009-02-20 00:00:13 +00:00
Thomas Guyot-Sionnest
399f0770b2 Fixing build breakages (I totally forgot this rule was there...) 2008-11-26 21:29:40 -05:00
Thomas Guyot-Sionnest
9bcfa9cded Disable dynamic versionning for releases, and allow generating version out of subversion.
This should be a definitive fix for systems with non-compilant make programs as the version will be taken from $(PACKAGE_VERSION) instead.

At the same time I added code for generating svn-based version strings.
2008-11-26 05:42:48 -05:00
Thomas Guyot-Sionnest
ed9a088b37 Workaround to support more make programs
Avoid the use of "-include". Since "include" is interpreted by Automake, we have to use a special macro instead.
2008-11-25 08:50:35 -05:00
Thomas Guyot-Sionnest
0c34b75b05 Exporting ENV vars from Makefile is supported only with GNU Make. Use the shell instead. 2008-11-25 00:28:51 -05:00
Thomas Guyot-Sionnest
c0a75482b4 Avoid the use of .PHONY (target s created twice and I have no idea if it's right). 2008-11-23 13:34:19 -05:00
Thomas Guyot-Sionnest
6fbd14fea5 Removing CVS/SVN tags and replacing with git-based versioning
For contrib/, full tags have been imported from subversion


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2091 f882894a-f735-0410-b71e-b25c423dba1c
2008-11-23 05:38:47 +00:00
Matthias Eble
96d6281428 check_ifoperstatus -n flag now works as expected (sf.net #1569488)
check_ifoperstatus now supports ifType based lookup for ifIndex


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2061 f882894a-f735-0410-b71e-b25c423dba1c
2008-10-22 21:35:15 +00:00
Ton Voon
151531173b Run tinderbox builds in a test debug mode using "make test-debug"
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1866 f882894a-f735-0410-b71e-b25c423dba1c
2007-12-12 01:27:48 +00:00
Ton Voon
37287823f0 Removing all .cvsignore files
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1761 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-24 00:35:42 +00:00
Matthias Eble
2208c1b7f3 Changed print_revision output order in utils.pm
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1751 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-07 11:55:48 +00:00
Matthias Eble
603de749ba substituted $ID$ through $Revision$ in print_revision call
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1750 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-07 11:54:29 +00:00
Matthias Eble
a10569f139 Changed order in -V/--version output
Fixed -V output for check_log and check_oracle


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1749 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-07 11:40:29 +00:00
Matthias Eble
1baf11d3af check_oracle does not need a valid ORACLE_HOME if called with --db. Thanks to Jason Martin (#1505551)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1719 f882894a-f735-0410-b71e-b25c423dba1c
2007-05-27 14:49:54 +00:00
Gavin Carr
8d0e8a652f Fix bogus 'eq ( || )' constructions in check_ifoperstatus.pl.
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1642 f882894a-f735-0410-b71e-b25c423dba1c
2007-03-16 12:11:46 +00:00
Thomas Guyot-Sionnest
026db39bb7 Fix bug #1593073 Check_Log problem with log rotation
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1602 f882894a-f735-0410-b71e-b25c423dba1c
2007-02-01 05:33:07 +00:00
Ton Voon
287cd311a2 Enhanced test for single letters in fqdn
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1549 f882894a-f735-0410-b71e-b25c423dba1c
2006-12-12 12:59:06 +00:00
Ton Voon
fc6caed01c Allow single characters in fqdn (Dave Alden)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1548 f882894a-f735-0410-b71e-b25c423dba1c
2006-12-12 08:56:01 +00:00
Ton Voon
6c61b8c7bf More edge testcases. Allow anything if ends with a . as long as correct
characters


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1531 f882894a-f735-0410-b71e-b25c423dba1c
2006-10-27 15:37:31 +00:00
Ton Voon
94a3cf91b3 Fixed error if dba_free_space has no free segments (Florian Gleixner)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1529 f882894a-f735-0410-b71e-b25c423dba1c
2006-10-26 21:10:20 +00:00
Ton Voon
6728e60669 Fixed regression where hostnames with hyphens were rejected (1581402 - Holger Weiss)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1528 f882894a-f735-0410-b71e-b25c423dba1c
2006-10-26 21:02:21 +00:00
Ton Voon
d15721d2f8 Allow hostnames beginning with digits (O'Shaughnessy Evans - 1567390)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1501 f882894a-f735-0410-b71e-b25c423dba1c
2006-10-19 18:44:53 +00:00
Ton Voon
ab9b1169c2 Cleanup references to old check_udp and INSTALL_OPTS. Error if
--with-nagios-user or --with-nagios-group specified for configure


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1460 f882894a-f735-0410-b71e-b25c423dba1c
2006-07-28 23:59:29 +00:00
Ton Voon
5f9761ed60 Fixed checking of return codes from external mailq programs
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1443 f882894a-f735-0410-b71e-b25c423dba1c
2006-07-05 13:45:57 +00:00
M. Sean Finney
79ee3b93fb removed stale references to PATH_TO_NTPFOO, as it's no longer used.
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1417 f882894a-f735-0410-b71e-b25c423dba1c
2006-06-07 14:23:12 +00:00
M. Sean Finney
e667553b97 - check_ntp:
- now roughly feature-complete.
  - various bugfixes, esp. offset calculation.
  - enhanced the asynchronous offset polling to set requests that
    haven't recieved a response in >= 1 second to stale and retransmit them,
    which results in much better performance on unreliable networks.
  - we only spend timeout/2 seconds polling offsets, and if we don't get
    everything by that point we work with what we have and set status to
    warning/critical depending on how much data we have.
  - set the same defaults as the perl script.
- commit changes to configure.in to support automatic building of check_apt
  (if apt-get is installed and regex libraries available) and check_ntp
  (unconditionally), now defaulting to check_ntp.c instead of the perl script.
  if this is an issue we can back out the commit of course.  an eye
  should be kept on check_ntp building and running correctly in different
  environments, esp. 64-bit and big-endian platforms, and those with more
  "esoteric" API's (do any of the platforms not have poll()?).
- similar changes to Makefile.am's.
- common.h: add statement to include sys/poll.h
- runcmd.c: exit STATE_UNKNOWN if execve() fails.


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1386 f882894a-f735-0410-b71e-b25c423dba1c
2006-05-01 21:52:42 +00:00
Ton Voon
087bf1c765 Remove PATH restriction
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1343 f882894a-f735-0410-b71e-b25c423dba1c
2006-03-22 14:32:06 +00:00
Ton Voon
450054438c Remove hardlink to /bin/sed. Leave to PATH (Abs - 1391483)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1340 f882894a-f735-0410-b71e-b25c423dba1c
2006-03-22 12:59:36 +00:00
Ton Voon
73b77a44c4 Allow directories and links to be tested by check_file_age. Sanitise output.
Added tests


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1297 f882894a-f735-0410-b71e-b25c423dba1c
2005-12-15 15:17:49 +00:00
Harper Mann
e5b45d0e14 Nagiosplug bug # 1251096
check_ntp wasn't properly handing a bad exit status from the external programs it calls (ntpdate and ntpq), so jitter wasn't set.  Added check of $? on close and proper error output if status from the sub program call completion is non-zero.  This includes "host not found".


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1291 f882894a-f735-0410-b71e-b25c423dba1c
2005-11-30 00:49:47 +00:00
M. Sean Finney
e082e8565f check_log fixes from Ade Rixon
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1263 f882894a-f735-0410-b71e-b25c423dba1c
2005-10-29 15:38:40 +00:00
M. Sean Finney
17edbb05d4 debian bts #268044:
- use a "less beastly" regex for parsing ntpq output.  probably need
  some more widespread testing on this one.


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1250 f882894a-f735-0410-b71e-b25c423dba1c
2005-10-13 10:20:50 +00:00
M. Sean Finney
a0a6dd410c debian bts #300701:
- check_smb fix for freespace threshold parsing from the cmdline options.


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1247 f882894a-f735-0410-b71e-b25c423dba1c
2005-10-13 10:14:33 +00:00
Ton Voon
3c554b72de Better comments for what the substitutions are doing
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1212 f882894a-f735-0410-b71e-b25c423dba1c
2005-08-30 22:11:42 +00:00
Peter Bray
cdc06cc3e2 [1185704] New Testing Infrastructure.
Complete rewrite of the original testing infrastructure and
all test cases (to use the new infrastructure)
See NPTest.pm and issue 1185704 for more details.


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1207 f882894a-f735-0410-b71e-b25c423dba1c
2005-07-25 01:47:15 +00:00
Subhendu Ghosh
703a4bf74d perfdata patch - 1172539
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1180 f882894a-f735-0410-b71e-b25c423dba1c
2005-05-25 14:05:41 +00:00
Subhendu Ghosh
4aa2652a54 new option for zero offset - 1159317
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1179 f882894a-f735-0410-b71e-b25c423dba1c
2005-05-25 03:37:48 +00:00
Subhendu Ghosh
dafcd90015 patched bug id 1200030 - regex update
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1175 f882894a-f735-0410-b71e-b25c423dba1c
2005-05-24 22:33:09 +00:00
Subhendu Ghosh
36458320f7 patched bug id 1204636
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1174 f882894a-f735-0410-b71e-b25c423dba1c
2005-05-24 22:10:05 +00:00