Commit graph

3545 commits

Author SHA1 Message Date
christian-2
dd249c5d4b
check_disk: Find accessible mount path if multiple are available (#1820)
* fixes #1819
* mount entries also have to be accessible according to get_fs_usage()
2022-12-13 23:48:36 +01:00
Aksel Sjögren
a517c62c1b check_http: fix test plan
Fix test plan when run with NP_INTERNET_ACCESS=no, where the correct
number of steps must be skipped.
Caused by a removed test in 65fc706429.

Signed-off-by: Aksel Sjögren <asjogren@itrsgroup.com>
2022-11-29 16:38:33 +01:00
Aksel Sjögren
e5db81bb29 check_icmp: fix parsing help/version long options
Fix parsing of the long options --help and --version. The special
handling must be done before calling getopt().
This fixes erroneous output like:

    ./check_icmp --version
    ./check_icmp: invalid option -- '-'
    ./check_icmp: invalid option -- 'e'
    ./check_icmp: invalid option -- 'r'
    ./check_icmp: invalid option -- '-'
    ./check_icmp: invalid option -- 'e'
    ./check_icmp: invalid option -- 'r'

Signed-off-by: Aksel Sjögren <asjogren@itrsgroup.com>
2022-11-29 16:38:33 +01:00
dependabot[bot]
1bc6d81651 Bump actions/checkout from 2 to 3
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-11-11 06:28:27 +01:00
dependabot[bot]
de06e5832e
Bump github/codeql-action from 1 to 2 (#1812)
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1 to 2.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/v1...v2)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-07 17:49:31 +01:00
Lorenz
4a5ddd2011
Check curl detect ipv6 (#1809)
* If server_address is an IPv6 address surround it with brackets

* If the message is too short, we should not have an underflow

* Add simple conditional test case available if IPv6 is
2022-11-07 17:48:28 +01:00
waja
8708fd21a6
Adding dependabot config which takes care of updating github actions (#1811) 2022-11-07 17:47:30 +01:00
Lorenz
f7f7309b99
Update GitHub runner (#1810)
* Update action/checkout to v3

* Format debian prepare script
2022-11-06 23:12:41 +01:00
Lorenz
edc84e5d66
Remove superflous CRLF in HTTP-Requests in check_http (#1798)
* Remove superflous CRLF in HTTP-Requests in check_http
2022-11-05 13:59:45 +01:00
waja
2d9c6276d0
Removing is_pg_dbname alltogether,using postgres API. (Closes: #1660) (#1803)
The problem is that check_pgsql validates the Database name and has different assumptions
that postgres itself.

I fail to see a reason to validate the database name here. Postgres'es API should
do this - So i would suggest a fix like this by removing is_pg_dbname alltogether.

Co-authored-by: Florian Lohoff <f@zz.de>
2022-11-04 19:16:01 +01:00
Andreas Baumann
eb2dfdd5c2
fixed two PRId64 to PRIu64 in perfdata_uint64 (#1802) 2022-10-27 22:48:18 +02:00
Andreas Baumann
817ac2e5da
using PRId64 and PRIu64 instead of %ld directly (#1800) 2022-10-21 18:31:12 +02:00
Sven Nierlein
d4f71ac2e7 release v2.3.2 2022-10-19 14:47:57 +02:00
Jan Wagner
a6af5119d0 Updating THANKS.in 2022-10-07 15:08:36 +02:00
Jan Wagner
fbdeb52b26 Adding Andreas Baumann to AUTHORS 2022-10-07 15:08:36 +02:00
Jan Wagner
6f022ace52 Draft NEWS 2022-10-07 15:08:36 +02:00
Lorenz
1ec6b162cb
Replace egrep with grep -E (#1791)
Replace egrep with grep -E to avoid the deprecation warnings
2022-10-07 11:44:47 +02:00
Lorenz
b90a5757f7
Display total and scaled load values if check_load scales the values by number of CPUs (#1778)
* Renew copyright

* Display more verbose output, if scaled load values are used

* Actually use scaled value for determining status and print the fitting perfdata depending on input parameters

* Add test cases for scaled mode
2022-09-19 10:23:49 +02:00
Jan Wagner
8087291729 check_http: Fix HD6 definition 2022-09-18 20:42:26 +02:00
John C. Frickson
e2e405596a I had to make a couple of small changes. 2022-09-18 20:42:26 +02:00
Eric Wunderlin
d57d2b0bdd Remove unused code 2022-09-18 20:42:26 +02:00
Eric Wunderlin
8f54442c68 Added ability to correctly check redirects with reference format //test.server.com/folder
Referenced redirect of the format //www.server.com/folder would result
in check_http trying to contact http://hostname:80//www.server.com/folder
instead of http://www.server.com/folder. Referenced redirect of this format
is listed in rfc3986 ( https://tools.ietf.org/html/rfc3986 ). It should
work as expected now.
2022-09-18 20:42:26 +02:00
Lorenz
b89aee5696
Check ntp remove unused variables (#1781)
* Remove unused argument

* Fix typo in comment
2022-09-14 10:54:46 +02:00
Lorenz
ef57962552
Check disk compiler warnings (#1758)
* Use unused variable

* Proper format strings for printf

* Use proper functions for absolute values

* Remove and add comments at some places
2022-09-11 06:29:58 +02:00
Lorenz
a9cdbc8959
Check load compiler warnings (#1759)
* Fix compiler warnings due to implizit conversion and formats

* Make includes more specific and complement them

* Formatting fixes
2022-09-11 06:29:36 +02:00
Lorenz
fbbc9fcbd5
Check swap compiler warnings (#1756)
* Fix compiler warnings

* Fix superfluous whitespaces
2022-09-11 06:29:17 +02:00
Lorenz
3ad5fe9d84
check_swap: Fix unit for total in perfdata (#1779)
* check_swap: Fix unit for total in perfdata

* Remove trailing whitespaces
2022-07-25 10:11:43 +02:00
Sven Nierlein
a01de7b33d
fix parsing swap values (#1780)
tmp_KB changed from float to uint64, so change the sscanf format accordingly.
2022-07-25 10:00:18 +02:00
adrb
9f2a9ca3d7
check_snmp: Segfault if number of processed lines is greater than number of thresholds
Segfault at line 489 if number of processed lines is greater than number (#1589) of thresholds

Co-authored-by: Lorenz <12514511+RincewindsHat@users.noreply.github.com>
2022-07-24 16:44:16 +02:00
Lorenz
65fc706429
Remove check_http and check_curl test which are somehow always failing (#1777)
* Remove failing checks for check_http
* Remove failing checks for check_curl
2022-07-20 13:33:49 +02:00
eriksejr
ee50ddf698
Set msg_namelen to the size of the sockaddr struct for the appropriate address family and not sockaddr_storage (#1771)
Co-authored-by: Erik Sejr <eriks@ssimicro.com>
Co-authored-by: Lorenz <12514511+RincewindsHat@users.noreply.github.com>
2022-07-14 10:25:51 +02:00
Archie L. Cobbs
ccf4ed25f9
check_by_ssh: Add "-U" flag (#1123). (#1774)
This causes a 255 exit value from ssh(1), which indicates a connection failure,
to return UNKNOWN instead of CRITICAL; similar to check_nrpe's "-u" flag.
2022-07-14 08:47:54 +02:00
Lorenz
175e43133c
Update CodeQL and update runner before installing (#1775) 2022-07-03 15:57:55 +02:00
CDMIUB
d63bb62e5d
Cdmiub (#1770)
* added timout option to check_disk_smb
2022-06-18 09:15:58 +02:00
Andreas Baumann
2430d54084
Merge pull request #1762 from monitoring-plugins/continue_after_certificate
check_http/checkcurl: added --continue-after-certificate (backport from nagios-plugins)
2022-04-10 18:03:53 +02:00
Andreas Baumann
a96bdd7349 check_curl: added option --continue-after-certificate (#1761) 2022-04-10 16:31:53 +02:00
Andreas Baumann
455fdc1072 check_http: added option --continue-after-certificate (#1761) 2022-04-10 16:31:47 +02:00
Tobias Fiebig
066b6e6824
remove duplicate W=i/C=i args (#1755)
Co-authored-by: Tobias Fiebig <t.fiebig@tudelft.nl>
2022-03-26 12:55:23 +01:00
Claudio Kuenzler
9a659f46ff
Add configfile feature to check_disk_smb (#1402) 2022-03-17 10:01:50 +01:00
Lorenz
6054055571
check_icmp: buffer offerflow (#1733)
* Fix different overflows

* Less includes

* Add testcases

* Remove unused variable

* Remove unused and commented includes
2022-03-15 22:00:55 +01:00
Andreas Motl
6c8b45a169 check_uptime: Fix lowercase typo in plugin output 2022-02-15 16:31:23 +01:00
Andreas Motl
c99a166a43 check_uptime: Add option to report uptime in days instead of seconds
Currently, the plugin output is:

  CRITICAL: Uptime is 38829029 seconds.

When using the proposed `--days|-d` option, it will be:

  CRITICAL: Uptime is 449 days.
2022-02-15 16:09:47 +01:00
Lorenz
5943528121
Use silent automake by default (#1747) 2022-02-01 09:57:50 +01:00
Lorenz
d485b64ef0
Description for -M was the wrong way around (#1746)
Using -M should show the mountpoint instead of the device the
file system originated from.
Seems like this was not the case for a long time and now
the default is to show the mount point. Using `-M` reverts
to showing the (block) device instead.
The usage Description was adjusted with this commit.
2022-01-30 19:41:36 +01:00
Lorenz
e781e0d101
Fix double percentage sign in usage (#1743) 2022-01-30 12:44:02 +01:00
Tobias Wiese
31bdbfce92 sslutils: use chain from client certificates
sslutils used to load only the first certificate when it was given a
client certificate file.

Added tests for check_http to connect to a http server that expects a
client certificate (simple and with chain).

Signed-off-by: Tobias Wiese <tobias@tobiaswiese.com>
2022-01-30 12:25:56 +01:00
ghciv6
986b247946 - delay set_source_ip() until address_family is detected
- add a test to check '-s'
2022-01-29 12:19:23 +01:00
Andreas Baumann
ee2a60fc4e fixed -ffollow for HTTP/2.0 (Fixes #1685): added major_version parsing to PicoHTTPParser 2022-01-29 12:17:37 +01:00
Andreas Baumann
737412f739 check_http and check_curl: added --max-redirs=N option (feature #1684) 2022-01-29 12:15:12 +01:00
datamuc
e2397167c7
add --queryname parameter to check_pgsql (#1741)
This is used in the long output instead of the actual query.
So instead of

    OK - 'select stuff from various, tables where some_stuff is null and other_stuff is not null' returned 42

one can use --queryname=check_greatest_basket and it will print

OK - check_greatest_basket returned 42

That's nicer for alerting purposes, at least in our use case.
2022-01-25 10:57:02 +01:00