upstream/monitoring-plugins
1
0
Fork 0
mirror of https://github.com/monitoring-plugins/monitoring-plugins.git synced 2026-04-24 15:53:05 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 3
2731 commits 22 branches 40 tags 28 MiB
Commit graph

2731 commits

This branch
This branch
All branches
Author SHA1 Message Date
Mikael Falkvidd
f54d10fe9b check_procs: Add delay after forking in test 
Forking raises a race condition, where the parent might run the
test before the child has had time to fork. If that happens,
an error similar to this is produced:
 Failed test 'Output correct'
 at ./t/check_procs.t line 32.
                 'PROCS OK: 0 processes with args 'sleep 7' | processes=0;;;0;'
   doesn't match '/^PROCS OK: 1 process?/'

Sleeping a bit should avoid the problem. It might be enough to
sleep less than a second, but perl's built-in sleep function only
supports integer seconds.

In our build environment, the build failed 3 of 4 times before
this patch. After the patch it failed 0 of 7 times.

Signed-off-by: Mikael Falkvidd <mfalkvidd@op5.com>
 2014-07-10 21:10:48 +02:00
Holger Weiss
43b66c06a9 NEWS: Add a warning regarding check_snmp 
Tell users that check_snmp might now return CRITICAL in cases where it
used to return OK, and how to deal with that.
 2014-07-07 21:02:52 +02:00
Holger Weiss
76d8a40cdd NEWS: Update version number 
We're going to release version 2.0, not 1.6.
 2014-07-07 16:49:32 +02:00
Holger Weiss
a2505f049d plugins/netutils.h: Adjust UNIX_PATH_MAX for BSD 
On at least FreeBSD, NetBSD, OpenBSD, DragonFly, and OS X, this is
hard-coded at 104 bytes.

Closes #1267.
 2014-07-07 11:33:39 +02:00
Holger Weiss
1f4fd12845 Don't rely on FindBin module to locate utils.pm 
As the FindBin module doesn't work with ePN, set the path to utils.pm
explicitly at build time.  Keep using FindBin additionally, so that the
plugins can also be executed from the build directory.

Closes #1271.
 2014-07-06 19:55:03 +02:00
Jan Wagner
ba21e26443 check_icmp/check_dhcp: disable check, if we are root 
As it is possible to use capabilities(7) on linux or solaris
privileges for example, it is not necessary in all cases to
have those binaries making use of setuid.
 2014-07-06 13:29:24 +02:00
Holger Weiss
1a0467f672 NEWS: Add missing entries 2014-07-06 12:42:36 +02:00
Holger Weiss
9cb6306928 THANKS.in: Add new authors 
Update the THANKS.in file with the new Git commit authors.
 2014-07-06 12:26:39 +02:00
Jan Wagner
b62f2c14fb Merge PR #1265 from waja/check_tcp_server_addr 2014-06-30 15:13:39 +02:00
abrist
4277f47bff check_jabber.t - fixed tests for new status output including hostname 2014-06-30 13:55:42 +02:00
Sven Nierlein
ed914472e9 Merge pull request #1190 from waja/github780 
check_ssh: check protocol
 2014-06-30 13:42:02 +02:00
Sven Nierlein
2438931a3f Merge pull request #1262 from waja/fix_aix 
Include common.h before any system headers.
 2014-06-28 22:24:52 +02:00
Sven Nierlein
8d6c183347 Merge pull request #1264 from waja/check_nt_units 
check_nt.c - Changed 'Mb' to 'MB' in MEMUSE.
 2014-06-28 22:23:03 +02:00
Sven Nierlein
ea8ab2002c Merge pull request #1263 from waja/coverity_fixes 
Serveral coverity fixes from nagios-plugins
 2014-06-28 22:14:02 +02:00
Sven Nierlein
e566021a54 tests: added check_dns performance data test 
Signed-off-by: Sven Nierlein <sven@nierlein.de>
 2014-06-28 22:05:25 +02:00
abrist
e49973493c check_dns.c Added a bit more logic to thresholds 
Added two if elses to cover when only one threshold is set.
 2014-06-28 22:01:16 +02:00
Jean-Claude Computing
79ba1f90db check_dns: add warning and critical thresholds to perfdata 2014-06-28 22:01:16 +02:00
abrist
b5d78f9556 Cleaned up status output of check_tcp changes 2014-06-28 21:08:55 +02:00
Davide Madrisan
4231415878 check_tcp: also display the server addr when host_specified is set. This will help the admins when multiple checks are configured 
Signed-off-by: Davide Madrisan <davide.madrisan@gmail.com>
 2014-06-28 20:47:51 +02:00
abrist
6e12805fa4 check_nt.c - Changed 'Mb' to 'MB' in MEMUSE. 2014-06-28 20:13:50 +02:00
Spenser Reinhardt
9123f6146c lib/utils_cmd.c - Free file descriptor 
Coverity 66502 - File descriptor fd in cmd_file_read is never closed, and thus file is left open after usage throughout runtime. - SR
 2014-06-28 18:24:46 +02:00
Spenser Reinhardt
aa16beb971 plugins/negate.c - Function should not return. 
Coverity 66479 - validate_arguments has no need to return anything, as it dies on error, yet was set to return an int. Set to void to resolve warning.
 2014-06-28 18:24:08 +02:00
Spenser Reinhardt
88472d1804 plugins/negate.c - Reorder if statement, aiob 
Coverity 66480 - Potential array index out of bounds, since result was not verified to be positive prior to using as an index for state[]. Simply reording the if statement should resolve the issue. - SR
 2014-06-28 18:23:09 +02:00
Spenser Reinhardt
e7e6edb2f8 plugins-root/check_dhcp.c - array out of bounds 
Coverity 66488 - offer_packet->options has a max size of 312. It was being used in a loop verifying less than 311, but increasing by 2 per loop, causing a possible array index out of bounds. Changed to checking less than max length - 1. - SR
 2014-06-28 18:22:04 +02:00
Spenser Reinhardt
5866cb0a09 plugins/check_http.c - leakage fix 
Coverity 66514 - Possible leakage and overflow with addr in redirect functionality. Not confirmed as null terminated, and externally gathered. Restrict string comparisons and duplications by size. - SR
 2014-06-28 18:21:26 +02:00
Spenser Reinhardt
a04df3e1b6 plugins/check_ntp.c - Verify struct from response 
Coverity 66524 - req.data is not neccessarily null terminated but still feed to printf statements. This both does that, and verifies the struct more so than before. - SR
 2014-06-28 18:18:28 +02:00
Spenser Reinhardt
b61f51ad02 plugins/check_real.c - recv string null terminate 
Recv into buffer is not properly null terminated prior to strstr and possible other string functions expecting a null termination. Simply take bytes received and use as an index to append \0 after. We are creating buffer[] with size of MAX_INPUT_BUFFER and recv with MAX_INPUT_BUFFER-1 so this should never overflow.
 2014-06-28 18:17:48 +02:00
Spenser Reinhardt
9ce73696b0 plugins/check_apt.c - Print uninitialized ereg 
Coverity 66531 - ereg.buffer can be printed without being initialized if do_include and do_exclude are null and critical is an invalid regex. While minor this may leak memory and cause undefined behavior.
 2014-06-28 18:16:59 +02:00
Eric J. Mislivec
6e246799b9 Include common.h before any system headers. 
This should fix some problems building on AIX.
 2014-06-28 18:09:28 +02:00
Sven Nierlein
7508da9360 Merge pull request #1261 from sni/master 
tests: always build and test on travis
 2014-06-24 15:08:41 +02:00
Sven Nierlein
b35d12e931 tests: always build and test on travis 
also make test is now working on travis-ci

Signed-off-by: Sven Nierlein <sven@nierlein.de>
 2014-06-24 15:07:44 +02:00
Jan Wagner
580bdd2863 check_ide_smart: Fixing spelling bug 2014-06-23 22:33:29 +02:00
Jan Wagner
9ac3fe7d50 check_mrtg: Fixing spelling bug 2014-06-23 22:28:28 +02:00
Jan Wagner
be55da1d23 check_ups/check_dbi: Fixing spelling bug 2014-06-23 22:20:03 +02:00
Holger Weiss
f52efd00bf NEWS: Add missing entries for the upcoming release 2014-06-23 01:20:37 +02:00
Holger Weiss
d67a293db2 THANKS.in: Add new authors 
Add the new Git commit authors to the THANKS.in file.
 2014-06-22 23:54:55 +02:00
Holger Weiss
f518395410 NEWS: Add missing tab characters 2014-06-22 21:58:25 +02:00
Holger Weiss
7979837c0d check_radius.c: Add newline to die() calls 
Our die() function doesn't append a newline character to the message.
 2014-06-22 21:43:38 +02:00
Holger Weiss
0170bc48d1 configure.ac: Change RADIUS library preferences 
Prefer the FreeRADIUS Client library over radiusclient-ng, and prefer
that one over the original radiusclient library.
 2014-06-22 14:12:55 +02:00
Holger Weiss
c0311d9848 check_radius: Support FreeRADIUS Client library 
Allow for using the FreeRADIUS Client library instead of radiusclient or
radiusclient-ng.  The latter two projects are dead.

Closes #1231.
 2014-06-22 14:10:38 +02:00
Holger Weiss
22e7b78685 REQUIREMENTS: Update radiusclient-ng URL 
The project was moved to SourceForge.net.
 2014-06-22 13:59:57 +02:00
Holger Weiss
eb85a612a3 Add UID to state retention file path 
Add the UID of the invoking user to the state retention file path.  This
helps solving permission issues when different users run the same
plugin.
 2014-06-21 15:15:44 +02:00
Holger Weiss
8a932865eb NEWS: s/MP_STATE_DIRECTORY/MP_STATE_PATH/ 
NAGIOS_PLUGIN_STATE_DIRECTORY was renamed to MP_STATE_PATH, not to
MP_STATE_DIRECTORY.
 2014-06-20 12:35:22 +02:00
Holger Weiss
dc0f25cf76 lib/parse_ini.c: Print proper read error message 
Print a useful error message if opening the configuration file fails.
 2014-06-18 23:42:57 +02:00
Holger Weiss
48025ff39c lib/parse_ini.c: Drop privileges for reading file 
Read the configuration file with privileges temporarily dropped if the
code is used by a setuid plugin.
 2014-06-18 23:22:12 +02:00
Holger Weiss
2bf7647be6 lib/parse_ini.c: Add newline to die() calls 
Our die() function doesn't append a newline character to the message.
 2014-06-18 23:15:21 +02:00
Holger Weiss
b81c10e00c lib/parse_ini.c: Cosmetic change 
Replace an "if" with the ternary operator.
 2014-06-18 23:09:02 +02:00
Holger Weiss
91d04ad62d Add Gnulib module "idpriv-droptemp" 2014-06-18 21:47:10 +02:00
Holger Weiss
ae24aaeefb Use FindBin consistently across Perl plugins 
Use Perl's FindBin module to locate the path to utils.pm in
check_file_age.pl and check_mssql.pl, just as we do in other Perl
plugins.
 2014-06-18 18:45:10 +02:00
Holger Weiss
b63974c2cb plugins/runcmd.c: Remove superfluous newline 
The puts(3) function already appends a newline character to the string.
 2014-06-18 18:40:23 +02:00