Commit graph

61012 commits

Author SHA1 Message Date
Vincent Petry
11c7e100ae
Properly hide progress bar after error
Whenever an error occurs, also hide the progress bar.

The logic was also adjusted to properly detect uploads that are pending
deletion, in which case the progress bar can already be hidden.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-01-12 20:21:12 +01:00
Vincent Petry
6c4d4d8bc4
Properly abort uploads
Add a new approach for flagging an upload as aborted because we can't
rely on the browser fully cancelling the request as we now seem to
receive an error response from the server instead of a jQuery "abort"
message.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-01-12 20:21:12 +01:00
Louis
8d813219c0
Merge pull request #30605 from nextcloud/fix/remove_legacy_build_files
Clear dist folder during build
2022-01-12 15:56:23 +01:00
Louis
9ec76d35b6
Merge pull request #30606 from nextcloud/deps/drop_eslint-webpack-loader
Drop eslint-loader
2022-01-12 15:55:56 +01:00
Louis
2e1491771e
Merge pull request #30572 from nextcloud/fix/lint_warnings
Fix lint warnings
2022-01-12 15:48:36 +01:00
Vincent Petry
db9fbc9307
Merge pull request #30593 from nextcloud/bugfix/19048/fix-changedirectory-recommendations
Trigger "changeDirectory" event on URL change
2022-01-12 14:41:50 +01:00
Joas Schilling
0d0fcd316a
Merge pull request #30625 from nextcloud/enh/jsconfig-theme-perf
Remove shortFooter/longFooter to avoid unnecessary navigation loading
2022-01-12 14:23:31 +01:00
Julius Härtl
55fd974926
Remove shortFooter/longFooter to avoid unnecessary navigation loading
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-01-12 12:16:39 +01:00
Louis
55cb608449
Merge pull request #30485 from nextcloud/fix/correctly_set_the_mtime_in_bulk_upload
Set the file's mtime from the headers in bulk upload
2022-01-12 11:57:23 +01:00
Louis Chemineau
ae6a9807c8 Drop eslint-loader
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-12 11:34:58 +01:00
Vincent Petry
8c75fcfbb8
Merge pull request #30609 from nextcloud/fix/noid/request-url-cli-check
Fix RequestURL check for cli commands
2022-01-12 09:07:05 +01:00
Nextcloud bot
41529ec22d
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-12 02:26:58 +00:00
Carl Schwan
08bf47a5de
Fix RequestURL check for cli commands
Fix https://github.com/nextcloud/files_automatedtagging/issues/526

Fix https://github.com/nextcloud/groupfolders/issues/1855

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-11 19:45:07 +01:00
Pytal
2bc0749cb6
Merge pull request #30588 from nextcloud/bugfix/noid/fix-unset-scopes 2022-01-11 10:12:11 -08:00
Vincent Petry
809e305444
Trigger "changeDirectory" even on URL change
When using the browser back button or clicking on sections on the left
sidebar (like favorites), the "changeDirectory" jQuery event did not get
called, so apps like recommendations would not notice the directory
change.

This fixes the issue by also setting changeUrl to true when the file
list's directory got changed as a result from a URL change.

Added optional changedThroughUrl argument to make sure the event
recipient knows if the change was done through a URL change and make it
possible prevent a loop in the onDirectoryChange handler that actually
changes the URL when the origin was already from a URL change.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-01-11 17:48:03 +01:00
Louis Chemineau
bfdfafde79 Compile frontend to update license files
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 17:26:40 +01:00
Louis Chemineau
14e57bf70a Replace license information to SPDX expression
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 17:26:40 +01:00
Louis Chemineau
bc47234e6b Remove legacy build files
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 17:16:05 +01:00
Louis Chemineau
37e5050d69 Import type from packages
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 17:13:08 +01:00
Louis Chemineau
9fc6cc9634 Add generic type and description when its missing
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 17:13:04 +01:00
Louis Chemineau
d92cbf5149 Typing corrections
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 17:12:55 +01:00
Louis Chemineau
69b8044b8f Set the file's mtime from the headers in bulk upload
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 17:10:14 +01:00
Louis Chemineau
2b1de9957c Clear dist folder during build
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 16:59:35 +01:00
MichaIng
796764aafd
Merge pull request #30533 from nextcloud/fix/avoid-zero-division
Avoid zero division in setup checks
2022-01-11 13:39:02 +01:00
Joas Schilling
c47406ad3c
Merge pull request #30291 from nextcloud/image-memory-limit
Prevent loading images that would require too much memory.
2022-01-11 13:35:56 +01:00
blizzz
b23934a45e
Merge pull request #30569 from nextcloud/fix/userlang_firstlogin
Default to language from request in L10N\Factory->getUserLanguage()
2022-01-11 12:59:07 +01:00
Joas Schilling
172be810b8
Fix test
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-11 12:54:41 +01:00
Joas Schilling
bce7f09336
Merge pull request #30570 from nextcloud/rakekniven-branch3
Removed obselete language files - Pt. II
2022-01-11 11:56:56 +01:00
Joachim Bauch
d3d65e5c88
Prevent loading images that would require too much memory.
For most image formats, the header specifies the width/height.
PHP allocates an image object from that size, even if the actual
image data is much smaller. This image object size is not limited
by the limit configured in PHP.

The memory limit can be configured through "config.php" setting
"preview_max_memory" and defaults to 128 MBytes which should be
enough for most images without filling up all memory.

Signed-off-by: Joachim Bauch <bauch@struktur.de>
2022-01-11 11:44:38 +01:00
MichaIng
79cdb565dc Avoid zero division in setup checks
Fixes: https://github.com/nextcloud/server/issues/30532

Signed-off-by: MichaIng <micha@dietpi.com>
2022-01-11 10:26:57 +00:00
Louis
6c3e9822e6
Merge pull request #30582 from nextcloud/fix/streamline_clearing_static_state
Streamline reseting of private static properties
2022-01-11 11:22:48 +01:00
Louis Chemineau
25ade6218a Streamline reseting of private static properties
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 10:29:25 +01:00
Joas Schilling
3c84570901
Fix undefined/unset scope in account properties
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-11 10:15:06 +01:00
Nextcloud bot
7484abb6c0
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-11 02:27:07 +00:00
John Molakvoæ
5faba45e63
Merge pull request #30571 from nextcloud/fix/missing-jquery 2022-01-10 20:03:21 +01:00
Louis Chemineau
92e60caa86 Revert "Streamline reseting of private static properties"
This reverts commit e50121d4c0.
2022-01-10 18:42:07 +01:00
Louis Chemineau
e50121d4c0 Streamline reseting of private static properties
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-10 17:34:48 +01:00
Vincent Petry
db0414ad4c
Merge pull request #30499 from nextcloud/bugfix/29941/remove-shareinfo-query-from-scanner
Remove inefficient fed share scanner
2022-01-10 16:42:23 +01:00
Vincent Petry
5c7ab1fdb1
Merge pull request #30565 from nextcloud/bugfix/30564/fix-mkdir-fail-when-keys-folder-exists
Fix fail when keys/files folder already exists
2022-01-10 16:42:02 +01:00
Vincent Petry
8954e51207
Merge pull request #30567 from nextcloud/bugfix/noid/npm-ci-for-karma
Use npm ci when running JS tests
2022-01-10 16:41:11 +01:00
Vincent Petry
6aba3964d3
Fix JS tests after test lib updates
Prevent XHR during load by checking window.TESTING.
Adjust some expected values.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-01-10 15:08:03 +01:00
Azul
94554c4c0d fix: only use jquery once it is available
publicpage.js is loaded very early and cannot rely on jquery being loaded already.

Move the use of `$` into the `DomContentLoaded` handler.

Signed-off-by: Azul <azul@riseup.net>
2022-01-10 14:55:07 +01:00
Vincent Petry
82ded36358
Update node deps for JS tests
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-01-10 14:17:09 +01:00
rakekniven
2f6c7b68ab Removed obselete language files - Pt. II
For these files there are no associated languages setup at Transifex.

Fix for #30501

Related to nextcloud/docker-ci#341

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2022-01-10 14:07:14 +01:00
Jonas Meurer
a6f0278e67
Default to language from request in L10N\Factory->getUserLanguage()
Try to get the language from request before falling back to the instance
default.

This fixes the detected user language during first login of a new user
and ensures that the returned language is consistent during the login.

Also partially fixes a bug with Collectives folder being initialized
in different languages at first login, see
https://gitlab.com/collectivecloud/collectives/-/issues/238

Signed-off-by: Jonas Meurer <jonas@freesources.org>
2022-01-10 13:06:23 +01:00
Vincent Petry
e96c003d49
Use npm ci when running JS tests
This makes sure that the pinned versions are selected correctly.
Fixes the colors.js incident.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-01-10 12:00:16 +01:00
John Molakvoæ
6572f80102
Merge pull request #30561 from nextcloud/rakekniven-branch2 2022-01-10 11:43:24 +01:00
Vincent Petry
ce31914314
Remove inefficient fed share scanner
Remove scanAll which relies on the "shareinfo" endpoint that returns the
full cache tree.
The latter can become big for big shares and result in timeouts.
Furthermode, the full tree would be retrieved again for each and every
detected change which can become expensive quickly.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-01-10 11:33:28 +01:00
Vincent Petry
be590df588
Fix fail when keys/files folder already exists
Fixes an issue with transfer ownership in move mode where the folder
"files_encryption/keys/files" already exists.

Instead of failing, its existence is checked before calling mkdir.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-01-10 11:15:22 +01:00
Carl Schwan
91c7efaeb6
Merge pull request #30020 from nextcloud/feat/webpack-vendors-bundles
Feat/webpack vendors bundles
2022-01-10 09:41:18 +01:00