mirror of
https://github.com/postgres/postgres.git
synced 2026-03-13 22:28:01 -04:00
7c98759e04
If the substring start index and length overflow when added together,
substring() misbehaved, either throwing a bogus "negative substring
length" error on a case that should succeed, or failing to complain that
a negative length is negative (and instead returning the whole string,
in most cases). Unsurprisingly, the text, bytea, and bit variants of
the function all had this issue. Rearrange the logic to ensure that
negative lengths are always rejected, and add an overflow check to
handle the other case.
Also install similar guards into detoast_attr_slice() (nee
heap_tuple_untoast_attr_slice()), since it's far from clear that
no other code paths leading to that function could pass it values
that would overflow.
Patch by myself and Pavel Stehule, per bug #16804 from Rafi Shamim.
Back-patch to v11. While these bugs are old, the common/int.h
infrastructure for overflow-detecting arithmetic didn't exist before
commit 4d6ad3125, and it doesn't seem like these misbehaviors are bad
enough to justify developing a standalone fix for the older branches.
Discussion: https://postgr.es/m/16804-f4eeeb6c11ba71d4@postgresql.org
227 lines
7.5 KiB
SQL
227 lines
7.5 KiB
SQL
--
|
|
-- BIT types
|
|
--
|
|
|
|
--
|
|
-- Build tables for testing
|
|
--
|
|
|
|
CREATE TABLE BIT_TABLE(b BIT(11));
|
|
|
|
INSERT INTO BIT_TABLE VALUES (B'10'); -- too short
|
|
INSERT INTO BIT_TABLE VALUES (B'00000000000');
|
|
INSERT INTO BIT_TABLE VALUES (B'11011000000');
|
|
INSERT INTO BIT_TABLE VALUES (B'01010101010');
|
|
INSERT INTO BIT_TABLE VALUES (B'101011111010'); -- too long
|
|
--INSERT INTO BIT_TABLE VALUES ('X554');
|
|
--INSERT INTO BIT_TABLE VALUES ('X555');
|
|
|
|
SELECT * FROM BIT_TABLE;
|
|
|
|
CREATE TABLE VARBIT_TABLE(v BIT VARYING(11));
|
|
|
|
INSERT INTO VARBIT_TABLE VALUES (B'');
|
|
INSERT INTO VARBIT_TABLE VALUES (B'0');
|
|
INSERT INTO VARBIT_TABLE VALUES (B'010101');
|
|
INSERT INTO VARBIT_TABLE VALUES (B'01010101010');
|
|
INSERT INTO VARBIT_TABLE VALUES (B'101011111010'); -- too long
|
|
--INSERT INTO VARBIT_TABLE VALUES ('X554');
|
|
--INSERT INTO VARBIT_TABLE VALUES ('X555');
|
|
SELECT * FROM VARBIT_TABLE;
|
|
|
|
|
|
-- Concatenation
|
|
SELECT v, b, (v || b) AS concat
|
|
FROM BIT_TABLE, VARBIT_TABLE
|
|
ORDER BY 3;
|
|
|
|
-- Length
|
|
SELECT b, length(b) AS lb
|
|
FROM BIT_TABLE;
|
|
SELECT v, length(v) AS lv
|
|
FROM VARBIT_TABLE;
|
|
|
|
-- Substring
|
|
SELECT b,
|
|
SUBSTRING(b FROM 2 FOR 4) AS sub_2_4,
|
|
SUBSTRING(b FROM 7 FOR 13) AS sub_7_13,
|
|
SUBSTRING(b FROM 6) AS sub_6
|
|
FROM BIT_TABLE;
|
|
SELECT v,
|
|
SUBSTRING(v FROM 2 FOR 4) AS sub_2_4,
|
|
SUBSTRING(v FROM 7 FOR 13) AS sub_7_13,
|
|
SUBSTRING(v FROM 6) AS sub_6
|
|
FROM VARBIT_TABLE;
|
|
|
|
-- test overflow cases
|
|
SELECT SUBSTRING('01010101'::bit(8) FROM 2 FOR 2147483646) AS "1010101";
|
|
SELECT SUBSTRING('01010101'::bit(8) FROM -10 FOR 2147483646) AS "01010101";
|
|
SELECT SUBSTRING('01010101'::bit(8) FROM -10 FOR -2147483646) AS "error";
|
|
SELECT SUBSTRING('01010101'::varbit FROM 2 FOR 2147483646) AS "1010101";
|
|
SELECT SUBSTRING('01010101'::varbit FROM -10 FOR 2147483646) AS "01010101";
|
|
SELECT SUBSTRING('01010101'::varbit FROM -10 FOR -2147483646) AS "error";
|
|
|
|
--- Bit operations
|
|
DROP TABLE varbit_table;
|
|
CREATE TABLE varbit_table (a BIT VARYING(16), b BIT VARYING(16));
|
|
COPY varbit_table FROM stdin;
|
|
X0F X10
|
|
X1F X11
|
|
X2F X12
|
|
X3F X13
|
|
X8F X04
|
|
X000F X0010
|
|
X0123 XFFFF
|
|
X2468 X2468
|
|
XFA50 X05AF
|
|
X1234 XFFF5
|
|
\.
|
|
|
|
SELECT a, b, ~a AS "~ a", a & b AS "a & b",
|
|
a | b AS "a | b", a # b AS "a # b" FROM varbit_table;
|
|
SELECT a,b,a<b AS "a<b",a<=b AS "a<=b",a=b AS "a=b",
|
|
a>=b AS "a>=b",a>b AS "a>b",a<>b AS "a<>b" FROM varbit_table;
|
|
SELECT a,a<<4 AS "a<<4",b,b>>2 AS "b>>2" FROM varbit_table;
|
|
|
|
DROP TABLE varbit_table;
|
|
|
|
--- Bit operations
|
|
DROP TABLE bit_table;
|
|
CREATE TABLE bit_table (a BIT(16), b BIT(16));
|
|
COPY bit_table FROM stdin;
|
|
X0F00 X1000
|
|
X1F00 X1100
|
|
X2F00 X1200
|
|
X3F00 X1300
|
|
X8F00 X0400
|
|
X000F X0010
|
|
X0123 XFFFF
|
|
X2468 X2468
|
|
XFA50 X05AF
|
|
X1234 XFFF5
|
|
\.
|
|
|
|
SELECT a,b,~a AS "~ a",a & b AS "a & b",
|
|
a|b AS "a | b", a # b AS "a # b" FROM bit_table;
|
|
SELECT a,b,a<b AS "a<b",a<=b AS "a<=b",a=b AS "a=b",
|
|
a>=b AS "a>=b",a>b AS "a>b",a<>b AS "a<>b" FROM bit_table;
|
|
SELECT a,a<<4 AS "a<<4",b,b>>2 AS "b>>2" FROM bit_table;
|
|
|
|
DROP TABLE bit_table;
|
|
|
|
|
|
-- The following should fail
|
|
select B'001' & B'10';
|
|
select B'0111' | B'011';
|
|
select B'0010' # B'011101';
|
|
|
|
-- More position tests, checking all the boundary cases
|
|
SELECT POSITION(B'1010' IN B'0000101'); -- 0
|
|
SELECT POSITION(B'1010' IN B'00001010'); -- 5
|
|
SELECT POSITION(B'1010' IN B'00000101'); -- 0
|
|
SELECT POSITION(B'1010' IN B'000001010'); -- 6
|
|
|
|
SELECT POSITION(B'' IN B'00001010'); -- 1
|
|
SELECT POSITION(B'0' IN B''); -- 0
|
|
SELECT POSITION(B'' IN B''); -- 0
|
|
SELECT POSITION(B'101101' IN B'001011011011011000'); -- 3
|
|
SELECT POSITION(B'10110110' IN B'001011011011010'); -- 3
|
|
SELECT POSITION(B'1011011011011' IN B'001011011011011'); -- 3
|
|
SELECT POSITION(B'1011011011011' IN B'00001011011011011'); -- 5
|
|
|
|
SELECT POSITION(B'11101011' IN B'11101011'); -- 1
|
|
SELECT POSITION(B'11101011' IN B'011101011'); -- 2
|
|
SELECT POSITION(B'11101011' IN B'00011101011'); -- 4
|
|
SELECT POSITION(B'11101011' IN B'0000011101011'); -- 6
|
|
|
|
SELECT POSITION(B'111010110' IN B'111010110'); -- 1
|
|
SELECT POSITION(B'111010110' IN B'0111010110'); -- 2
|
|
SELECT POSITION(B'111010110' IN B'000111010110'); -- 4
|
|
SELECT POSITION(B'111010110' IN B'00000111010110'); -- 6
|
|
|
|
SELECT POSITION(B'111010110' IN B'11101011'); -- 0
|
|
SELECT POSITION(B'111010110' IN B'011101011'); -- 0
|
|
SELECT POSITION(B'111010110' IN B'00011101011'); -- 0
|
|
SELECT POSITION(B'111010110' IN B'0000011101011'); -- 0
|
|
|
|
SELECT POSITION(B'111010110' IN B'111010110'); -- 1
|
|
SELECT POSITION(B'111010110' IN B'0111010110'); -- 2
|
|
SELECT POSITION(B'111010110' IN B'000111010110'); -- 4
|
|
SELECT POSITION(B'111010110' IN B'00000111010110'); -- 6
|
|
|
|
SELECT POSITION(B'111010110' IN B'000001110101111101011'); -- 0
|
|
SELECT POSITION(B'111010110' IN B'0000001110101111101011'); -- 0
|
|
SELECT POSITION(B'111010110' IN B'000000001110101111101011'); -- 0
|
|
SELECT POSITION(B'111010110' IN B'00000000001110101111101011'); -- 0
|
|
|
|
SELECT POSITION(B'111010110' IN B'0000011101011111010110'); -- 14
|
|
SELECT POSITION(B'111010110' IN B'00000011101011111010110'); -- 15
|
|
SELECT POSITION(B'111010110' IN B'0000000011101011111010110'); -- 17
|
|
SELECT POSITION(B'111010110' IN B'000000000011101011111010110'); -- 19
|
|
|
|
SELECT POSITION(B'000000000011101011111010110' IN B'000000000011101011111010110'); -- 1
|
|
SELECT POSITION(B'00000000011101011111010110' IN B'000000000011101011111010110'); -- 2
|
|
SELECT POSITION(B'0000000000011101011111010110' IN B'000000000011101011111010110'); -- 0
|
|
|
|
|
|
-- Shifting
|
|
|
|
CREATE TABLE BIT_SHIFT_TABLE(b BIT(16));
|
|
INSERT INTO BIT_SHIFT_TABLE VALUES (B'1101100000000000');
|
|
INSERT INTO BIT_SHIFT_TABLE SELECT b>>1 FROM BIT_SHIFT_TABLE;
|
|
INSERT INTO BIT_SHIFT_TABLE SELECT b>>2 FROM BIT_SHIFT_TABLE;
|
|
INSERT INTO BIT_SHIFT_TABLE SELECT b>>4 FROM BIT_SHIFT_TABLE;
|
|
INSERT INTO BIT_SHIFT_TABLE SELECT b>>8 FROM BIT_SHIFT_TABLE;
|
|
SELECT POSITION(B'1101' IN b),
|
|
POSITION(B'11011' IN b),
|
|
b
|
|
FROM BIT_SHIFT_TABLE ;
|
|
SELECT b, b >> 1 AS bsr, b << 1 AS bsl
|
|
FROM BIT_SHIFT_TABLE ;
|
|
SELECT b, b >> 8 AS bsr8, b << 8 AS bsl8
|
|
FROM BIT_SHIFT_TABLE ;
|
|
SELECT b::bit(15), b::bit(15) >> 1 AS bsr, b::bit(15) << 1 AS bsl
|
|
FROM BIT_SHIFT_TABLE ;
|
|
SELECT b::bit(15), b::bit(15) >> 8 AS bsr8, b::bit(15) << 8 AS bsl8
|
|
FROM BIT_SHIFT_TABLE ;
|
|
|
|
|
|
CREATE TABLE VARBIT_SHIFT_TABLE(v BIT VARYING(20));
|
|
INSERT INTO VARBIT_SHIFT_TABLE VALUES (B'11011');
|
|
INSERT INTO VARBIT_SHIFT_TABLE SELECT CAST(v || B'0' AS BIT VARYING(6)) >>1 FROM VARBIT_SHIFT_TABLE;
|
|
INSERT INTO VARBIT_SHIFT_TABLE SELECT CAST(v || B'00' AS BIT VARYING(8)) >>2 FROM VARBIT_SHIFT_TABLE;
|
|
INSERT INTO VARBIT_SHIFT_TABLE SELECT CAST(v || B'0000' AS BIT VARYING(12)) >>4 FROM VARBIT_SHIFT_TABLE;
|
|
INSERT INTO VARBIT_SHIFT_TABLE SELECT CAST(v || B'00000000' AS BIT VARYING(20)) >>8 FROM VARBIT_SHIFT_TABLE;
|
|
SELECT POSITION(B'1101' IN v),
|
|
POSITION(B'11011' IN v),
|
|
v
|
|
FROM VARBIT_SHIFT_TABLE ;
|
|
SELECT v, v >> 1 AS vsr, v << 1 AS vsl
|
|
FROM VARBIT_SHIFT_TABLE ;
|
|
SELECT v, v >> 8 AS vsr8, v << 8 AS vsl8
|
|
FROM VARBIT_SHIFT_TABLE ;
|
|
|
|
DROP TABLE BIT_SHIFT_TABLE;
|
|
DROP TABLE VARBIT_SHIFT_TABLE;
|
|
|
|
-- Get/Set bit
|
|
SELECT get_bit(B'0101011000100', 10);
|
|
SELECT set_bit(B'0101011000100100', 15, 1);
|
|
SELECT set_bit(B'0101011000100100', 16, 1); -- fail
|
|
|
|
-- Overlay
|
|
SELECT overlay(B'0101011100' placing '001' from 2 for 3);
|
|
SELECT overlay(B'0101011100' placing '101' from 6);
|
|
SELECT overlay(B'0101011100' placing '001' from 11);
|
|
SELECT overlay(B'0101011100' placing '001' from 20);
|
|
|
|
-- This table is intentionally left around to exercise pg_dump/pg_upgrade
|
|
CREATE TABLE bit_defaults(
|
|
b1 bit(4) DEFAULT '1001',
|
|
b2 bit(4) DEFAULT B'0101',
|
|
b3 bit varying(5) DEFAULT '1001',
|
|
b4 bit varying(5) DEFAULT B'0101'
|
|
);
|
|
\d bit_defaults
|
|
INSERT INTO bit_defaults DEFAULT VALUES;
|
|
TABLE bit_defaults;
|