postgresql/src/bin/pg_basebackup
Tom Lane cce939c71c Exit after fatal errors in client-side compression code.
It looks like whoever wrote the astreamer (nee bbstreamer) code
thought that pg_log_error() is equivalent to elog(ERROR), but
it's not; it just prints a message.  So all these places tried to
continue on after a compression or decompression error return,
with the inevitable result being garbage output and possibly
cascading error messages.  We should use pg_fatal() instead.

These error conditions are probably pretty unlikely in practice,
which no doubt accounts for the lack of field complaints.

Author: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://postgr.es/m/1531718.1772644615@sss.pgh.pa.us
Backpatch-through: 15
2026-03-05 14:43:21 -05:00
..
po Translation updates 2026-02-08 15:11:02 +01:00
t Symlink pg_replslot robustly on Windows in pg_basebackup test 2024-07-08 13:52:32 -04:00
.gitignore Rename user-facing tools with "xlog" in the name to say "wal". 2017-02-09 16:23:46 -05:00
bbstreamer.h Fix some typos and some incorrectly duplicated words 2023-04-18 14:03:49 +12:00
bbstreamer_file.c Fix pg_basebackup with in-place tablespaces some more. 2023-04-18 11:23:34 -04:00
bbstreamer_gzip.c Exit after fatal errors in client-side compression code. 2026-03-05 14:43:21 -05:00
bbstreamer_inject.c Update copyright for 2023 2023-01-02 15:00:37 -05:00
bbstreamer_lz4.c Exit after fatal errors in client-side compression code. 2026-03-05 14:43:21 -05:00
bbstreamer_tar.c Update copyright for 2023 2023-01-02 15:00:37 -05:00
bbstreamer_zstd.c Exit after fatal errors in client-side compression code. 2026-03-05 14:43:21 -05:00
Makefile Update copyright for 2023 2023-01-02 15:00:37 -05:00
meson.build Add missing pg_basebackup TAP test for meson. 2023-06-16 10:32:49 +09:00
nls.mk pg_basebackup: Restore lost translation markers 2023-05-08 06:15:26 +02:00
pg_basebackup.c pg_basebackup: Generate valid temporary slot names under PQbackendPID() 2023-09-07 14:12:25 +09:00
pg_receivewal.c Pre-beta mechanical code beautification. 2023-05-19 17:24:48 -04:00
pg_recvlogical.c Update copyright for 2023 2023-01-02 15:00:37 -05:00
receivelog.c Fix off_t overflow in pg_basebackup on Windows. 2025-01-09 16:05:08 +13:00
receivelog.h Update copyright for 2023 2023-01-02 15:00:37 -05:00
streamutil.c pg_basebackup: Correct type of WalSegSz 2023-04-03 07:21:06 +02:00
streamutil.h pg_basebackup: Correct type of WalSegSz 2023-04-03 07:21:06 +02:00
walmethods.c Fix off_t overflow in pg_basebackup on Windows. 2025-01-09 16:05:08 +13:00
walmethods.h Fix off_t overflow in pg_basebackup on Windows. 2025-01-09 16:05:08 +13:00