mirror of
https://github.com/postgres/postgres.git
synced 2026-04-06 01:35:56 -04:00
It looks like whoever wrote the astreamer (nee bbstreamer) code thought that pg_log_error() is equivalent to elog(ERROR), but it's not; it just prints a message. So all these places tried to continue on after a compression or decompression error return, with the inevitable result being garbage output and possibly cascading error messages. We should use pg_fatal() instead. These error conditions are probably pretty unlikely in practice, which no doubt accounts for the lack of field complaints. Author: Tom Lane <tgl@sss.pgh.pa.us> Reviewed-by: Chao Li <li.evan.chao@gmail.com> Discussion: https://postgr.es/m/1531718.1772644615@sss.pgh.pa.us Backpatch-through: 15 |
||
|---|---|---|
| .. | ||
| po | ||
| t | ||
| .gitignore | ||
| bbstreamer.h | ||
| bbstreamer_file.c | ||
| bbstreamer_gzip.c | ||
| bbstreamer_inject.c | ||
| bbstreamer_lz4.c | ||
| bbstreamer_tar.c | ||
| bbstreamer_zstd.c | ||
| Makefile | ||
| meson.build | ||
| nls.mk | ||
| pg_basebackup.c | ||
| pg_receivewal.c | ||
| pg_recvlogical.c | ||
| receivelog.c | ||
| receivelog.h | ||
| streamutil.c | ||
| streamutil.h | ||
| walmethods.c | ||
| walmethods.h | ||