34894 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Tommy O'Keefe	13cccebef0	Merge pull request #38019 from hashicorp/tommy/contribution-guide-ai-updates ... docs: add link for new AI Usage section to CONTRIBUTING.md TOC	2025-12-18 12:04:44 -05:00
tommyokeefe	14181ad0c6	docs: add link for new AI Usage section to CONTRIBUTING.md TOC	2025-12-18 11:53:04 -05:00
Tommy O'Keefe	e27f9467c8	ocs: update CONTRIBUTING.md to include guidance for AI usage	2025-12-18 10:40:19 -05:00
tommyokeefe	ee446e8920	docs: update CONTRIBUTING.md to include guidance for AI usage	2025-12-18 09:09:13 -05:00
Sarah French	fd7f25120b	PSS: Allow pluggable state store configuration to be read from a plan file (#37957) ... * feat: Allow reading state store configuration from a planfile and using it to prepare a Local backend that uses the state store * test: Assert that we can get and use state store configuration from a plan file * test: Add integration test showing that an apply command can use a plan file to configure and use a state store * test: Add E2E test showing pluggable state storage being used with the full init-plan-apply workflow * feat: A plan file will report the state storage provider among its required providers, if PSS is in use. See the code comment added in this commit. This addition does not impact an apply command as the missing provider will be detected before this code is executed. However I'm making this change so that the method is still accurate is being able to return a complete list of providers needed by the plan. * fix: Include error messages when there is a problem parsing provider or state store config when getting a backend from a planfile * feat: Add trace logs to BackendForLocalPlan indicating when the provider is launched and the state store is configured * chore: Small grammar change in error diagnostic * refactor: Remove suggestions when the plan's state store doesn't match the implementations in the provider * test: Add test coverage of what happens when the contents of a plan file using PSS doesn't match the resources available in the project	2025-12-18 11:49:31 +00:00
Kevin Vu	c36c81431a	fix: validate replace_triggered_by attribute references (#38010) ... * fix: use schema-based validation for replace_triggered_by Fixes #36740 * fix: use change.ProviderAddr for schema lookup	2025-12-17 19:50:51 +00:00
Sarah French	f88d09544e	PSS: Add tests showing provider commands being used with PSS (#37959) ... * test: Add E2E test for using pluggable state storage with the `providers` command Note: I've excluded the `terraform providers locks` and `terraform providers mirror` commands as they don't interact with backends. * test: Add integration test for using pluggable state storage with the `providers` command * refactor: Change ioutil.ReadDir to os.ReadDir * test: Add integration test for using pluggable state storage with the `providers schema` command * feat: Allow state store schema's to be included when schemas are marshalled into JSON output * test: Assert that state stores are present in provider schemas returned from `providers schema`. * test: Update existing tests to accommodate state stores being in provider schema output * test: Update E2E test for `providers` commands to be better scoped to testing use of a state store to access and use state when generating output. This complements TestProvidersSchema that tests that state stores in a provider are reflected in the JSON representations of the schemas that the command returns. * chore: Replace `io/ioutil` with `io` in `providers schema` tests	2025-12-17 19:44:36 +00:00
Sarah French	578766bdc0	PSS: Add tests showing output and show commands being used with PSS (#37894) ... * test: Add E2E test demonstrating `output` command used with PSS * test: Add E2E test demonstrating `show` command used with PSS * docs: Fix code comment * test: Add integration test for using pluggable state storage with the `output` command * test: Add integration test for using pluggable state storage with the `show` command	2025-12-17 18:11:48 +00:00
Sarah French	940fbfb7ed	test: Add more test coverage of validate command's interaction with backend blocks (#37977) ... * test: Show how the validate command doesn't detect when an unknown backend type is in the config. * test: Minor fixes to error messages when test fails * test: Add some TODOs in code comments These tests are here to define existing behaviour, not define desired behaviour. I wanted to make that clear!	2025-12-17 18:09:54 +00:00
Sarah French	33d54b9a7c	test: Update module used for testing init's -from-module feature, so that the test can be run on darwin_arm64 platforms. (#38015)	2025-12-17 16:12:41 +00:00
hc-github-team-tf-core	e4ffb51022	Cleanup after 1.15.0-alpha20251203 release (#38002)	2025-12-15 18:10:57 +00:00
Radek Simko	213d133d86	command/meta: Enable migration from PSS to a backend (#37949) ... * command/meta: Enable migration from PSS to a backend * Address PR feedback * Update internal/command/meta_backend.go Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> * meta_backend: Rename stateStore_c_S to stateStore_to_backend --------- Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com>	2025-12-15 10:29:34 +00:00
Nick Fagerlund	b2aad914f1	stacks: Make path.module and path.root relative, to match documentation (#37982) ... * stacks: Make path.module and path.root relative, to match documentation Previously, we were just handing off the absolute path produced by the sourcebundle struct. But that's no good, because the value doesn't stay consistent between plan and apply when running under tfc-agent. (It uses working directories named after the unique job ID.) It also doesn't match the documentation, which describes these as relative paths. This was preventing people from uploading module-provided files to create aws lambda functions, for example. This commit addresses that by converting the source-bundle provided module path to a relative path (relative to Terraform's working directory). In tfc-agent for stacks runs, that ends up being the directory directly above the sourcebundle directory, and all the paths below that are consistent between plan and apply. * I think this is how the changelog thing works?	2025-12-12 11:05:32 -08:00
Sarah French	f591872699	PSS: Allow pluggable state store configuration to be stored in a plan file (#37956) ... * refactor: Rename Meta's backendState field to backendConfigState This helps with navigating ambiguity around the word backend. The new name should indicate that the value represents a `backend` block, not a more general interpretation of what a backend is. * fix: Only set backendConfigState to synthetic object if it's nil due to a lack of data. Don't change it if pluggable state storage is in use. * feat: Enable recording a state store's details in an Operation, and using that data when creating a plan file. * fix: Include provider config when writing a plan file using pluggable state storage * fix: Having `backendConfigState` be nil may be valid, but it definitely isn't valid for `stateStoreConfigState` to be nil When backendConfigState is nil it means that an implied local backend is in use, i.e. there is no backend block in the config. * test: Add integration test showing that a plan command creates a plan file with the expected state_store configuration data * refactor: Apply suggestion from @radeksimko Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com> * fix: Allow panics to occur if an unexpected implementation of `backend.Backend` is encountered when managing a state store * docs: Add code comment explaining the current situation with passing backend config state to downstream logic. In future this should be simplified, either via refactoring or changes affecting the implied local backend --------- Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com>	2025-12-11 11:41:36 +00:00
Daniel Schmidt	2eb22c8435	backport fix to 1.14	2025-12-11 10:42:52 +01:00
Daniel Schmidt	c71e0d736c	add changelog entry	2025-12-11 10:42:52 +01:00
Matej Risek	768b7bd0bc	Add local values walk to walk_dynamic ... This helps us catch diagnostics in locals that only happen during evaluation Co-authored-by: Mutahhir Hayat <mutahhir.hayat@hashicorp.com> Co-authored-by: Matej Risek <matej.risek@hashicorp.com>	2025-12-11 10:42:52 +01:00
Daniel Schmidt	889d605664	backport this change to 1.14	2025-12-11 10:36:44 +01:00
Daniel Schmidt	37e0194a23	changelog entry	2025-12-11 10:36:44 +01:00
Daniel Schmidt	871e836fc7	failing resource instance apply should keep prior state	2025-12-11 10:36:44 +01:00
stephybun	c9d024062a	Generate Resource Config: set state in proto req (#37895) ... * marshal state and set in the proto req for generate resource config * changelog * set state in the proto req for generate resource config in plugin6 * add GRPC tests for GenerateResourceConfig * remove changelog entry since this fix is backported to 1.14	2025-12-10 15:19:29 +01:00
James Pogran	2c075b9f8e	Add component registry source resolution support to Terraform Stacks (#37888) ... * Add component registry source resolution support to Terraform Stacks This change implements the missing component source resolution case in the stack configuration loader, enabling Terraform Stacks to properly handle component registry sources from HCP Terraform and other component registries. The implementation mirrors the existing module registry resolution workflow, where component sources are first resolved to their versioned form using the source bundle's component metadata, then converted to final source addresses that can be used to locate the actual component code. This completes the integration between the terraform-registry-address component parsing capabilities and the go-slug sourcebundle component resolution APIs. * chore: bump go-slug to v0.18.1 * fix: add case for component final source type * chore: rm space * chore: sync module deps * chore: update testdata with separate bundle * fix: manifest file json obj with trailing comma * Add changelog entry to 1.14 --------- Co-authored-by: Michael Yocca <michael.yocca@hashicorp.com>	2025-12-10 09:16:03 -05:00
Sarah French	a83b7402c2	PSS: Add tests showing state subcommands being used with PSS (#37891) ... * test: Add E2E tests for `state list` and `state show` commands * test: Update `mockPluggableStateStorageProvider` to log a warning during tests where the values in `MockStates` aren't compatible with the `ReadStateBytesFn` default function. Make existing test set an appropriate value in `MockStates`. * test: Update `mockPluggableStateStorageProvider` helper to include a resource schema * test: Add command-level test for `state list` showing integration with pluggable state storage code. * test: Add command-level test for `state show` showing integration with pluggable state storage code. * test: Add command-level test for `state pull` showing integration with pluggable state storage code. * test: Add command-level test for `state identities` showing integration with pluggable state storage code. * test: Add command-level test for `state rm` showing integration with pluggable state storage code. * test: Add command-level test for `state mv` showing integration with pluggable state storage code. * test: Add command-level test for `state push` showing integration with pluggable state storage code. * test: Add command-level test for `state replace-provider` showing integration with pluggable state storage code. * test: Change shared test fixture to not be named after a specific command under test. This test fixure is reused across tests that need the config to define a state store but otherwise rely on the mock provider to set up the test scenario. * test: Update test to use shared test fixture * test: Remove redundant test fixture The internal/command/testdata/state-commands-state-store and internal/command/testdata/state-store-unchanged test fixtures are the same. * fix: Re-add logic for setting chunk size in the context of E2E tests using grpcwrap package This was removed, incorrectly, in https://github.com/hashicorp/terraform/pull/37899 * refactor: Let panic happen if there's incompatibility between mock returned from `mockPluggableStateStorageProvider` and the `MockStates` that's been set in the mock * test: Refactor to contain paths in reused variable, remove unnecessary .gitkeep * test: Remove unneeded test code	2025-12-09 17:24:38 +00:00
Sarah French	3eea12a1d8	test: Add test coverage for what validate command checks in resource blocks versus backend blocks. (#37972) ... * test: Fix typo in test name * test: Show how the validate command validates resource blocks using their schema. * test: Show how the validate command doesn't use backends' schemas when validating backend blocks.	2025-12-05 18:13:58 +00:00
Sarah French	0941763d05	test: Add a test that shows a custom workspace being baked-into a planfile (#37917)	2025-12-04 14:59:01 +00:00
Vasist10	fe70f0a7db	fix: prevent zero-byte remote state writes (#37947)	2025-12-03 15:38:35 +00:00
Kristin Laemmert	869058f995	chore: add default events to the MockProvider's InvokeAction response (#37961)	2025-12-03 08:06:24 -05:00
hc-github-team-tf-core	b775ab5209	Prepare before 1.15.0-alpha20251203 release	2025-12-03 13:28:26 +01:00
dependabot[bot]	e8631898c9	build(deps): bump actions/checkout in the github-actions-breaking group (#37951)	2025-12-01 18:09:12 +00:00
Radek Simko	cd7fe4da84	github/build: Avoid double checkout to prevent errors on upgrade (#37941)	2025-12-01 15:55:19 +00:00
dependabot[bot]	f1bb0334d3	build(deps): bump the github-actions-backward-compatible group with 2 updates (#37952) ... Bumps the github-actions-backward-compatible group with 2 updates: [actions/setup-go](https://github.com/actions/setup-go) and [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action). Updates `actions/setup-go` from 6.0.0 to 6.1.0 - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](4469467582...4dc6199c7b) Updates `docker/setup-qemu-action` from 3.6.0 to 3.7.0 - [Release notes](https://github.com/docker/setup-qemu-action/releases) - [Commits](29109295f8...c7c5346462) --- updated-dependencies: - dependency-name: actions/setup-go dependency-version: 6.1.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions-backward-compatible - dependency-name: docker/setup-qemu-action dependency-version: 3.7.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions-backward-compatible ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2025-12-01 09:32:45 +00:00
Sarah French	9fb91c2229	PSS: Refactor Plan struct to reference Backend and StateStore via pointers, update calling code (#37946) ... * refactor: Update Plan struct's Backend field to be a pointer * fix: Add some refactorings or protections against nil pointers when accessing the Backend field on a Plan struct * refactor: Update Plan struct's StateStore field to be a pointer, update a nil check in calling code.	2025-11-28 16:12:46 +00:00
Sarah French	64015ca6d2	refactor: let panic arise directly if the provider doesn't implement providers.StateStoreChunkSizeSetter (#37942)	2025-11-28 13:48:32 +00:00
Sarah French	cf047be4e4	PSS: Use interfaces to configure state stores (#37899) ... * refactor: Move chunk size limit constants to new `chunks` package * refactor: Make `NewPluggable` return a `Pluggable` concrete type, instead of an instance of the `backend.Backend` interface. * refactor: Configure state stores through the backend.Backend interface, instead of directly using methods related to RPCs. This requires changing where we call `SetStateStoreChunkSize`. * docs: Add godocs comment to `StateStoreChunkSizeSetter` interface To summarize, we don't really need the `SetStateStoreChunkSize` method, and instead methods like `(*GRPCProvider).ConfigureStateStore` in the `plugin6` package can directly inspect the negotiation process that passes through that code and pull out the chunk size. However that means that that code would also need to implement validation. And that's just `(*GRPCProvider).ConfigureStateStore`; what about all the test mocks that are used in different types of test? They would all need to be implemented similarly to GRPCProvider to be good, useful mocks, and then a lot of things that fulfil the provider.Interface interface are coupled to each other. Instead, it's easier to have validation in the `grpcClient` struct's methods in the `remote` package, as that code is common to all scenarios. That code needs a method to 'reach into' the provider.Interface value, so we use the `SetStateStoreChunkSize` method. * chore: Make it clearer that the v6 GRPCProvider implements `SetStateStoreChunkSize` * fix: Remove unnecessary assignment of chunk size I'm surprised that removing this doesn't break E2E tests of PSS that use grpcwrap, but I think there's `plugin6` code that runs in that situation, so maybe chunking is handled elsewhere. * chore: Add panic to try detect unexpected cases when setting chunk size. * feat: Add `providers.StateStoreChunkSizeSetter` implementation to provider-simple-v6 * docs: Update code comments for NewPluggable describing its intended use	2025-11-26 13:34:22 +00:00
James Bardin	6ed7151b2c	Merge pull request #37923 from hashicorp/jbardin/nesting-group-schema-fixes ... fix handling of NestingGroup in the configschema package	2025-11-25 12:58:48 -05:00
Kevin Vu	87b3390189	fix: Make init backend messages JSON-compatible (#37920) ... * fix: Make all init backend messages JSON-compatible Fixes #37911 by converting all backend configuration messages to use the View abstraction, which properly formats output as JSON when the -json flag is used. Previously, certain messages were output directly using the legacy Ui abstraction, bypassing JSON formatting. Changes: - Added 11 new message codes to init.go MessageRegistry with both human and JSON formatted values - Replaced 11 direct m.Ui.Output() calls in meta_backend.go with View abstraction calls - Fixed output in backend_C_r_s(), backend_C_r_S_changed(), backend_c_r_S(), and stateStore_c_S() functions All init tests pass successfully. * docs: Add changelog entry for init JSON backend messages fix * cleanup: Remove unused backend output constants The following constants were moved to init.go as message registry entries and are no longer used in meta_backend.go: - outputBackendMigrateChange - outputBackendMigrateLocal - outputStateStoreMigrateLocal - outputBackendReconfigure - successBackendUnset - successBackendSet	2025-11-25 17:47:38 +00:00
Daniel Schmidt	65a23ed352	action: also set edges to expandable nodes on apply	2025-11-24 20:49:56 +01:00
Daniel Schmidt	7647923c53	actions: connect resource instance nodes to after actions	2025-11-24 20:49:56 +01:00
Sarah French	4381860dc6	fix: Make state show command exit with code 1 if the stored state cannot be marshalled for rendering (#37933) ... Prior to this change, when running a `state show` command with an address for a resource that existed in state but didn't match the current schema of the resource, users would see the "Failed to marshal" error but would also see output saying "The state file is empty. No resources are represented". This is misleading, as the state file isn't empty. Also, the command would exit with code 0 despite the error.	2025-11-24 15:49:47 +00:00
Sarah French	1a547775ff	refactor: Make the JSON view for init commands use defaults from the hclog package (#37840) ... * refactor: Change `(v *InitJSON) Output` to use logic from the hclog package to take advantage of default settings * docs: Add code comments	2025-11-24 08:21:37 -05:00
Steven Masley	3df28c3101	fix: Make terraform init JSON log timestamps include millisecond precision (#37818) ... * fix: terraform init log timestamps include millisecond precision * docs: add changelog entry	2025-11-21 19:24:03 +00:00
Daniel Schmidt	808713f56f	Fix changie entry ... I was linking to the issue we fixed, not the PR	2025-11-21 16:32:40 +01:00
dependabot[bot]	7034a193d9	build(deps): bump golang.org/x/crypto from 0.44.0 to 0.45.0 (#37925) ... * build(deps): bump golang.org/x/crypto from 0.44.0 to 0.45.0 Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.44.0 to 0.45.0. - [Commits](https://github.com/golang/crypto/compare/v0.44.0...v0.45.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.45.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * run syncdeps --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Daniel Banck <daniel@dbanck.de>	2025-11-21 10:54:50 +00:00
hc-github-team-tf-core	0d2a032f3b	Cleanup after 1.15.0-alpha20251119 release (#37922)	2025-11-19 16:52:28 -05:00
James Bardin	07a7d50f14	fix handling of NestingGroup ... ImpliedType did not have a clause to handle NestingGroup object types. CoerceValue would incorrectly return a null value for NestingGroup attributes.	2025-11-19 16:51:58 -05:00
hc-github-team-tf-core	ca5478bca7	Prepare for 1.15.0-alpha20251119 release (#37918) ... * Prepare before 1.15.0-alpha20251119 release --------- Co-authored-by: Kristin Laemmert <mildwonkey@users.noreply.github.com>	2025-11-19 13:20:50 -05:00
Radek Simko	d884031b4b	PSS: Implement unsetting of a state store (#37875) ... * Remove BackendOpts.ProviderFactory abstraction layer * PSS: Implement unsetting of a state store * address PR feedback	2025-11-19 13:43:46 +00:00
Sarah French	4420c4dcc0	PSS: Update the workspace new subcommand to work with PSS, add E2E and integration tests for using workspace commands with PSS. (#37855) ... * feat: Update the `workspace new` subcommand to work with PSS, add E2E testing * refactor: Replace instances of `ioutil` with `os` while looking at the workspace command * docs: Update code comments in `workspace new` command * test: Update E2E test using PSS with workspace commands to assert state files are created by given commands * test: Include `workspace show` in happy path E2E test using PSS * fix: Allow DeleteState RPC to include the id of the state to delete * test: Include `workspace delete` in happy path E2E test using PSS * fix: Avoid assignment to nil map in mock provider during WriteStateBytes * test: Add integration test for workspace commands when using PSS We still need an E2E test for this, to ensure that the GRPC-related packages pass all the expected data between core and the provider. * test: Update test to reflect changes in the test fixture configuration * docs: Fix code comment * test: Change test to build its own Terraform binary with experiments enabled * refactor: Replace use of `newMeta` with reuse of Meta that we re-set the UI value on	2025-11-19 12:50:43 +00:00
Kevin Vu	dc0eba33af	fix: support ephemeral resources in jsonchecks (#37893) ... Fixes #37834	2025-11-19 09:51:09 +01:00
Sarah French	1dd8e60f15	chore: Bump golang.org/x/crypto dependency, ignore SA4003 linting errors globally (#37901) ... * chore: Upgrade golang.org/x/crypto - `go get golang.org/x/crypto@v0.44.0` * chore: Upgrade golang.org/x/crypto in submodules - `make syncdeps` * chore: Run `make generate` * chore: Ignore SA4003 linter error globally, as `golang.org/x/tools/cmd/stringer` generates code that breaks this rule when it's used with custom types that have unsigned integers or bytes as the underlying type.	2025-11-17 15:01:28 +00:00